Replace is not None checks for linker flags with booleans#989
Merged
cpcloud merged 2 commits intoNVIDIA:mainfrom Sep 19, 2025
Merged
Replace is not None checks for linker flags with booleans#989cpcloud merged 2 commits intoNVIDIA:mainfrom
cpcloud merged 2 commits intoNVIDIA:mainfrom
Conversation
The earlier code would check for requested linker flags using "is not None" instead of True/False. This can result in unwanted flags being passed to the linker in some instances. This change replaces the "is not None" check with simple boolean checks where appropriate.
Contributor
leofang
added
bug
Member
|
/ok to test 6a31f6b |
Member
|
/ok to test 61a5fad |
This comment has been minimized.
This comment has been minimized.
leofang
approved these changes
Sep 19, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code checks for requested linker flags using "is not None" instead of testing for True/False. This can result in unwanted flags being passed to the linker in some instances. This change replaces the "is not None" check with simple boolean checks where appropriate.