Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Backport fixes for reordering in CUB member initializer lists into 2.0 branch #681

Merged
merged 2 commits into from
Apr 23, 2023
Merged

Backport fixes for reordering in CUB member initializer lists into 2.0 branch #681

merged 2 commits into from
Apr 23, 2023

Conversation

ericniebler
Copy link
Collaborator

fixes #604

@gevtushenko gevtushenko linked an issue Apr 21, 2023 that may be closed by this pull request
Backport fixes for reordering in CUB member initializer lists into 2.0 branch #604
Closed
gevtushenko added a commit to gevtushenko/thrust that referenced this pull request Apr 21, 2023
@gevtushenko
Testing NVIDIA/cub#681
7a95292
gevtushenko
gevtushenko suggested changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@gevtushenko gevtushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cub/agent/agent_histogram.cuh and cub/agent/agent_select_if.cuh fixes are not provided as part of this backport while the reordering seems to still be present there. Could you please backport fixes for the mentioned agents as well?

gevtushenko
gevtushenko approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@gevtushenko gevtushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll start testing, thanks!

gevtushenko added a commit to gevtushenko/thrust that referenced this pull request Apr 21, 2023
@gevtushenko
Testing NVIDIA/cub#681
2215422
@gevtushenko gevtushenko added the testing: gpuCI in progress Started gpuCI testing. label Apr 21, 2023
@gevtushenko gevtushenko merged commit b1a3300 into 2.0.X Apr 23, 2023
@gevtushenko gevtushenko deleted the port-#582-to-2.0 branch April 23, 2023 19:55
@gevtushenko gevtushenko mentioned this pull request Apr 23, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gevtushenko gevtushenko gevtushenko approved these changes

Assignees
No one assigned
Labels
testing: gpuCI in progress Started gpuCI testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backport fixes for reordering in CUB member initializer lists into 2.0 branch
2 participants
@ericniebler @gevtushenko