Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix reordering in CUB member initializer lists #582

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

gevtushenko
Copy link
Collaborator

This PR fixes reordering in member initializer lists. Since -Wall was added to host compiler, kernels were not covered. Specifying -Wreorder directly led to having those reordering visible.

@gevtushenko gevtushenko added the P1: should have Necessary, but not critical. label Oct 17, 2022
@gevtushenko gevtushenko added this to the 2.1.0 milestone Oct 17, 2022
gevtushenko added a commit to gevtushenko/thrust that referenced this pull request Oct 17, 2022
cmake/CubBuildCompilerTargets.cmake Show resolved Hide resolved
@gevtushenko gevtushenko added the testing: gpuCI passed Passed gpuCI testing. label Oct 18, 2022
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending small fixes mentioned inline.

cmake/CubBuildCompilerTargets.cmake Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1: should have Necessary, but not critical. testing: gpuCI passed Passed gpuCI testing.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants