Skip to content

Update cudaGraphAddDependencies for 13.0 #5691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alliepiper merged 1 commit into from
Aug 27, 2025
Merged

Update cudaGraphAddDependencies for 13.0 #5691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cudax/include/cuda/experimental/__graph/graph_node_ref.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,13 +244,24 @@ struct graph_node_ref
::cuda::std::fill(__src_arr.get(), __src_arr.get() + __deps.size(), __node_);

// Add the dependencies using __src_arr array and the span of dependencies.
#if _CCCL_CTK_AT_LEAST(13, 0)
_CCCL_TRY_CUDA_API(
cudaGraphAddDependencies,
"cudaGraphAddDependencies failed",
__graph_,
__deps.data(), // dependencies
__src_arr.get(), // dependant nodes
__nullptr, // no edge data
Copy link
Contributor

@alliepiper alliepiper Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/__nullptr/nullptr/, we all missed this 😅

I've fixed this in #5431.

__deps.size()); // number of dependencies
#else
_CCCL_TRY_CUDA_API(
cudaGraphAddDependencies,
"cudaGraphAddDependencies failed",
__graph_,
__deps.data(), // dependencies
__src_arr.get(), // dependant nodes
__deps.size()); // number of dependencies
#endif
}
}

Expand Down
Loading