Skip to content

Comments

Update cudaGraphAddDependencies for 13.0#5691

Merged
alliepiper merged 1 commit intoNVIDIA:mainfrom
pciolkosz:fix_graph_node_ref_in_13_0
Aug 27, 2025
Merged

Update cudaGraphAddDependencies for 13.0#5691
alliepiper merged 1 commit intoNVIDIA:mainfrom
pciolkosz:fix_graph_node_ref_in_13_0

Conversation

@pciolkosz
Copy link
Contributor

cudaGraphAddDependencies was changed to take an extra optional argument, we need to call different versions depending on the CTK version

@pciolkosz pciolkosz requested a review from a team as a code owner August 27, 2025 16:33
@pciolkosz pciolkosz requested a review from fbusato August 27, 2025 16:33
@github-project-automation github-project-automation bot moved this to Todo in CCCL Aug 27, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Aug 27, 2025
@pciolkosz pciolkosz requested a review from alliepiper August 27, 2025 16:36
@alliepiper alliepiper enabled auto-merge (squash) August 27, 2025 16:45
@github-actions
Copy link
Contributor

🟩 CI finished in 4h 14m: Pass: 100%/32 | Total: 3h 52m | Avg: 7m 15s | Max: 31m 31s | Hits: 96%/15470
  • 🟩 cudax: Pass: 100%/28 | Total: 3h 28m | Avg: 7m 26s | Max: 31m 31s | Hits: 96%/15470

    🟩 cpu
      🟩 amd64              Pass: 100%/24  | Total:  3h 14m | Avg:  8m 05s | Max: 31m 31s | Hits:  96%/13086 
      🟩 arm64              Pass: 100%/4   | Total: 14m 14s | Avg:  3m 33s | Max:  5m 36s | Hits:  97%/2384  
    🟩 ctk
      🟩 12.0               Pass: 100%/3   | Total: 20m 44s | Avg:  6m 54s | Max: 14m 31s | Hits:  95%/1482  
      🟩 12.9               Pass: 100%/25  | Total:  3h 07m | Avg:  7m 30s | Max: 31m 31s | Hits:  97%/13988 
    🟩 cudacxx
      🟩 nvcc12.0           Pass: 100%/3   | Total: 20m 44s | Avg:  6m 54s | Max: 14m 31s | Hits:  95%/1482  
      🟩 nvcc12.9           Pass: 100%/25  | Total:  3h 07m | Avg:  7m 30s | Max: 31m 31s | Hits:  97%/13988 
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/28  | Total:  3h 28m | Avg:  7m 26s | Max: 31m 31s | Hits:  96%/15470 
    🟩 cxx
      🟩 Clang14            Pass: 100%/2   | Total:  6m 00s | Avg:  3m 00s | Max:  3m 12s | Hits: 100%/1194  
      🟩 Clang15            Pass: 100%/1   | Total:  3m 13s | Avg:  3m 13s | Max:  3m 13s | Hits: 100%/596   
      🟩 Clang16            Pass: 100%/1   | Total:  3m 17s | Avg:  3m 17s | Max:  3m 17s | Hits: 100%/596   
      🟩 Clang17            Pass: 100%/1   | Total:  3m 14s | Avg:  3m 14s | Max:  3m 14s | Hits: 100%/596   
      🟩 Clang18            Pass: 100%/1   | Total:  3m 22s | Avg:  3m 22s | Max:  3m 22s | Hits: 100%/596   
      🟩 Clang19            Pass: 100%/4   | Total: 36m 52s | Avg:  9m 13s | Max: 28m 19s | Hits: 100%/2384  
      🟩 GCC10              Pass: 100%/2   | Total:  7m 02s | Avg:  3m 31s | Max:  3m 37s | Hits:  99%/1194  
      🟩 GCC11              Pass: 100%/1   | Total:  3m 40s | Avg:  3m 40s | Max:  3m 40s | Hits:  99%/596   
      🟩 GCC12              Pass: 100%/1   | Total:  3m 44s | Avg:  3m 44s | Max:  3m 44s | Hits:  99%/596   
      🟩 GCC13              Pass: 100%/8   | Total:  1h 03m | Avg:  7m 54s | Max: 31m 31s | Hits:  98%/4768  
      🟩 MSVC14.39          Pass: 100%/1   | Total: 14m 31s | Avg: 14m 31s | Max: 14m 31s | Hits:  78%/290   
      🟩 MSVC14.43          Pass: 100%/3   | Total: 40m 05s | Avg: 13m 21s | Max: 14m 40s | Hits:  78%/876   
      🟩 NVHPC25.7          Pass: 100%/2   | Total: 20m 00s | Avg: 10m 00s | Max: 10m 05s | Hits:  87%/1188  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/10  | Total: 55m 58s | Avg:  5m 35s | Max: 28m 19s | Hits: 100%/5962  
      🟩 GCC                Pass: 100%/12  | Total:  1h 17m | Avg:  6m 28s | Max: 31m 31s | Hits:  98%/7154  
      🟩 MSVC               Pass: 100%/4   | Total: 54m 36s | Avg: 13m 39s | Max: 14m 40s | Hits:  78%/1166  
      🟩 NVHPC              Pass: 100%/2   | Total: 20m 00s | Avg: 10m 00s | Max: 10m 05s | Hits:  87%/1188  
    🟩 gpu
      🟩 h100               Pass: 100%/2   | Total: 11m 47s | Avg:  5m 53s | Max:  8m 25s | Hits:  99%/1192  
      🟩 rtx2080            Pass: 100%/26  | Total:  3h 16m | Avg:  7m 33s | Max: 31m 31s | Hits:  96%/14278 
    🟩 jobs
      🟩 Build              Pass: 100%/25  | Total:  2h 20m | Avg:  5m 36s | Max: 14m 40s | Hits:  96%/13682 
      🟩 Test               Pass: 100%/3   | Total:  1h 08m | Avg: 22m 45s | Max: 31m 31s | Hits:  99%/1788  
    🟩 sm
      🟩 90                 Pass: 100%/2   | Total: 11m 47s | Avg:  5m 53s | Max:  8m 25s | Hits:  99%/1192  
      🟩 90;90a             Pass: 100%/2   | Total: 16m 30s | Avg:  8m 15s | Max: 13m 03s | Hits:  92%/888   
      🟩 100;120            Pass: 100%/2   | Total: 16m 03s | Avg:  8m 01s | Max: 12m 22s | Hits:  92%/888   
    🟩 std
      🟩 17                 Pass: 100%/3   | Total: 18m 27s | Avg:  6m 09s | Max: 10m 05s | Hits:  92%/1786  
      🟩 20                 Pass: 100%/25  | Total:  3h 09m | Avg:  7m 35s | Max: 31m 31s | Hits:  97%/13684 
    
  • 🟩 packaging: Pass: 100%/4 | Total: 23m 55s | Avg: 5m 58s | Max: 8m 10s

    🟩 cpu
      🟩 amd64              Pass: 100%/4   | Total: 23m 55s | Avg:  5m 58s | Max:  8m 10s
    🟩 ctk
      🟩 12.0               Pass: 100%/2   | Total: 14m 08s | Avg:  7m 04s | Max:  8m 10s
      🟩 12.9               Pass: 100%/2   | Total:  9m 47s | Avg:  4m 53s | Max:  7m 21s
    🟩 cudacxx
      🟩 nvcc12.0           Pass: 100%/2   | Total: 14m 08s | Avg:  7m 04s | Max:  8m 10s
      🟩 nvcc12.9           Pass: 100%/2   | Total:  9m 47s | Avg:  4m 53s | Max:  7m 21s
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/4   | Total: 23m 55s | Avg:  5m 58s | Max:  8m 10s
    🟩 cxx
      🟩 Clang14            Pass: 100%/1   | Total:  8m 10s | Avg:  8m 10s | Max:  8m 10s
      🟩 Clang19            Pass: 100%/1   | Total:  7m 21s | Avg:  7m 21s | Max:  7m 21s
      🟩 GCC12              Pass: 100%/1   | Total:  5m 58s | Avg:  5m 58s | Max:  5m 58s
      🟩 GCC13              Pass: 100%/1   | Total:  2m 26s | Avg:  2m 26s | Max:  2m 26s
    🟩 cxx_family
      🟩 Clang              Pass: 100%/2   | Total: 15m 31s | Avg:  7m 45s | Max:  8m 10s
      🟩 GCC                Pass: 100%/2   | Total:  8m 24s | Avg:  4m 12s | Max:  5m 58s
    🟩 gpu
      🟩 rtx2080            Pass: 100%/4   | Total: 23m 55s | Avg:  5m 58s | Max:  8m 10s
    🟩 jobs
      🟩 Test               Pass: 100%/4   | Total: 23m 55s | Avg:  5m 58s | Max:  8m 10s
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
CCCL Packaging
libcu++
CUB
Thrust
+/- CUDA Experimental
stdpar
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
+/- CCCL Packaging
libcu++
CUB
Thrust
+/- CUDA Experimental
stdpar
python
CCCL C Parallel Library
Catch2Helper

🏃‍ Runner counts (total jobs: 32)

# Runner
17 linux-amd64-cpu16
6 linux-amd64-gpu-rtx2080-latest-1
4 linux-arm64-cpu16
4 windows-amd64-cpu16
1 linux-amd64-gpu-h100-latest-1

@alliepiper alliepiper merged commit 9772e25 into NVIDIA:main Aug 27, 2025
45 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Aug 27, 2025
__graph_,
__deps.data(), // dependencies
__src_arr.get(), // dependant nodes
__nullptr, // no edge data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/__nullptr/nullptr/, we all missed this 😅

I've fixed this in #5431.

davebayer pushed a commit to davebayer/cccl that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants