Add devcontainer readme #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
requested review from
jarmak-nv and
ericniebler
and removed request for
a team
jrhemstad
force-pushed
the
contributor-guide
branch
from
2feb117 to
7e497ba
Compare
jrhemstad
force-pushed
the
contributor-guide
branch
from
d7cf3f1 to
9b39c35
Compare
1 task
ahendriksen
reviewed
Sep 26, 2023
vyasr
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Left some minor comments, but generally LGTM. I would suggest adding a few more links to show people how they could customize devcontainers if they want to add specific features to help their development (e.g. installing their favorite non-VSCode text editor or other productivity tools for navigating files etc inside the container).
bdice
reviewed
Sep 26, 2023
Merged
Co-authored-by: Bradley Dice <[email protected]> Co-authored-by: Vyas Ramasubramani <[email protected]> Co-authored-by: Allard Hendriksen <[email protected]>
jrhemstad
commented
Oct 2, 2023
gevtushenko
approved these changes
Oct 2, 2023
Co-authored-by: Christopher Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a precursor to adding a full-fledged contributor guide, this PR adds documentation about how to use our development containers.
It provides detailed instructions on both using the containers with vscode as well as using the docker images manually.
I updated the
launch.shscript to add a--dockerflag to simplify launching the docker container.Checklist