Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: provide a one shot command to compile & run libcu++s tests for development #477

Open
1 task done
gonzalobg opened this issue Sep 23, 2023 · 5 comments
Open
1 task done
Labels
doc Documentation-related items. feature request New feature or request. infrastructure Shared CMake, github, etc infrastructure

Comments

@gonzalobg
Copy link
Collaborator

Is this a duplicate?

Type of Bug

Something else

Component

libcu++

Describe the bug

Please provide a one shot command to compile & run libcu++ tests for development with the goal of simplifying contributions.

The shell script interface should:

  • accept some way to select a subset of tests (e.g. a directory)
  • accept some options that are relevant for testing (e.g. c++ version, sm_arch, build & serve docs locally)

The shell script should not have any dependencies beyond docker and bash.
That is, the shell script should:

  • build a container that contains everything required
  • compile and run tests within the container

How to Reproduce

.

Expected behavior

.

Reproduction link

No response

Operating System

No response

nvidia-smi output

No response

NVCC version

No response

@gonzalobg gonzalobg added the bug Something isn't working right. label Sep 23, 2023
@github-project-automation github-project-automation bot moved this to Todo in CCCL Sep 23, 2023
@miscco
Copy link
Collaborator

miscco commented Sep 25, 2023

I believe this is already done.

The script in question is: ci/test_libcudacxx.sh It takes three arguments. host_compiler, standard_version and cuda_architectures

This script works fine outside of our devcontainers given that the ctk is in path.

For the second point, there are already the devcontainers that provide a fully configured development environment.

Using VS-code starting those is just a single click

@miscco miscco added feature request New feature or request. doc Documentation-related items. infrastructure Shared CMake, github, etc infrastructure and removed bug Something isn't working right. labels Sep 25, 2023
@miscco
Copy link
Collaborator

miscco commented Sep 25, 2023

I have changed the labels to documentation improvements.

@gonzalobg
Copy link
Collaborator Author

Would it be possible to provide a similar script that runs the whole thing inside the dev container directly ?

@jrhemstad
Copy link
Collaborator

Yes, this exists and I've been working on a contributor/devcontainer guide documentation. I'll have a PR up this week for both.

@jrhemstad
Copy link
Collaborator

Here's the first part of the docs on setting up the environment in a container: #481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation-related items. feature request New feature or request. infrastructure Shared CMake, github, etc infrastructure
Projects
Status: Todo
Development

No branches or pull requests

3 participants