-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code #368
Conversation
Pull requests from external contributors require approval from a |
/ok to test |
As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only compiled for C++03. The macro and all encapsulated code are removed.
50b656a
to
34e2821
Compare
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, I only found two minor issues in this huge diff
libcudacxx/include/cuda/std/detail/libcxx/include/__functional/function.h
Show resolved
Hide resolved
This patch relates to NVIDIA#127.
f6f7724
to
736736b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMake changes LGTM
/ok to test |
…#368) * Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only compiled for C++03. The macro and all encapsulated code are removed. * Remove `__functional_03` and `__functional_base_03` This patch relates to NVIDIA#127. --------- Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
…#368) * Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only compiled for C++03. The macro and all encapsulated code are removed. * Remove `__functional_03` and `__functional_base_03` This patch relates to NVIDIA#127. --------- Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
…#368) * Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only compiled for C++03. The macro and all encapsulated code are removed. * Remove `__functional_03` and `__functional_base_03` This patch relates to NVIDIA#127. --------- Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
…#368) * Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only compiled for C++03. The macro and all encapsulated code are removed. * Remove `__functional_03` and `__functional_base_03` This patch relates to NVIDIA#127. --------- Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
…#368) * Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only compiled for C++03. The macro and all encapsulated code are removed. * Remove `__functional_03` and `__functional_base_03` This patch relates to NVIDIA#127. --------- Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
…#368) * Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code As part of NVIDIA#127, code for unsupported compilation modes/platforms will be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only compiled for C++03. The macro and all encapsulated code are removed. * Remove `__functional_03` and `__functional_base_03` This patch relates to NVIDIA#127. --------- Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
As part of #127, code for unsupported compilation modes/platforms will be removed.
_LICUDACXX_CXX03_LANG
macro guards code only compiled for C++03. The macro and all encapsulated code are removed.Checklist