[TRTLLM-9811][infra] Update urllib3 version >= 2.6.0 to fix high vulnerability issue

[ZhanruiSunCh]

Summary by CodeRabbit

• Chores
  • Updated Python dependency constraints to enforce stricter version requirements.
  • Optimized Docker build process to apply dependency constraints during early installation stages, ensuring consistent environment setup.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[ZhanruiSunCh]

/bot run --stage-list "Build-Docker-Images"

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes consolidate Python dependency constraints into a dedicated constraints.txt file and update the Docker build process to apply these constraints early, including upgrading urllib3 to version 2.6.0 or higher while removing the legacy urllib3<2.0 constraint from installation scripts.

Changes

Cohort / File(s)	Summary
Dependency Constraint Definition constraints.txt	Added two GHSA advisory comments and introduced a new constraint: urllib3>=2.6.0
Docker Build Process Updates docker/Dockerfile.multi, docker/common/install_base.sh	Modified Dockerfile to copy constraints.txt and install dependencies from it early in the devel build stage; removed urllib3<2.0 constraint from install_base.sh pip3 install command

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Straightforward dependency management changes with no complex logic or structural modifications
• Coordinated updates across multiple files that follow a consistent pattern (centralizing and upgrading urllib3 constraints)
• Key areas to verify:
  • urllib3>=2.6.0 compatibility with existing codebase and dependencies
  • GHSA advisory details in constraints.txt comments
  • Correct placement and execution order of constraint installation in Dockerfile build stages

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is largely incomplete—it only includes the template with empty Description and Test Coverage sections, and lacks substantive explanation of the issue, solution, and test coverage.	Fill in the Description section with explanation of the vulnerability and why >=2.6.0 fixes it, and the Test Coverage section with relevant test safeguards for the dependency changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title clearly and specifically identifies the main change: updating urllib3 to version >=2.6.0 to fix a high vulnerability, with proper ticket and type formatting.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

docker/Dockerfile.multi (1)

74-76: Review the --upgrade flag in pip install command.

The --upgrade flag on Line 76 will upgrade all packages to their latest compatible versions, potentially pulling in unintended package updates beyond the constraints file. This could introduce security risks or breaking changes unrelated to the urllib3 fix.

Consider whether this flag is necessary, or if a constraints-only install (without --upgrade) would suffice to resolve the urllib3 vulnerability.

If only constraining urllib3 is the intent, consider removing --upgrade:

-RUN pip install --no-cache-dir --upgrade -r /tmp/constraints.txt && rm /tmp/constraints.txt
+RUN pip install --no-cache-dir -r /tmp/constraints.txt && rm /tmp/constraints.txt

Verify this change does not break the dependency resolution for urllib3 and other packages installed by install_base.sh.

docker/common/install_base.sh (1)

121-123: Remove unnecessary bash -c wrapper.

Line 122 wraps the pip3 install command in bash -c, which is unnecessary since the script is already executing in bash. This adds unnecessary nesting.

-  bash -c "pip3 install pytest"
+  pip3 install pytest

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b050804 and 3214a03.

📒 Files selected for processing (3)

• constraints.txt (1 hunks)
• docker/Dockerfile.multi (1 hunks)
• docker/common/install_base.sh (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-08-20T15:04:42.885Z

Learnt from: dbari
Repo: NVIDIA/TensorRT-LLM PR: 7095
File: docker/Dockerfile.multi:168-168
Timestamp: 2025-08-20T15:04:42.885Z
Learning: In docker/Dockerfile.multi, wildcard COPY for benchmarks (${CPP_BUILD_DIR}/benchmarks/*Benchmark) is intentionally used instead of directory copy because the benchmarks directory contains various other build artifacts during C++ builds, and only specific benchmark executables should be copied to the final image.

Applied to files:

• docker/Dockerfile.multi

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

🔇 Additional comments (3)

docker/common/install_base.sh (1)

121-123: Verify pytest's transitive dependencies against urllib3>=2.6.0 constraint.

The install_pyp_rockylinux() function installs only pytest, while urllib3>=2.6.0 is enforced via constraints.txt later in the Dockerfile. Confirm that pytest and its transitive dependencies are compatible with urllib3>=2.6.0 and that pip's constraint resolution handles this ordering correctly.

constraints.txt (1)

3-5: urllib3>=2.6.0 correctly resolves both referenced advisories.

Both GHSA-gm62-xv2j-4w53 (CVE-2025-66418, unbounded decompression-chain DoS) and GHSA-2xpw-w6gg-jr37 (CVE-2025-66471, streaming API resource exhaustion) are high-severity vulnerabilities affecting urllib3 versions before 2.6.0. The constraint urllib3>=2.6.0 appropriately addresses both issues. No critical vulnerabilities were introduced in 2.6.0.

docker/Dockerfile.multi (1)

74-76: Ensure constraints.txt exists in the Docker build context.

The COPY command references constraints.txt from the repository root. Verify this file exists and is properly included in the build context before building the Docker image.

[tensorrt-cicd]

PR_Github #27430 [ run ] triggered by Bot. Commit: 3214a03

[ZhanruiSunCh]

/bot kill

[tensorrt-cicd]

PR_Github #27430 [ run ] completed with state ABORTED. Commit: 3214a03
LLM/main/L0_MergeRequest_PR #20959 (Blue Ocean) completed with status: ABORTED

[tensorrt-cicd]

PR_Github #27447 [ kill ] triggered by Bot. Commit: 3214a03

[tensorrt-cicd]

PR_Github #27447 [ kill ] completed with state SUCCESS. Commit: 3214a03
Successfully killed previous jobs for commit 3214a03

[ZhanruiSunCh]

/bot run --stage-list "Build-Docker-Images"

[tensorrt-cicd]

PR_Github #27451 [ run ] triggered by Bot. Commit: 1bed33d

[tensorrt-cicd]

PR_Github #27451 [ run ] completed with state DISABLED
L0 testing is limited to prioritized users. User ZhanruiSunCh is not in the prioritized list. L0 testing cannot be triggered.

[tensorrt-cicd]

PR_Github #27463 [ run ] triggered by Bot. Commit: 1bed33d

[tensorrt-cicd]

PR_Github #27463 [ run ] completed with state FAILURE. Commit: 1bed33d
/LLM/main/L0_MergeRequest_PR pipeline #20974 (Partly Tested) completed with status: 'FAILURE'

[ZhanruiSunCh]

/bot run

[tensorrt-cicd]

PR_Github #27514 [ run ] triggered by Bot. Commit: 3530651

[tensorrt-cicd]

PR_Github #27514 [ run ] completed with state FAILURE. Commit: 3530651
LLM/main/L0_MergeRequest_PR #20993 (Blue Ocean) completed with status: ABORTED

[ZhanruiSunCh]

/bot run

[tensorrt-cicd]

PR_Github #27598 [ run ] triggered by Bot. Commit: 3530651

[tensorrt-cicd]

PR_Github #27598 [ run ] completed with state SUCCESS. Commit: 3530651
/LLM/main/L0_MergeRequest_PR pipeline #21066 completed with status: 'SUCCESS'

[ZhanruiSunCh]

/bot reuse-pipeline

[ZhanruiSunCh]

/bot reuse-pipeline

[ZhanruiSunCh]

/bot reuse-pipeline

[tensorrt-cicd]

PR_Github #27664 [ reuse-pipeline ] triggered by Bot. Commit: d893c38

[tensorrt-cicd]

PR_Github #27664 [ reuse-pipeline ] completed with state SUCCESS. Commit: d893c38
Reusing PR_Github #27598 for commit d893c38