Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Nov 23, 2025

Remove closed bugs from waives.txt

Summary by CodeRabbit

Release Notes

  • Tests
    • Restored multiple previously skipped integration tests to expand overall test coverage and validation. Re-enabled tests now include multimodal inference scenarios, throughput and latency benchmarking across various model configurations, single-GPU disaggregated deployment patterns, and quickstart verification tests, ensuring more comprehensive platform testing and robust validation coverage.

✏️ Tip: You can customize this high-level summary in your review settings.

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20251123 branch from 9a35e85 to 43fb8be Compare November 24, 2025 03:49
@xinhe-nv xinhe-nv marked this pull request as ready for review November 24, 2025 03:49
@xinhe-nv xinhe-nv enabled auto-merge (squash) November 24, 2025 03:49
@xinhe-nv
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 24, 2025

📝 Walkthrough

Walkthrough

This PR removes SKIP entries from the test waiver list, unskipping previously disabled tests including DeepSeekR1 throughput/latency tests, multimodal test variants, and disaggregated GPU tests. No new SKIP entries are added, and the test selection logic remains unchanged.

Changes

Cohort / File(s) Summary
Test waiver list updates
tests/integration/test_lists/waives.txt
Removed SKIP entries for DeepSeekR1 blockscale tests, multimodal test variants (test_ptp_quickstart_multimodal_multiturn, test_auto_dtype with Llava/Mistral), and disaggregated single-GPU tests, restoring these tests to active status.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file modified with repetitive, homogeneous changes (removal of SKIP lines)
  • No logic or functional changes; purely configuration-level test re-enablement
  • Straightforward verification of which tests are being unskipped

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is minimal but directly relevant. However, it lacks the structured sections required by the template (Description, Test Coverage, PR Checklist). Expand the description to follow the template structure: add details about which bugs were closed, explain why they're being removed, and confirm test coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing closed bugs from the waives.txt file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c045e35 and 43fb8be.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25487 [ run ] triggered by Bot. Commit: 43fb8be

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25487 [ run ] completed with state SUCCESS. Commit: 43fb8be
/LLM/main/L0_MergeRequest_PR pipeline #19298 completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20251123 branch from 43fb8be to 9a6c85d Compare November 24, 2025 05:38
@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25497 [ run ] triggered by Bot. Commit: 9a6c85d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25497 [ run ] completed with state SUCCESS. Commit: 9a6c85d
/LLM/main/L0_MergeRequest_PR pipeline #19307 completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20251123 branch 2 times, most recently from 326ecf7 to 42c5c61 Compare November 24, 2025 09:42
@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25540 [ run ] triggered by Bot. Commit: 42c5c61

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25540 [ run ] completed with state SUCCESS. Commit: 42c5c61
/LLM/main/L0_MergeRequest_PR pipeline #19339 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20251123 branch from ed1dc86 to c040a6d Compare November 25, 2025 02:10
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25628 [ reuse-pipeline ] triggered by Bot. Commit: c040a6d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25628 [ reuse-pipeline ] completed with state SUCCESS. Commit: c040a6d
Reusing PR_Github #25540 for commit c040a6d

@xinhe-nv xinhe-nv merged commit 0a9ae2e into NVIDIA:main Nov 25, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/unwaive_20251123 branch November 25, 2025 03:00
codego7250 pushed a commit to codego7250/TensorRT-LLM that referenced this pull request Dec 11, 2025
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants