Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Sep 14, 2025

Remove closed bugs from waives.txt

Summary by CodeRabbit

  • Tests
    • Re-enabled multiple previously skipped integration and accuracy tests after blockers were resolved, improving coverage across multimodal workflows, audio models, dtype auto-selection, and large-scale configurations. This enhances reliability and regression detection.
  • Chores
    • No changes to product behavior or public interfaces; only test-skip configurations were updated.

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250914 branch from 57224f7 to 79c266d Compare September 15, 2025 05:33
@xinhe-nv xinhe-nv marked this pull request as ready for review September 15, 2025 05:33
@xinhe-nv xinhe-nv enabled auto-merge (squash) September 15, 2025 05:33
@xinhe-nv
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 15, 2025

📝 Walkthrough

Walkthrough

Removed multiple SKIP waivers from tests/integration/test_lists/waives.txt, un-skipping several integration and accuracy tests previously tied to nvbugs references. No source code or API changes.

Changes

Cohort / File(s) Summary of Changes
Test waivers update
tests/integration/test_lists/waives.txt
Deleted multiple SKIP entries (nvbugs references) for various accuracy, examples, and e2e tests, re-enabling those tests. No logic or API modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is a one-line note ("Remove closed bugs from waives.txt") and does not follow the repository's required template; it omits the structured "Description", "Test Coverage", and "PR Checklist" sections and lacks specifics about which waivers/tests were removed and the testing/CI impact. Because the required template sections are missing, the description is incomplete. Please update the PR description to use the repository template: add a detailed Description explaining which waivers were removed and why, list Test Coverage with the relevant tests and expected CI results, and complete the PR Checklist (coding guidelines, ownership, documentation). After adding these details, notify reviewers or re-run checks so the description can be re-evaluated.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[None][chore] Remove closed bugs" is concise, follows the repository's title template, and accurately summarizes the primary change (removing closed bug waivers from waives.txt) without extraneous details, so it is clear to a teammate scanning history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2c45d8 and 79c266d.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18572 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18572 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13944 completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250914 branch 2 times, most recently from 6058f52 to e5c0bcf Compare September 16, 2025 09:14
@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18771 [ run ] triggered by Bot

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250914 branch from e5c0bcf to 2b1cb04 Compare September 16, 2025 10:17
@tensorrt-cicd
Copy link
Collaborator

PR_Github #18771 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #14072 completed with status: 'FAILURE'

@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18781 [ run ] triggered by Bot

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250914 branch 2 times, most recently from 92895f0 to 35cccbd Compare September 16, 2025 11:34
@tensorrt-cicd
Copy link
Collaborator

PR_Github #18781 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #14079 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250914 branch from 35cccbd to 7a54fb8 Compare September 17, 2025 01:29
@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250914 branch 2 times, most recently from 8f072d9 to 6490904 Compare September 17, 2025 03:25
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18880 [ reuse-pipeline ] triggered by Bot

Signed-off-by: xinhe-nv <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250914 branch from 6490904 to 26f385a Compare September 17, 2025 03:41
@tensorrt-cicd
Copy link
Collaborator

PR_Github #18880 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #18781 (Partly Tested) for commit 6490904

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18918 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18918 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #18781 (Partly Tested) for commit 8531c09

@xinhe-nv xinhe-nv merged commit 7801d09 into NVIDIA:main Sep 17, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/unwaive_20250914 branch September 17, 2025 07:30
Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025
MrGeva pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants