Skip to content

Conversation

@Superjomn
Copy link
Collaborator

@Superjomn Superjomn commented Oct 5, 2025

Summary by CodeRabbit

  • New Features
    • Added support for selecting an “rpc” orchestration backend in addition to “ray” in LLM configuration, allowing users to choose between RPC and Ray.
  • Tests
    • Updated API stability references and tests to reflect the new “rpc” option for the orchestration backend.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 5, 2025

📝 Walkthrough

Walkthrough

Broadened allowed values for orchestrator_type to include "rpc" alongside "ray" in base arguments. Removed Torch-specific orchestrator_type field. Updated API stability reference YAML to reflect the new Optional[Literal["rpc", "ray"]] signature.

Changes

Cohort / File(s) Summary
LLM args API
tensorrt_llm/llmapi/llm_args.py
Expanded BaseLlmArgs.orchestrator_type from Optional[Literal["rpc"]] to Optional[Literal["rpc", "ray"]]; removed TorchLlmArgs-specific orchestrator_type definition to rely on base class.
API stability references/tests
tests/unittest/api_stability/references/llm.yaml
Updated orchestrator_type type from Optional[Literal["ray"]] to Optional[Literal["rpc", "ray"]] across constructor/signature reference.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The provided PR description consists solely of the unmodified template with placeholder comments and lacks any actual title, summary of the changes, or test coverage details. Because none of the required sections are populated with concrete content, it fails to adhere to the repository’s description template. This omission prevents reviewers from understanding the scope, rationale, and validation of the proposed changes. Please replace the placeholder template with actual content by providing a correctly formatted title, a concise description of the implemented changes and their rationale, and clear test coverage information. Populate any additional sections such as documentation updates, checklist confirmations, and relevant code owner assignments as required by the template. This will align the PR description with repository standards and enable an effective review process.
Title Check ❓ Inconclusive The provided title follows the project’s PR naming template but is too vague to convey the actual change since it merely notes a “conflict” in llmargs without indicating that the orchestrator_type has been broadened to include both rpc and ray. Consider revising the title to explicitly summarize the primary change, for example “[None][chore] Expand orchestrator_type in BaseLlmArgs to support rpc and ray,” so that readers immediately understand the purpose of the update.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Superjomn
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20649 [ run ] triggered by Bot

@Superjomn Superjomn requested a review from lucaslie October 5, 2025 14:23
@Superjomn Superjomn added the bug Something isn't working label Oct 5, 2025
@Superjomn Superjomn enabled auto-merge (squash) October 5, 2025 14:56
@Superjomn
Copy link
Collaborator Author

/bot run

@Superjomn
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20652 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20649 [ run ] completed with state ABORTED
/LLM/main/L0_MergeRequest_PR pipeline #15595 completed with status: 'FAILURE'

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20653 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20652 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15596 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20653 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15597 completed with status: 'FAILURE'

Signed-off-by: Yan Chunwei <[email protected]>
Signed-off-by: Yan Chunwei <[email protected]>
Signed-off-by: Yan Chunwei <[email protected]>
@Superjomn
Copy link
Collaborator Author

/bot run

@Superjomn
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20657 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20658 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20657 [ run ] completed with state ABORTED

@joyang-nv
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20662 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20658 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15602 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20662 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15605 completed with status: 'FAILURE'

@joyang-nv
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20664 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20664 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15607 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@Superjomn Superjomn merged commit 54ab976 into NVIDIA:main Oct 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants