[TRTLLM-8414][chore] BREAKING CHANGE: refine sampling strategy selection

[ixlmar]

Description

NOTE: These changes specify the sampling behavior in some previously undefined cases. While the new behavior should be in line with the examples in the documentation, it does differ from the base-branch behavior in certain cases.

Roughly, the new semantics are (see TRTLLM-8414 for complete background):

• If top_k = top_p = temperature = None (the default if the respective parameters are not specified), sampling is greedy (torch.argmax).
• If a non-trivial top_k, top_p, and/or temperature is provided, sampling proceeds accordingly. In this case, unspecified parameters default to top_k = 0, top_p = 1, temperature = 1.0.
• If either temperature = 0, top_p = 0, and/or top_k = 1, is specified, sampling is greedy, irrespective of the values of the remaining parameters.

Test Coverage

Unit tests for the sampling strategy selection are implemented as part of this PR.

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

• New Features
  • Unified sampling strategies with support for top-k, top-p (nucleus), temperature, and their combinations, with clearer greedy behavior when parameters imply determinism.
• Bug Fixes
  • Improved handling of edge cases and defaults in sampling (e.g., validation of temperature/top-p/top-k ranges and greedy fallbacks).
• Tests
  • Added comprehensive unit tests covering strategy selection, parameter validation, and draft-probability decisions.
  • Enabled selection of a specific sampler type in tests.
  • Suppressed noisy traces for skipped tests.
• Chores
  • Adjusted tooling configuration to exclude a specific test file from formatting and spell-checking.

[ixlmar]

/bot run

[tensorrt-cicd]

PR_Github #20583 [ run ] triggered by Bot

[ixlmar]

/bot run

[tensorrt-cicd]

PR_Github #20583 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15537 completed with status: 'FAILURE'

[tensorrt-cicd]

PR_Github #20589 [ run ] triggered by Bot

[ixlmar]

/bot run

[tensorrt-cicd]

PR_Github #20589 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #15542 completed with status: 'FAILURE'

[tensorrt-cicd]

PR_Github #20592 [ run ] triggered by Bot

[ixlmar]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #20601 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20592 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15545 (Blue Ocean) completed with status: ABORTED

[tensorrt-cicd]

PR_Github #20601 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15552 completed with status: 'FAILURE'

[ixlmar]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #20665 [ run ] triggered by Bot

[ixlmar]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #20666 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20665 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15608 (Blue Ocean) completed with status: ABORTED

[ixlmar]

Release checks to be fixed by #8152

[ixlmar]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #20668 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20666 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15609 (Blue Ocean) completed with status: ABORTED

[tensorrt-cicd]

PR_Github #20673 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15616 completed with status: 'FAILURE'

[ixlmar]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #20716 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20716 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15652 completed with status: 'FAILURE'

[ixlmar]

/bot run

[tensorrt-cicd]

PR_Github #20727 [ run ] triggered by Bot

[ixlmar]

/bot run --add-multi-gpu-test

[tensorrt-cicd]

PR_Github #20727 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15662 completed with status: 'SUCCESS'

[tensorrt-cicd]

PR_Github #20730 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20730 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15664 completed with status: 'FAILURE'

[ixlmar]

/bot run --add-multi-gpu-test

[tensorrt-cicd]

PR_Github #20789 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20789 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15717 completed with status: 'SUCCESS'

[lucaslie]

lgtm