[https://nvbugs/5457504][fix] fix kv cache event test in disaggregated worker tests #7028
Conversation
📝 WalkthroughWalkthroughTightened end-of-round assertions in KvCacheEventWorkerTester to require a positive generation match count and allow eviction to satisfy ordering; added a one-round flush call after concurrent rounds. Removed a SKIP waiver so the disaggregated KV cache events test will run. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant T as Test harness
participant R as KvCacheEventWorkerTester
participant W as Worker
participant C as KV Cache
rect rgb(230,240,255)
note over T,R: Concurrent per-prompt rounds
T->>R: multi_round_request(prompts, max_rounds=N, check_match_count=True)
loop per prompt/round
R->>W: send request
W->>C: read/update KV
C-->>W: events (matches / evictions)
W-->>R: generation + events
alt end-of-round assertion (updated)
note right of R: require gen_match_count > 0\nand (gen_match_count ≥ ctx_match_count or gen_evicted)
end
end
end
rect rgb(235,255,235)
note over T,R: Flush events after concurrent rounds
T->>R: multi_round_request([first_prompt], max_rounds=1, check_match_count=False)
R->>W: single request to flush events
W-->>R: generation + events
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
tests/integration/defs/disaggregated/test_workers.py (2)
299-303: End-of-round gen-match relaxation is sensible; consider symmetric eviction-aware checksThe new logic correctly accounts for generation-side evictions while still enforcing positive reuse. To avoid false negatives when a full eviction leaves zero reusable tokens, consider gating the “> 0” checks behind eviction for both ctx and gen, and keep the comparison relaxed under eviction. This keeps the assertions symmetrical and resilient.
If zero match after eviction should still fail by design, ignore the first two lines of the suggestion below.
- if check_match_count: - assert ctx_match_count > 0 - assert gen_match_count > 0 - assert gen_match_count >= ctx_match_count or gen_evicted + if check_match_count: + # Allow zero matches if an eviction happened; otherwise require > 0. + assert ctx_evicted or ctx_match_count > 0 + assert gen_evicted or gen_match_count > 0 + # Gen should have at least as many matches as ctx unless evicted. + assert gen_evicted or gen_match_count >= ctx_match_count
314-316: “Flush via dummy request” works; prefer a side-effect-free, explicit event drainSending an extra request to flush events is effective but adds latency and mutates KV state. A lighter approach is to explicitly drain events from both ctx/gen servers and update local state without generating tokens.
Apply this diff here:
- # send a request to flush events - await self.multi_round_request(session, init_prompts[0], 1, False) + # drain pending KV events without issuing a new generation + await self.flush_events(session)And add this helper inside KvCacheEventWorkerTester (outside the shown range):
async def flush_events(self, session: aiohttp.ClientSession) -> None: # Explicitly drain KV events and update local state for all servers. for url in set(self.ctx_servers + self.gen_servers): events = await self.query_kv_cache_events(session, url) async with self.kv_cache_block_maps[url]._lock: self.kv_cache_block_maps[url].update_with_events(events) self.kv_cache_event_maps[url].extend(events)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
tests/integration/defs/disaggregated/test_workers.py(2 hunks)tests/integration/test_lists/waives.txt(0 hunks)
💤 Files with no reviewable changes (1)
- tests/integration/test_lists/waives.txt
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+
Python indentation: 4 spaces, no tabs
Maintain module namespace in imports (from package.subpackage import foo; then use foo.SomeClass())
Python file names use snake_case
Python class names use PascalCase
Python functions/methods and local variables use snake_case; variables starting with a number get k_ prefix (e.g., k_99th_percentile)
Global variables use G_ prefixed UPPER_SNAKE_CASE (e.g., G_MY_GLOBAL)
Constants use UPPER_SNAKE_CASE in Python
Avoid shadowing variables from outer scopes in Python
Initialize all externally visible members of a Python class in init
Prefer docstrings for interfaces used outside a file; comments for local code
Use Google-style docstrings for classes and functions (Sphinx-parsable)
Document attributes/variables inline with short docstrings
Avoid reflection when simple alternatives exist (e.g., prefer explicit parameters over dict(**locals()))
In try/except, catch the narrowest exceptions possible
For duck-typing with try/except, keep try body minimal and put logic in else
Files:
tests/integration/defs/disaggregated/test_workers.py
**/*.{cpp,cxx,cc,cu,h,hpp,hxx,hh,cuh,py}
📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)
Prepend NVIDIA copyright header (current year) to all source files
Files:
tests/integration/defs/disaggregated/test_workers.py
|
/bot run |
|
/bot run |
|
PR_Github #15754 [ run ] triggered by Bot |
|
PR_Github #15754 [ run ] completed with state |
|
/bot run --stage-list "H100_PCIe-PyTorch-2" |
|
PR_Github #15845 [ run ] triggered by Bot |
|
PR_Github #15845 [ run ] completed with state |
|
/bot run --stage-list "H100_PCIe-PyTorch-2" |
|
PR_Github #15966 [ run ] triggered by Bot |
|
PR_Github #15966 [ run ] completed with state |
|
/bot run |
|
PR_Github #16011 [ run ] triggered by Bot |
|
PR_Github #16011 [ run ] completed with state |
|
/bot run --stage-list "H100_PCIe-PyTorch-1,H100_PCIe-PyTorch-2,H100_PCIe-PyTorch-3" |
|
PR_Github #16092 [ run ] triggered by Bot |
|
PR_Github #16092 [ run ] completed with state |
Signed-off-by: zhengd-nv <[email protected]>
zhengd-nv
force-pushed
the
fix-cache-event-test
branch
from
ec974c9 to
3655eb9
Compare
|
/bot run --stage-list "H100_PCIe-PyTorch-1,H100_PCIe-PyTorch-2,H100_PCIe-PyTorch-3" |
|
PR_Github #16167 [ run ] triggered by Bot |
|
PR_Github #16167 [ run ] completed with state |
|
/bot run |
|
PR_Github #16338 [ run ] triggered by Bot |
|
PR_Github #16338 [ run ] completed with state |
|
/bot run --stage-list "H100_PCIe-PyTorch-1,H100_PCIe-PyTorch-2,H100_PCIe-PyTorch-3" |
|
PR_Github #16376 [ run ] triggered by Bot |
|
PR_Github #16376 [ run ] completed with state |
|
/bot run |
|
PR_Github #16420 [ run ] triggered by Bot |
|
PR_Github #16420 [ run ] completed with state |
4 participants
Summary by CodeRabbit
Description
Add a dummy request to make the KV cache events up to date. Possibly because of the issue mentioned in #6346.
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.