[None][infra] Waive failed cases on main 08/14 #6902
Conversation
Signed-off-by: qqiao <[email protected]>
📝 WalkthroughWalkthroughUpdated tests/integration/test_lists/waives.txt to add multiple new SKIP entries across various tests and to update one existing nvbugs ID reference for a DeepSeekR1 test. No source code or public API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 💡 Knowledge Base configuration:
You can enable these settings in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/bot run |
EmmaQiaoCh
requested review from
Superjomn,
ZhanruiSunCh,
chzblych,
niukuo and
yiqingy0
|
PR_Github #15301 [ run ] triggered by Bot |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
tests/integration/test_lists/waives.txt (1)
312-325: Duplicate waives found; validation of new entries failed — action requiredThe provided script output shows duplicate nodeids in tests/integration/test_lists/waives.txt and the validation step for lines 312–325 failed due to environment errors (nl: command not found; /dev/fd/63: No such file). Remove/resolve duplicates and confirm the new waives reference real tests before merging.
Duplicates detected:
- accuracy/test_disaggregated_serving.py::TestLlama3_1_8BInstruct::test_ctx_pp_gen_tp_asymmetric[MMLU-gen_tp=1-ctx_pp=4]
- accuracy/test_disaggregated_serving.py::TestLlama3_1_8BInstruct::test_ctx_pp_gen_tp_asymmetric[MMLU-gen_tp=2-ctx_pp=4]
- accuracy/test_llm_api_pytorch.py::TestDeepSeekR1::test_nvfp4_multi_gpus[throughput_tp8]
- test_e2e.py::test_ptp_quickstart_multimodal[NVILA-8B-FP16-vila/NVILA-8B-image-False]
- test_e2e.py::test_ptp_quickstart_multimodal[llava-v1.6-mistral-7b-llava-v1.6-mistral-7b-hf-image-False]
Quick re-check you can run locally (avoids nl/process-substitution issues):
#!/bin/bash set -euo pipefail waives="tests/integration/test_lists/waives.txt" start=312 end=325 echo "== Duplicates across entire waives list ==" awk -F' SKIP' '{print $1}' "$waives" | sed '/^\s*$/d' | sort | uniq -d || true echo echo "== Validate newly added entries (lines $start-$end) ==" tmp=$(mktemp) trap 'rm -f "$tmp" "${tmp}.nodes"' EXIT sed -n "${start},${end}p" "$waives" > "$tmp" awk -F' SKIP' '{print $1}' "$tmp" | sed '/^\s*$/d' > "${tmp}.nodes" missing=0 while IFS= read -r node; do file="${node%%::*}" rest="${node#*::}" if [[ ! -f "$file" ]]; then echo "[MISSING FILE] $file for node: $node" missing=1; continue fi if [[ "$rest" == *"::"* ]]; then cls="${rest%%::*}" meth="${rest#*::}"; meth="${meth%%[*]*}" if ! grep -n -E "^class[[:space:]]+$cls" "$file" >/dev/null; then echo "[MISSING CLASS] $cls in $file for node: $node"; missing=1 fi if ! grep -n -E "^def[[:space:]]+$meth[[:space:]]*\\(" "$file" >/dev/null; then echo "[MISSING METHOD] $meth in $file for node: $node"; missing=1 fi else func="${rest%%[*]*}" if ! grep -n -E "^def[[:space:]]+$func[[:space:]]*\\(" "$file" >/dev/null; then echo "[MISSING FUNCTION] $func in $file for node: $node"; missing=1 fi fi done < "${tmp}.nodes" if [[ $missing -eq 0 ]]; then echo "All newly added waives reference existing tests." else echo "Some newly added waives reference missing files/symbols. See logs above." exit 1 fiAction items:
- Remove or dedupe the duplicate entries listed above.
- Run the script (or the improved one above) to validate lines 312–325 and fix any missing file/class/function references.
- Re-run CI after fixes.
🧹 Nitpick comments (2)
tests/integration/test_lists/waives.txt (2)
290-291: Align DeepSeekR1 bug IDs across related tests (possible mismatch).You updated the latency variant to nvbugs 5455140 (Line 290), while the adjacent latency_trtllmgen variant still points to 5445466 (Line 291). If both failures share the same root cause, align them to a single bug ID.
Proposed edit if they share the same root cause:
-accuracy/test_llm_api_pytorch.py::TestDeepSeekR1::test_nvfp4_multi_gpus[latency_trtllmgen] SKIP (https://nvbugs/5445466) +accuracy/test_llm_api_pytorch.py::TestDeepSeekR1::test_nvfp4_multi_gpus[latency_trtllmgen] SKIP (https://nvbugs/5455140)
312-323: Consider normalizing nvbugs link format.New entries mix hosts like https://nvbugs/... and https://nvbugspro.nvidia.com/bug/.... For consistency and easier tooling, standardize to one canonical format if your tooling supports it.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these settings in your CodeRabbit configuration.
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
tests/integration/test_lists/waives.txt
🔇 Additional comments (2)
tests/integration/test_lists/waives.txt (2)
314-316: Confirm if the non-compiled TRTLlm latency variant also needs a waive.You added waives for:
- latency_moe_cutlass with torch_compile True/False
- latency_moe_trtllm with torch_compile=True
If both compile modes are failing for TRTLlm, you may also need the torch_compile=False variant. If only the compiled path is failing, this is fine as-is.
323-323: Very long parameterized nodeid — double-check it matches the collected test exactly.The BLS speculative decoding nodeid is highly parameterized. Small mismatches in parameter ordering/strings can prevent the waive from matching. The verification script above will help catch mismatches.
|
/bot skip --comment "Skip due to previous passed test list check" |
|
PR_Github #15307 [ skip ] triggered by Bot |
|
PR_Github #15301 [ run ] completed with state |
|
PR_Github #15307 [ skip ] completed with state |
Signed-off-by: Yanchao Lu <[email protected]>
chzblych
changed the title
Signed-off-by: qqiao <[email protected]> Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Yanchao Lu <[email protected]>
Signed-off-by: qqiao <[email protected]> Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Yanchao Lu <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: qqiao <[email protected]> Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Yanchao Lu <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: qqiao <[email protected]> Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Yanchao Lu <[email protected]>
Signed-off-by: qqiao <[email protected]> Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Yanchao Lu <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: qqiao <[email protected]> Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Yanchao Lu <[email protected]>
Signed-off-by: qqiao <[email protected]> Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Yanchao Lu <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
3 participants
Summary by CodeRabbit
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.