fix: Update trtllm args issues with extra nested config (#5996)

[Wanli-Jiang]

Summary by CodeRabbit

• New Features
  • Improved configuration handling to automatically apply default values for missing fields when updating or creating build configurations.
• Bug Fixes
  • Enhanced deserialization logic to ensure nested configuration fields are correctly reconstructed from dictionaries.
• Tests
  • Added tests to verify accurate updating and reconstruction of nested configuration dictionaries.

[coderabbitai]

Walkthrough

The changes introduce improved handling of default values for nested configuration fields in the BuildConfig dataclass, ensuring missing keys fall back to class defaults. Deserialization logic for build_config in LLM argument updates now uses from_dict. A new test validates correct nested dictionary reconstruction and equality after updates.

Changes

File(s)	Change Summary
tensorrt_llm/builder.py	Added get_build_config_defaults to BuildConfig; updated from_dict to use cached defaults for missing keys and refined nested config handling.
tensorrt_llm/llmapi/llm_args.py	Modified update_llm_args_with_extra_dict to use from_dict for "build_config" and "speculative_config" fields.
tests/unittest/llmapi/test_llm_args.py	Added test test_update_llm_args_with_extra_dict_with_nested_dict to verify nested config update and equality.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant LLMArgs
    participant BuildConfig
    participant PluginConfig

    User->>LLMArgs: update_llm_args_with_extra_dict(extra_dict)
    LLMArgs->>BuildConfig: BuildConfig.from_dict(dict, plugin_config)
    BuildConfig->>PluginConfig: PluginConfig.from_dict(dict)
    BuildConfig-->>LLMArgs: BuildConfig instance with defaults for missing keys
    LLMArgs-->>User: Updated LLMArgs with nested BuildConfig

Loading

Poem

In a warren of configs, defaults now bloom,
Nested dictionaries find their room.
With careful checks and thoughtful code,
Each missing key finds its abode.
Tests ensure our burrows are neat—
Hopping forward, configs complete!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4d0bcbc and 828c8fc.

📒 Files selected for processing (3)

• tensorrt_llm/builder.py (2 hunks)
• tensorrt_llm/llmapi/llm_args.py (1 hunks)
• tests/unittest/llmapi/test_llm_args.py (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Wanli-Jiang]

/bot run

[tensorrt-cicd]

PR_Github #12147 [ run ] triggered by Bot

[Wanli-Jiang]

/bot run

[tensorrt-cicd]

PR_Github #12148 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #12147 [ run ] completed with state ABORTED

[chzblych]

Approved this PR based on this is a cherry-pick of #5996 from main branch.

[chzblych]

@coderabbitai summary

[coderabbitai]

✅ Actions performed

Summary regeneration triggered.

[tensorrt-cicd]

PR_Github #12148 [ run ] completed with state SUCCESS
/LLM/release-0.21-NIM/L0_MergeRequest_PR pipeline #14 completed with status: 'SUCCESS'