[https://nvbugs/6786555][fix] [https://nvbugs/6786567] Gate SM103 graph test on SM count - #19280
Conversation
Signed-off-by: longcheng-nv <243710427+longcheng-nv@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe SM103 CUDA-graph test now targets the 148-SM register plan. It skips SM103 devices with a different multiprocessor count before validating register planning and replay results. ChangesSM103 CUDA-graph test
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The test is restricted to the intended 148-SM SM103 configuration, with other configurations skipped. No concrete merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #73844 [ run ] triggered by Bot. Commit: |
|
PR_Github #73844 [ run ] completed with state
|
|
Removed the "ci: full pre-merge approved" label because @longcheng-nv could not be verified as an active member of NVIDIA/trt-llm-ci-approvers. Ask a member of that team to apply it. |
|
Removed the "ci: full pre-merge approved" label because @longcheng-nv could not be verified as an active member of NVIDIA/trt-llm-ci-approvers. Ask a member of that team to apply it. |
|
/bot run --reuse-test 60703 |
|
PR_Github #73941 [ run ] triggered by Bot. Commit: |
|
PR_Github #73941 [ run ] completed with state |
|
Please unwaive test case unittest/_torch/thop/parallel/test_gvr_selfsampling_topk.py::test_selfsampling_sm103_b512_k2048_cuda_graph. |
Dev Engineer Review
The CUDA Graph test now requires SM103 and exactly 148 SMs before it runs the register route. This prevents unsupported 160-SM configurations from exercising the route. The change affects test gating only.
QA Engineer Review
The test covers the 148-SM SM103 register plan, warmup, and CUDA Graph replay for
b=512,k=2048. Unsupported configurations skip. Validation passed for Python compilation and pre-commit; targeted pytest collection needs follow-up because local prebuilt bindings were incompatible. No integration test-list entry was found. Coverage verdict: needs follow-up.Per-File QA Perspective
tests/unittest/_torch/thop/parallel/test_gvr_selfsampling_topk.py: Verifies register-route selection and replay on the supported 148-SM SM103 topology. No matching CI or manual-QA list entry was found.Description
The SM103
b=512,k=2048register route added by #19076 is intentionally limited to devices with 148 SMs. The corresponding CUDA Graph test only checked the SM architecture, so a 160-SM GB300 runner selected the baselinemainplan and failed the test'sregassertion.Skip this hardware-specific CUDA Graph test unless the SM103 device has 148 SMs. The static route test continues to verify that the 160-SM topology retains the baseline route.
Test Coverage
python3 -m py_compile tests/unittest/_torch/thop/parallel/test_gvr_selfsampling_topk.pypython3 -m pre_commit run --files tests/unittest/_torch/thop/parallel/test_gvr_selfsampling_topk.pyglobal_steady_clock_nowimport mismatch).PR Checklist