Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 60603 - #19276

Merged
mzweilz merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260916-102859
Sep 17, 2026
Merged

mzweilz merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260916-102859

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @HuiGao-NV)
Target branch: main
Bug(s): 6786567

Waive entries added

unittest/_torch/thop/parallel/test_gvr_selfsampling_topk.py::test_selfsampling_sm103_b512_k2048_cuda_graph SKIP (https://nvbugs/6786567)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

The change adds one SKIP waiver for the CUDA-graph self-sampling test. It does not change source code, APIs, or runtime behavior. The waiver references bug 6786567.

QA Engineer Review

The change modifies tests/integration/test_lists/waives.txt and adds the waiver for unittest/_torch/thop/parallel/test_gvr_selfsampling_topk.py::test_selfsampling_sm103_b512_k2048_cuda_graph. No test implementation changes are included. The entry is in the waiver list; no test-db/ or qa/ list change is shown. Coverage verdict: needs follow-up because the test is skipped.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Adds a SKIP waiver for the CUDA-graph self-sampling top-k test and links it to bug 6786567. QA should remove the waiver after the underlying failure is fixed.

Bug(s): 6786567
Requested by: @HuiGao-NV

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 08547ea2-a4ab-4671-aa91-1b13bca42451

📥 Commits

Reviewing files that changed from the base of the PR and between 845136c and 5875f58.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The integration waiver list now skips test_selfsampling_sm103_b512_k2048_cuda_graph and references NVIDIA bug 6786567.

Changes

SM103 test waiver

Layer / File(s) Summary
Add SM103 CUDA graph test waiver
tests/integration/test_lists/waives.txt
Adds a skipped entry for test_selfsampling_sm103_b512_k2048_cuda_graph and associates it with NVIDIA bug 6786567.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: brnguyen2

Merge Risk: ⚪ Minimal · up to 5875f

This PR only skips the bug-linked SM103 test, with no concrete merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required [None][infra] format and clearly identifies the waiver of a failed pre-merge case on main.
Description check ✅ Passed The description identifies the failed test, waiver action, target branch, bug reference, requester, and generation source. It does not use the template headings, but it provides the required issue, so…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@mzweilz

mzweilz commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive only"

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #74033 [ skip ] triggered by Bot. Commit: 5875f58 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #74033 [ skip ] completed with state SUCCESS. Commit: 5875f58
Skipping testing for commit 5875f58

Link to invocation

@mzweilz
mzweilz merged commit 2b03049 into NVIDIA:main Sep 17, 2026
18 checks passed
chenfeiz0326 added a commit to chenfeiz0326/TensorRT-LLM that referenced this pull request Sep 17, 2026
Picks up the waiver for test_selfsampling_sm103_b512_k2048_cuda_graph (NVIDIA#19276,
https://nvbugs/6786567), the only remaining pre-merge failure on this branch and
not one this PR can cause. That test hardcodes a register-plan rung valid only at
148 SMs, so route() returns the main kernel on a GB300 node with a different SM
count; it failed identically in all three builds on fb49597 (#60671, #60732,
#60819) and was the sole failure in #60819.

No conflicts, and this merge leaves the earlier _util.py resolution untouched.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: chenfeiz0326 <203214996+chenfeiz0326@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants