[https://nvbugs/6652876][fix] Add correct autotuner constraint for sm120 fp8 block scale moe - #18140
Conversation
|
/bot run --stage-list "RTXPro6000D-PyTorch-1" |
|
PR_Github #68808 [ run ] triggered by Bot. Commit: |
|
PR_Github #68808 [ run ] completed with state |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe change adds an SM120-specific FP8 block-scaling GEMM constraint and updates architecture-based selection. It also revises integration test waivers across multiple hardware targets and test categories. ChangesFP8 GEMM and integration test updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The PR adds the SM120 FP8 block-scale MoE autotuner constraint and updates the related test waiver; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the issue and solution and includes the repository checklist. It omits the separate Test Coverage section, but it identifies the affected failing test through the unwaiver change, so the description is mostly complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #68831 [ run ] triggered by Bot. Commit: |
|
PR_Github #68831 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #68856 [ run ] triggered by Bot. Commit: |
|
PR_Github #68856 [ run ] completed with state
|
|
/bot run |
|
PR_Github #68891 [ run ] triggered by Bot. Commit: |
|
PR_Github #68891 [ run ] completed with state
|
Signed-off-by: Dom Brown <3886319+DomBrown@users.noreply.github.com>
Signed-off-by: Dom Brown <3886319+DomBrown@users.noreply.github.com>
7115c2a to
94c682d
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #69082 [ run ] triggered by Bot. Commit: |
|
PR_Github #69082 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #69137 [ run ] triggered by Bot. Commit: |
|
/bot run |
|
PR_Github #69425 [ run ] triggered by Bot. Commit: |
|
PR_Github #69137 [ run ] completed with state |
|
PR_Github #69425 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #69453 [ run ] triggered by Bot. Commit: |
|
PR_Github #69453 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #69492 [ run ] triggered by Bot. Commit: |
|
PR_Github #69492 [ run ] completed with state |
Dev Engineer Review
Mto a multiple of 4.tests/integration/test_lists/waives.txtto remove obsolete waivers and add updated test configurations and NVBugs references.QA Engineer Review
tests/integration/test_lists/waives.txt.Description
The FP8 blockscale MoE requires a different autotuner constraint than the one used for SM100. This PR adds the missing constraint and unwaives the failing test.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.