[https://nvbugs/6652876][fix] Fix SM120 FP8 autotuner scale profiles - #18124
[https://nvbugs/6652876][fix] Fix SM120 FP8 autotuner scale profiles#18124yuxianq wants to merge 2 commits into
Conversation
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe change adds an SM120-specific FP8 block-scaling GEMM constraint that pads M to a multiple of 4. It also removes two waived integration tests. ChangesSM120 FP8 GEMM support
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to The PR corrects SM120 FP8 activation-scale profiling and restores the affected CI coverage, addressing undersized buffers that could trigger runtime faults; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast |
|
PR_Github #68745 [ run ] triggered by Bot. Commit: |
|
PR_Github #68745 [ run ] completed with state
|
|
It duplicates with #18140, close this one. |
Dev Engineer Review
QA Engineer Review
tests/integration/test_lists/waives.txt.test-db/orqa/files were modified.Description
SM120 FP8 block-scaling GEMM activation scales store the token dimension on
dimension 0 and require it to be padded to four rows. The autotuner previously
reused the SM100 constraint, which varied dimension 1 instead. During the
generation warmup this produced undersized synthetic activation-scale buffers
and could make the SM120 TMA scale load raise a Warp MMU fault.
Specialize the SM120 constraint to vary activation-scale dimension 0 with the
required four-row padding while preserving the existing SM100 and SM90
layouts. The Laguna XS FP8 and NVFP4 waivers are removed so CI validates the
ordered suite again; the observed NVFP4 timeout followed the FP8 worker failure
and stale prefetched-session handoff.
Test Coverage
pre-commit run --files tensorrt_llm/_torch/custom_ops/torch_custom_ops.py tests/integration/test_lists/waives.txtpython3 -m py_compile tensorrt_llm/_torch/custom_ops/torch_custom_ops.pyaccuracy/test_llm_api_pytorch.py::TestLagunaXS::test_fp8on RTXPro6000Daccuracy/test_llm_api_pytorch.py::TestLagunaXS::test_nvfp4tests/unittest/_torch/misc/test_autotuner.pyexecution is blocked byan installed TensorRT-LLM binding mismatch with latest main
(
IKvCacheColdPageCodecis missing); the source compiles and all repositorypre-commit checks pass.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.