Skip to content

[None][fix] Pin distro for CI sysinfo detection - #18004

Merged
chzblych merged 1 commit into
NVIDIA:mainfrom
chzblych:fix-pin-distro-dependency
Aug 20, 2026
Merged

[None][fix] Pin distro for CI sysinfo detection#18004
chzblych merged 1 commit into
NVIDIA:mainfrom
chzblych:fix-pin-distro-dependency

Conversation

@chzblych

@chzblych chzblych commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Description

openai 3.3.1 removed distro from its dependency list. TensorRT-LLM's CI sysinfo probe imports distro to populate linux_distribution_name, which is used by test-db rendering. Because TensorRT-LLM did not declare that dependency directly, newly resolved development environments can report na and render empty L0 test lists.

Add distro==1.9.0 directly to requirements-dev.txt. This is a deliberately minimal hotfix to restore the dependency contract. The stdlib fallback and render-time diagnostics remain in follow-up #17993 and should be rebased after this change lands.

Functional impact is limited to development and CI environments. distro 1.9.0 was previously installed transitively, has no dependencies, and is licensed under Apache-2.0.

Test Coverage

PR Checklist

  • PR description explains the change and its risk.
  • Change follows the TensorRT-LLM coding guidelines.
  • Dependency metadata reviewed: Apache-2.0, no dependencies, and no vulnerabilities listed by PyPI.
  • No API, ownership, architecture, or documentation change is required.

Dev Engineer Review

  • Added distro==1.9.0 to requirements-dev.txt.
  • The dependency pin is valid and limited to development and CI environments.
  • The change restores distro availability for CI sysinfo detection.
  • Validation included whitespace checks, requirement parsing, and a pip dry run.
  • No code, API, performance, or error-handling changes were made.

QA Engineer Review

No test changes.

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
@chzblych
chzblych marked this pull request as ready for review August 20, 2026 06:24
@chzblych
chzblych requested a review from a team as a code owner August 20, 2026 06:24
@chzblych
chzblych merged commit 88c3f04 into NVIDIA:main Aug 20, 2026
9 checks passed
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d6ad50be-092c-424e-a6a7-3ab3cd705026

📥 Commits

Reviewing files that changed from the base of the PR and between 0fbac8c and e216a0f.

📒 Files selected for processing (1)
  • requirements-dev.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.


Walkthrough

The development requirements add the pinned distro==1.9.0 dependency.

Changes

Development dependency update

Layer / File(s) Summary
Pin distro development dependency
requirements-dev.txt
Adds distro==1.9.0 to the development requirements.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e216a

This change restores the declared CI development dependency with no expected product-runtime impact, and no actionable merge-blocking risk remains after normal review.

Possibly related PRs

Suggested reviewers: schetlur-nv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format and clearly summarizes the direct dependency pin for CI sysinfo detection.
Description check ✅ Passed The description explains the issue, solution, impact, validation, and checklist items with sufficient detail.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@chzblych
chzblych deleted the fix-pin-distro-dependency branch August 20, 2026 06:28
connorcarpenter15 pushed a commit to connorcarpenter15/TensorRT-LLM that referenced this pull request Aug 27, 2026
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant