[None][fix] Pin distro for CI sysinfo detection - #18004
Conversation
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. WalkthroughThe development requirements add the pinned ChangesDevelopment dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change restores the declared CI development dependency with no expected product-runtime impact, and no actionable merge-blocking risk remains after normal review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Description
openai3.3.1 removeddistrofrom its dependency list. TensorRT-LLM's CI sysinfo probe importsdistroto populatelinux_distribution_name, which is used by test-db rendering. Because TensorRT-LLM did not declare that dependency directly, newly resolved development environments can reportnaand render empty L0 test lists.Add
distro==1.9.0directly torequirements-dev.txt. This is a deliberately minimal hotfix to restore the dependency contract. The stdlib fallback and render-time diagnostics remain in follow-up #17993 and should be rebased after this change lands.Functional impact is limited to development and CI environments.
distro1.9.0 was previously installed transitively, has no dependencies, and is licensed under Apache-2.0.Test Coverage
git diff --checkdistro==1.9.0withpackaging.requirements.Requirementpython3 -m pip install --dry-run --no-deps distro==1.9.0resolved todistro-1.9.0PR Checklist
Dev Engineer Review
distro==1.9.0torequirements-dev.txt.distroavailability for CI sysinfo detection.QA Engineer Review
No test changes.