Skip to content

[None][ci] Add 'distro' to requirements-dev.txt to workaround main broken - #18003

Closed
chzblych wants to merge 3 commits into
mainfrom
patch/yanchaol
Closed

[None][ci] Add 'distro' to requirements-dev.txt to workaround main broken#18003
chzblych wants to merge 3 commits into
mainfrom
patch/yanchaol

Conversation

@chzblych

@chzblych chzblych commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Added 'distro' as a workaround for external dependency changes.

Dev Engineer Review

  • Added distro==1.9.0 to requirements-dev.txt.
  • The pinned version is valid and limits the workaround to development dependencies.
  • The comment documents the dependency workaround.
  • No code, API, or test-list changes are included.

QA Engineer Review

No test changes.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Added 'distro' as a workaround for external dependency changes.

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
@chzblych
chzblych requested a review from a team as a code owner August 20, 2026 06:17
Update distro package version to 1.9.0

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 93a1bb89-96da-47e9-b33e-7052acc8dd12

📥 Commits

Reviewing files that changed from the base of the PR and between 0fbac8c and a15953e.

📒 Files selected for processing (1)
  • requirements-dev.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


Walkthrough

The development requirements pin distro to version 1.9.0 and document the workaround that requires it.

Changes

Development dependency

Layer / File(s) Summary
Add distro workaround dependency
requirements-dev.txt
The development requirements document the workaround and pin distro to version 1.9.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a1595

This change adds a development dependency to work around an external dependency change; no actionable merge-blocking risk remains after normal review checks.

Suggested reviewers: atrifex

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the change but leaves the required Description and Test Coverage sections incomplete. Complete the Description section with the issue and solution, and document relevant test coverage or explain why no tests are needed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI change: adding distro to requirements-dev.txt as a workaround for a broken dependency state.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch patch/yanchaol

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
@chzblych

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "GB10-PyTorch-1, DGX_H100-PyTorch-1" --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67710 [ run ] triggered by Bot. Commit: 45c4a44 Link to invocation

@chzblych

Copy link
Copy Markdown
Collaborator Author

Closed in favor of #18004.

@chzblych chzblych closed this Aug 20, 2026
@chzblych
chzblych deleted the patch/yanchaol branch August 20, 2026 07:48
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67710 [ run ] completed with state SUCCESS. Commit: 45c4a44
/LLM/main/L0_MergeRequest_PR pipeline #55199 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants