[https://nvbugs/6422343][test] Unwaive DeepSeek V3 Lite BF16 test - #17809
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 9 remain after this review. WalkthroughThe integration waiver list removes eight Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only re-enables the two specified DeepSeek V3 Lite BF16 test variants across the listed platforms; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast |
|
PR_Github #66700 [ run ] triggered by Bot. Commit: |
|
PR_Github #66700 [ run ] completed with state |
ee4ad51 to
2c1971b
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
2c1971b to
60e4320
Compare
|
/bot run --disable-fail-fast |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
PR_Github #66991 [ run ] triggered by Bot. Commit: |
|
PR_Github #66991 [ run ] completed with state |
Dev Engineer Review
DeepSeekV3LiteBF16 tests withv2_kv_cache=Falseandv2_kv_cache=True.tests/integration/test_lists/waives.txt.QA Engineer Review
test-db/orqa/files were modified.tests/integration/test_lists/waives.txt.Description
Remove all eight platform-specific waivers associated with NVBug 6422343 for the two DeepSeek V3 Lite BF16 test variants (
v2_kv_cache=Falseandv2_kv_cache=True). The cases remain in the QA functional test list, so removing the waivers re-enables coverage on B200, B300, GB300, H100, and H20.The NVBug investigation reports that the failure could not be reproduced in 100 consecutive runs each on H100 and H200. This is intentionally an unwaive-only change so CI and QA can surface any remaining platform-specific failures.
Test Coverage
git diff --checkThe full DeepSeek V3 Lite accuracy test was not rerun as part of this change because it requires the model weights and QA GPU environment; the repeated H100/H200 runtime validation is recorded in NVBug 6422343.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.