[None][test] Unwaive DeepSeek nvfp4 tests (nvbugs 6481323, 6245394) - #17789
Conversation
Remove waives for the following tests which are being re-enabled: - TestDeepSeekR1::test_nvfp4_multi_gpus[throughput_pp4_mtp] (nvbugs/6481323) - TestDeepSeekV3Lite::test_nvfp4_4gpus[moe_backend=CUTLASS-mtp_nextn=2-pp4-fp8kv=True-attention_dp=True-cuda_graph=True-overlap_scheduler=True-low_precision_combine=False-torch_compile=False] (nvbugs/6245394) Signed-off-by: Fred Wei <20514172+WeiHaocheng@users.noreply.github.com>
15dd3d8 to
9637340
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review. WalkthroughRemoved two skipped accuracy test entries from the integration waiver list. Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change re-enables two previously waived integration tests without modifying product or runtime behavior; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
/bot skip -m "Just unwaive tests" |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
Signed-off-by: WeiHaocheng <469657736@qq.com>
|
/bot skip --comment "Just unwaive tests" |
|
PR_Github #66729 [ skip ] triggered by Bot. Commit: |
|
PR_Github #66729 [ skip ] completed with state |
Remove waives for the following tests which are being re-enabled:
Dev Engineer Review
tests/integration/test_lists/waives.txt.QA Engineer Review
tests/integration/test_lists/waives.txt.nvbugs/6481323nvbugs/6245394test-db/orqa/files were modified.Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.