test(windows): separate trusted path oracle

[senthilr-nv]

Summary

Separates the privileged Docker Desktop path oracle from the bootstrap path construction after PR #9683. The test now verifies the trusted Program Files prefix and exact Docker\\Docker suffix independently, so a matching implementation and expectation change cannot hide a machine-root regression. Production Windows bootstrap behavior is unchanged.

E2E root cause: bootstrap-windows tests / Docker Desktop path assertions / host-platform path semantics on macOS
Source run: https://github.com/NVIDIA/NemoClaw/actions/runs/32312339289 (run 32312339289, attempt 1)
Failed job: macOS compatibility (1/4) (96257900908)
Signature: three Windows Docker Desktop path assertions used host-platform path semantics on macOS
Scope: one root cause; follow-up to the unresolved trusted-root oracle review on PR #9683

Changes

• Export only the trusted Program Files value from PowerShell.
• Assert the trusted prefix and exact Docker\\Docker suffix separately in TypeScript.
• Keep scripts/bootstrap-windows.ps1 and production behavior unchanged.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: Independent nine-category security review passed for 1787bb63042babba7213fd82feaec29354ec2d8d; production bootstrap code is unchanged.
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit:
• Station profile/scenario:
• Result:
• Supporting evidence:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable — equivalent upstream-bound pre-commit, commitlint, and pre-push commands passed; the normal pre-push hook also passed during publication.
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: npx vitest run --project integration test/bootstrap-windows.test.ts collected 32 tests and skipped them because PowerShell is unavailable locally. PR CI provides the Windows-capable macOS result.
• Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Senthil Ravichandran senthilr@nvidia.com

Summary by CodeRabbit

• Tests
  • Improved Windows Docker environment validation by checking that Docker is installed within the trusted Program Files directory.
  • Added verification that the detected Docker machine root uses the expected Docker\Docker path.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 90b2b9b8-a3f9-4769-8cc8-f48d8e60b31b

📥 Commits

Reviewing files that changed from the base of the PR and between 7689b4a and 1787bb6.

📒 Files selected for processing (1)

• test/bootstrap-windows.test.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

📝 Walkthrough

Walkthrough

The Windows bootstrap test now uses the trusted Program Files directory and verifies that the discovered Docker machine root starts within that directory and ends with Docker\Docker.

Changes

Windows Docker discovery validation

Layer / File(s)	Summary
Trusted directory assertions test/bootstrap-windows.test.ts	The test uses the trusted Program Files path and validates the Docker machine root with prefix and suffix assertions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1787b

This change only separates Windows path test assertions without changing production behavior; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: aasthajh

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: separating the trusted Windows path oracle in tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/fix-bootstrap-windows-trusted-root-oracle

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit 1787bb6 in the codex/fix-bootstrap-... branch remains at 96%, unchanged from commit 40dc272 in the main branch.

TypeScript / code-coverage/cli

The overall line coverage in commit 1787bb6 in the codex/fix-bootstrap-... branch remains at 83%, unchanged from commit fed0c45 in the main branch.

Show a line coverage summary of the most impacted files.

File	main fed0c45	codex/fix-bootstrap-... 1787bb6	+/-
src/lib/onboard...uild-context.ts	86%	86%	0%
src/lib/cli/oclif-metadata.ts	95%	95%	0%
src/commands/sandbox/agent.ts	100%	100%	0%
src/lib/cli/argv-normalizer.ts	100%	100%	0%
src/lib/onboard...ward-cleanup.ts	100%	100%	0%
src/lib/cli/public-dispatch.ts	87%	88%	+1%
src/lib/onboard...on-authority.ts	81%	82%	+1%
src/lib/cli/com...and-registry.ts	93%	94%	+1%
src/commands/sandbox/mcp.ts	85%	86%	+1%
src/commands/uninstall.ts	90%	91%	+1%

---

_{Updated August 20, 2026 04:07 UTC}

[github-actions]

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Model comparison: normalized findings match; normalized terminology decisions match; normalized E2E selections differ; severity counts match.

1 additional E2E selection from the second opinion

Advisory only. The primary lane did not select these E2E jobs or targets.

• bootstrap-install-smoke: The completed second-opinion lane identified E2E coverage that the primary lane omitted.

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite for the commit under review.

Recommended E2E: None

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.