fix(onboard): accept owned Teams webhook field

[rsliter]

Summary

Managed startup validation rejected the stock Microsoft Teams OpenClaw webhook object because the credential-field scanner treated every field with that name as secret-bearing.
This change accepts only the schema-owned non-secret object and keeps every other webhook location or shape fail closed.

Related Issue

Fixes #9610.

Changes

• Accept messaging.plan.agentRender[i].value.webhook only for the exact Microsoft Teams OpenClaw channel, render, hook, handler, agent, target, and configuration path.
• Require an object containing only integer port from 1 through 65,535 and exact path /api/messages; reject raw credentials, malformed values, extra fields, ownership mismatches, and the same object elsewhere.
• Add a focused 24-case managed-profile regression suite without weakening the generic credential scanner or adding a broad allowlist.
• Record the escaped-defect root cause: the recursive credential scanner lacked a schema-owned non-secret exception, and the managed-profile tests did not exercise the stock Teams render at that validation boundary.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior, justification:
• Tests not applicable, justification:
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded, reviewer/approval link/justification: Complete validation-boundary review confirmed that credential custody is unchanged and raw credentials, malformed values, extra fields, ownership mismatches, and all other webhook paths remain rejected before canonicalization.
• Non-success, skipped, or missing CI check accepted by maintainer, check name, approval link, and follow-up issue:

Documentation Writer Review

• Documentation writer subagent reviewed the completed changes
• Result: no-docs-needed
• Evidence: This repairs internal validation for the existing Microsoft Teams OpenClaw manifest. Existing documentation already owns the webhook path, port, credential custody, and supported integration.
• Agent: Codex Desktop

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit:
• Station profile/scenario:
• Result:
• Supporting evidence:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above, command/result or justification: Focused Teams webhook tests passed 24/24, and the managed-profile family passed 259/259. CLI and plugin builds, npm run typecheck:cli, focused formatting and lint, npm run test:titles:check, and npm run checks:repository passed.
• Applicable broad gate passed, npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes, command/result: npm run test:changed passed 7,870 tests and ended with 10 unrelated failures: seven aggregate timeouts, two existing DCode preference-restore assertions, and one Hermes fixture Python compatibility error.
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Rebecca Sliter 571084+rsliter@users.noreply.github.com

Summary by CodeRabbit

• Bug Fixes
  • Improved validation for Microsoft Teams webhook configurations in managed startup profiles.
  • Valid webhook settings using the expected port and /api/messages path are now accepted.
  • Invalid, malformed, misplaced, or mismatched webhook configurations are rejected.
• Tests
  • Added coverage for valid and invalid Teams webhook scenarios.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6ad535c2-0cd2-4275-8298-a8e1160933be

📥 Commits

Reviewing files that changed from the base of the PR and between dbf48ba and 8962b36.

📒 Files selected for processing (2)

• src/lib/onboard/managed-startup-profile-teams-webhook.test.ts
• src/lib/onboard/managed-startup/profile.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The managed startup profile now permits the stock OpenClaw Microsoft Teams webhook structure. Focused tests cover valid ports, malformed values, mismatched render metadata, extra fields, credentials, and unowned placement.

Changes

Microsoft Teams webhook validation

Layer / File(s)	Summary
Authorize the stock Teams webhook src/lib/onboard/managed-startup/profile.ts	The credential-shaped field scanner permits webhook only for the expected Teams render metadata, integer port range, exact path, and object shape.
Validate accepted and rejected webhook cases src/lib/onboard/managed-startup-profile-teams-webhook.test.ts	Tests cover valid ports, malformed values, mismatched metadata, credential-bearing values, extra fields, and unowned placement.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 8962b

This narrowly accepts the schema-owned Microsoft Teams webhook object while continuing to reject other webhook locations and malformed or credential-bearing values. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: ericksoa, laitingsheng, apurvvkumaria

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: accepting the owned Microsoft Teams webhook field during onboarding.
Linked Issues check	✅ Passed	The changes satisfy issue [#9610] by enforcing the owned Teams webhook path, exact shape, valid port, exact path, and regression coverage.
Out of Scope Changes check	✅ Passed	The changes remain within issue [#9610] and do not weaken the generic scanner or add unrelated functionality.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/fix-9610-msteams-webhook-schema

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit 8962b36 in the codex/fix-9610-mstea... branch remains at 96%, unchanged from commit dbf48ba in the main branch.

[github-actions]

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Model comparison: normalized findings match; normalized terminology decisions differ; normalized E2E selections differ; severity counts match.

2 terminology differences from the second opinion

Advisory only. These are normalized differences from the primary terminology receipt.

• stock at src/lib/onboard/managed-startup/profile.ts:1100: selected only by the second-opinion lane as established.
• webhook at src/lib/onboard/managed-startup/profile.ts:1112: selected only by the second-opinion lane as established.

2 additional E2E selections from the second opinion

Advisory only. The primary lane did not select these E2E jobs or targets.

• messaging-providers: The completed second-opinion lane identified E2E coverage that the primary lane omitted.
• messaging-compatible-endpoint: The completed second-opinion lane identified E2E coverage that the primary lane omitted.

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

Since last review: 0 prior items resolved · 0 still apply · 0 new items found

2 semantic terminology decisions

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

• justified — stock Microsoft Teams OpenClaw webhook at src/lib/onboard/managed-startup-profile-teams-webhook.test.ts:107: Keep the term in the test title because the test validates the fixed emitted shape.
• justified — owned render value at src/lib/onboard/managed-startup-profile-teams-webhook.test.ts:165: Keep the term in the test title because the test proves location is part of the validation contract.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite for the commit under review.

Recommended E2E: None

Manual-only E2E: managed-image-multiarch-startup, device-auth-health, onboard-repair, onboard-resume, openclaw-inference-switch, cloud-onboard, issue-4462-scope-upgrade-approval
The manual PR workflow does not run these selectors for the commit under review. Run them from reviewed code on main.

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

[prekshivyas]

Reviewed commit 8962b364874ae054529ad31217cea0f23c799935 against base dbf48bae9d35beda8d781205a46e881d6f8f900a.

The credential-field exception is limited to the exact Microsoft Teams OpenClaw render identity and a webhook object containing only an integer port in 1–65535 plus the exact /api/messages path. Normal payload traversal still rejects custom prototypes, accessors, symbols, extra fields, nested credential material, and placement outside that owned render. I found no blocking issue.

Test evidence: four focused/regression files passed (223 tests), including all managed startup profile, builder, runtime alias, and Teams webhook tests; git diff --check passed. The current failed CI shard is an unrelated timeout in host-local-vllm-selection.test.ts; the other CLI shards and security/build checks passed.

Security review:

• Secrets and credentials: PASS — only a fixed non-secret webhook listener shape is exempted; nested credential scanning remains active.
• Input validation: PASS — render identity, object shape, port bounds, and path are exact.
• Authentication and authorization: PASS — no authentication or runtime authority changes.
• Dependencies: PASS — no dependency changes.
• Error handling and logging: PASS — rejection behavior remains fail-closed outside the owned shape.
• Cryptography: PASS — no cryptographic changes.
• Configuration and deployment: PASS — no deployment changes; the accepted configuration matches the owned Teams render contract.
• Testing and coverage: PASS — positive, boundary, malformed, mismatched, extra-field, secret-bearing, and misplaced cases are covered.
• System-level safety: PASS — the generic credential scanner remains authoritative for every non-matching path and value.