fix(onboard): pass messaging dependencies during reuse

[deepujain]

Summary

Restore the recorded messaging resume path after the lifecycle reconciliation update. Recorded channels now pass the required persistence and notification dependencies into host-channel filtering, and the affected reuse fixtures model that contract.

Related Issue

Fixes #9359

Changes

• Pass onboarding messaging dependencies through recorded-channel reconciliation.
• Update the existing reuse fixtures to provide the dependency contract required when channels are filtered and persisted.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit: Not applicable
• Station profile/scenario: Not applicable
• Result: Not applicable
• Supporting evidence: Not applicable

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run --project cli src/lib/onboard/machine/handlers/sandbox-messaging.test.ts (32 passed)
• Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

Additional validation: npm run build:cli, npm run typecheck:cli, and npm run lint.

---

Signed-off-by: Deepak Jain deepujain@gmail.com

Summary by CodeRabbit

• Bug Fixes
  • Improved reconciliation when resuming recorded sandbox messaging sessions.
  • Missing host configuration is now clearly noted, while outdated saved plans are removed without being rewritten.
  • Improved filtering of unavailable messaging channels and handling of related plan updates and notifications.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a06c7a81-fc0d-4f4f-aba7-47a8d69ecb33

📥 Commits

Reviewing files that changed from the base of the PR and between c157d83 and 817025d.

📒 Files selected for processing (2)

• src/lib/onboard/machine/handlers/sandbox-messaging.test.ts
• src/lib/onboard/machine/handlers/sandbox-messaging.ts

🚧 Files skipped from review as they are similar to previous changes (2)

• src/lib/onboard/machine/handlers/sandbox-messaging.test.ts
• src/lib/onboard/machine/handlers/sandbox-messaging.ts

Included review availability: Your plan includes up to 12 reviews per rolling hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The recorded-channel reconciliation path now passes options.deps to filterUnconfiguredHostChannelsFromSelection. Tests add dependency mocks and verify notification, plan clearing, and the absence of plan rewriting.

Changes

Recorded messaging reconciliation

Layer / File(s)	Summary
Dependency wiring and validation src/lib/onboard/machine/handlers/sandbox-messaging.ts, src/lib/onboard/machine/handlers/sandbox-messaging.test.ts	The recorded-channel path passes options.deps to filterUnconfiguredHostChannelsFromSelection. Test fixtures add note and writePlanToEnv mocks. The recorded-resume test verifies notification, persisted-plan cleanup, and no replacement plan write.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 81702

This localized change restores messaging dependencies during recorded-channel reuse, with targeted validation reported as passing; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

• NVIDIA/NemoClaw#9139: Extends the same recorded-channel reconciliation changes and related tests.
• NVIDIA/NemoClaw#9294: Updates the same reused-sandbox reconciliation and host-channel filtering behavior.
• NVIDIA/NemoClaw#9296: Introduces the dependency and recorded-resume behavior updated here.

Suggested labels: area: messaging, area: onboarding, bug-fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: passing messaging dependencies during sandbox reuse.
Linked Issues check	✅ Passed	The changes pass options.deps to the helper and add focused recorded-channel regression assertions required by issue #9359.
Out of Scope Changes check	✅ Passed	The changes remain within scope by updating the required call site and its focused regression fixtures and assertions.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[deepujain]

Added focused assertions for the recorded-channel side effects and documented the reconciliation helper. The targeted suite, typecheck, lint, and repository checks pass.

[github-actions]

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 1 warning · 1 suggestion
• Model comparison: normalized findings differ; normalized terminology decisions differ; normalized E2E selections differ; Nemotron reported the same number of blockers, 1 more warning, 1 more suggestion.

1 terminology difference from the second opinion

Advisory only. These are normalized differences from the primary terminology receipt.

• checkpoint channels at src/lib/onboard/machine/handlers/sandbox-messaging.ts:376: selected only by the second-opinion lane as replace.

4 additional E2E selections from the second opinion

Advisory only. The primary lane did not select these E2E jobs or targets.

• messaging-providers: The completed second-opinion lane identified E2E coverage that the primary lane omitted.
• channels-stop-start: The completed second-opinion lane identified E2E coverage that the primary lane omitted.
• hermes-discord: The completed second-opinion lane identified E2E coverage that the primary lane omitted.
• whatsapp-qr-compact: The completed second-opinion lane identified E2E coverage that the primary lane omitted.

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

1 semantic terminology decision

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

• established — host inputs at src/lib/onboard/machine/handlers/sandbox-messaging.ts:376: Keep `host inputs` for current host-side channel configuration.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite for the commit under review.

Recommended E2E: None

Manual-only E2E: cloud-onboard, onboard-repair, onboard-resume
The manual PR workflow does not run these selectors for the commit under review. Run them from reviewed code on main.

1 optional E2E recommendation

• channels-add-remove

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.