ci(e2e): wait for Launchable family update

[jyaunches]

Summary

Wait five minutes after the image producer verifies the staging family before deploying the standing Brev Launchable. Record the guest's GCE boot image before reading its provision receipt so a stale-family boot remains diagnosable when that receipt is absent.

Changes

• Add a fixed 300-second family settle period before brev create --launchable.
• Persist the concrete boot image in launchable-e2e.json before validating /etc/nemoclaw/provision.json.
• Cover settle-before-deploy ordering, wrong-image rejection, missing-receipt evidence, runtime provenance, full E2E, and cleanup.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Docs updated for user-facing behavior changes
• Docs not applicable — justification: This changes only the protected internal E2E controller; the existing E2E README already describes exact baked-candidate validation through the standing Launchable.
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

• Documentation writer subagent reviewed the completed changes
• Result: no-docs-needed
• Evidence: Only the internal Launchable E2E controller and its focused tests changed. Existing E2E documentation already owns the exact-image behavior; comments, logs, errors, and test titles have no blocking terminology findings.
• Agent: Codex Desktop

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit:
• Station profile/scenario:
• Result:
• Supporting evidence:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: npx vitest run --project integration test/brev-launchable-e2e.test.ts passed 5/5 after the final behavior edit.
• Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Julie Yaunches jyaunches@nvidia.com

Summary by CodeRabbit

• Bug Fixes

  • Improved staging Launchable workflows by waiting for image availability before creating guest workspaces.
  • Enhanced boot image and runtime receipt handling to preserve accurate launch state.
  • When a provision receipt is unavailable, the workflow now fails safely, removes temporary state, and records the run as pending instead of starting full end-to-end validation.

• Tests

  • Added coverage for timing, boot image mismatches, and missing provision receipts.

[coderabbitai]

📝 Walkthrough

Walkthrough

The Launchable E2E flow now waits for staging image readiness, captures the boot image before retrieving the runtime receipt, merges receipt data into persisted state, and adds coverage for boot-image mismatches and missing provision receipts.

Changes

Launchable E2E flow

Layer / File(s)	Summary
Boot capture and receipt persistence tools/e2e/brev-launchable-e2e.sh, test/brev-launchable-e2e.test.ts	The flow waits 300 seconds, validates and persists the guest boot image before retrieving the runtime receipt, then merges receipt fields into the existing state; tests verify the sleep ordering.
Boot and provision receipt failure coverage test/brev-launchable-e2e.test.ts	The fake command harness supports boot-image and missing-receipt scenarios, while tests verify early failure, state cleanup, and pending fullE2e state preservation.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested labels: area: ci

Suggested reviewers: cv, brandonpelfrey, ericksoa

Sequence Diagram(s)

sequenceDiagram
  participant LaunchableScript
  participant GuestWorkspace
  participant LaunchableState
  LaunchableScript->>LaunchableScript: wait 300 seconds
  LaunchableScript->>GuestWorkspace: validate boot_image
  LaunchableScript->>LaunchableState: persist bootImage and pending fullE2e
  LaunchableScript->>GuestWorkspace: retrieve runtime receipt
  LaunchableScript->>LaunchableState: merge receipt fields

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly reflects the main change: adding a wait during the Launchable family update flow in E2E.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/wait-launchable-family

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 13b6f44 in the codex/wait-launchabl... branch remains at 96%, unchanged from commit 1ce71fa in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit 13b6f44 in the codex/wait-launchabl... branch remains at 81%, unchanged from commit 1ce71fa in the main branch.

Show a code coverage summary of the most impacted files.

File	main 1ce71fa	codex/wait-launchabl... 13b6f44	+/-
src/lib/domain/.../connect-env.ts	97%	89%	-8%
src/lib/inferen...ompatibility.ts	95%	94%	-1%
src/lib/sandbox...rce-identity.ts	88%	88%	0%

---

_{Updated July 30, 2026 19:10 UTC}

[github-actions]

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

• GPT-5.6 Terra (primary): Completed · medium confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 1 warning · 0 suggestions
• Model comparison: normalized findings differ; normalized E2E selections match; Nemotron reported the same number of blockers, 1 more warning, the same number of suggestions.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: cloud-inference, cloud-onboard, security-posture

1 optional E2E recommendation

• staging-brev-launchable

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

[coderabbitai]

🧹 Nitpick comments (1)

test/brev-launchable-e2e.test.ts (1)

257-266: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Assert evidence-file preservation for the wrong-image path too.

Per the script's new ordering, launchable-e2e.json is written with boot.bootImage (the actual booted image) and fullE2e:"pending" before the boot-image match check, so it should also be preserved when the boot image is wrong — mirroring the sibling "missing provision receipt" test (Lines 303-309). This test only checks state (workspace.json) absence, leaving the new evidence-preservation behavior unverified for this failure path.

✅ Suggested assertion addition

     expect(fs.readFileSync(wrongImage.calls, "utf8")).not.toContain("full-e2e.test.ts");
     expect(fs.existsSync(wrongImage.state)).toBe(false);
+    expect(
+      JSON.parse(fs.readFileSync(path.join(wrongImage.workDir, "launchable-e2e.json"), "utf8")),
+    ).toMatchObject({
+      boot: { bootImage: "projects/brevdevprod/global/images/wrong-image" },
+      fullE2e: "pending",
+    });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/brev-launchable-e2e.test.ts` around lines 257 - 266, Update the
wrongImage assertions in the launchable E2E test to verify that its evidence
file, launchable-e2e.json, is preserved after the boot-image mismatch failure.
Read the evidence file and assert it records the actual boot image and pending
fullE2e status, mirroring the missing-provision-receipt test while retaining the
existing state-file absence checks.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@test/brev-launchable-e2e.test.ts`:
- Around line 257-266: Update the wrongImage assertions in the launchable E2E
test to verify that its evidence file, launchable-e2e.json, is preserved after
the boot-image mismatch failure. Read the evidence file and assert it records
the actual boot image and pending fullE2e status, mirroring the
missing-provision-receipt test while retaining the existing state-file absence
checks.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 20eb94b7-1d49-44c7-89c5-c40cc19d5346

📥 Commits

Reviewing files that changed from the base of the PR and between 1ce71fa and 13b6f44.

📒 Files selected for processing (2)

• test/brev-launchable-e2e.test.ts
• tools/e2e/brev-launchable-e2e.sh

[cjagwani]

lgtm