Skip to content

fix(security): remediate managed image dependencies - #7908

Merged
senthilr-nv merged 1 commit into
mainfrom
codex/security-managed-image-cve-closure
Jul 30, 2026
Merged

fix(security): remediate managed image dependencies#7908
senthilr-nv merged 1 commit into
mainfrom
codex/security-managed-image-cve-closure

Conversation

@senthilr-nv

@senthilr-nv senthilr-nv commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

Updates the existing Hermes and Deep Agents Code managed base images to dependency versions that contain public security fixes. Hermes now pins Node.js 24.18.1, uv 0.11.33, MCP 1.28.1, and Tornado 6.5.7; Deep Agents Code retains its integration-compatible 0.1.34 release with hash-locked fixed transitive dependencies.

Changes

  • Checksum-pins the official Node.js 24.18.1 archives for amd64 and arm64, and updates the bundled npm remediation contract for npm 11.16.0.
  • Applies an exact-source Hermes metadata and frozen-lock update for MCP 1.28.1 and Tornado 6.5.7, with dependency consistency and installed-version assertions.
  • Keeps the current Deep Agents Code 0.1.34 integration contract while pinning uv 0.11.33, MCP 1.28.1, Pillow 12.3.0, and pyasn1 0.6.4 with hashes. Moving to Deep Agents Code 0.1.45 or later requires a separately validated hooks migration; the image contract test protects this temporary compatibility requirement.
  • Updates the Hermes and Deep Agents Code dependency review records.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification:
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: Security checklist passed for the exact PR diff; archive checksums, lock hashes, public dependency audits, installed-version assertions, gitleaks, and hadolint passed.
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

  • Documentation writer subagent reviewed the completed changes
  • Result: docs-updated
  • Evidence: docs/security/hermes-0.19.0-dependency-review.md; agents/langchain-deepagents-code/dependency-review.md
  • Agent: Codex Desktop

DGX Station Hardware Evidence

  • Tested on DGX Station
  • Tested commit:
  • Station profile/scenario:
  • Result:
  • Supporting evidence:

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: Focused Hermes, Deep Agents Code image, bundled npm, and patch tests passed (50 tests); affected subsets passed again after final edits (24 tests and 7 tests).
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Senthil Ravichandran senthilr@nvidia.com

Summary by CodeRabbit

  • Security

    • Updated dependency versions to address reported vulnerabilities.
    • Added stricter package and runtime version verification.
  • Reliability

    • Pinned Node.js 24.18.1 and uv 0.11.33 with checksum and version checks.
    • Improved reproducibility of Hermes and Deep Agents Code environments.
  • Documentation

    • Refreshed dependency reviews, audit records, compatibility details, and security notes.
  • Tests

    • Expanded validation for dependency pins, runtime versions, and npm upgrade scenarios.

@senthilr-nv senthilr-nv added area: docs Documentation, examples, guides, or docs build area: packaging Packages, images, registries, installers, or distribution area: security Security controls, permissions, secrets, or hardening security labels Jul 30, 2026
@senthilr-nv senthilr-nv self-assigned this Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9eb91473-6363-481e-9945-a37df496af97

📥 Commits

Reviewing files that changed from the base of the PR and between 45d7e1a and 4eb2caf.

⛔ Files ignored due to path filters (1)
  • agents/langchain-deepagents-code/requirements.lock is excluded by !**/*.lock
📒 Files selected for processing (11)
  • agents/hermes/Dockerfile.base
  • agents/hermes/security-dependencies.patch
  • agents/langchain-deepagents-code/Dockerfile.base
  • agents/langchain-deepagents-code/dependency-review.md
  • agents/langchain-deepagents-code/requirements.in
  • docs/security/hermes-0.19.0-dependency-review.md
  • scripts/upgrade-bundled-npm.mts
  • test/hermes-dependency-review.test.ts
  • test/langchain-deepagents-code-image.test.ts
  • test/patch-bundled-npm-tar.test.ts
  • test/upgrade-bundled-npm.test.ts

📝 Walkthrough

Walkthrough

Hermes and Deep Agents Code dependency pins, lockfiles, container tooling versions, npm upgrade compatibility, build-time assertions, audit records, and related tests are updated.

Changes

Dependency and runtime alignment

Layer / File(s) Summary
Dependency pins and lockfiles
agents/hermes/security-dependencies.patch, agents/langchain-deepagents-code/requirements.in
Updated Python security pins, extras, lockfile resolutions, and Deep Agents Code constraints for cryptography, mcp, Pillow, pyasn1, starlette, tornado, uv, and related packages.
Runtime tooling and npm compatibility
agents/hermes/Dockerfile.base, agents/langchain-deepagents-code/Dockerfile.base, scripts/upgrade-bundled-npm.mts, test/patch-bundled-npm-tar.test.ts, test/upgrade-bundled-npm.test.ts
Added checksum-verified Node.js 24.18.1 installation, exact uv validation, expanded Python version checks, and npm 11.16.0 upgrade and tar remediation coverage.
Audit records and validation coverage
docs/security/hermes-0.19.0-dependency-review.md, agents/langchain-deepagents-code/dependency-review.md, test/hermes-dependency-review.test.ts, test/langchain-deepagents-code-image.test.ts
Updated dependency review records and tests for the revised pins, audit results, runtime tooling assertions, and documented remediation details.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested labels: dependencies, integration: hermes, integration: dcode, platform: container

Suggested reviewers: cv, brandonpelfrey

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the security-focused dependency remediation across managed images.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/security-managed-image-cve-closure

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 4eb2caf in the codex/security-manag... branch remains at 96%, unchanged from commit 45d7e1a in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit 4eb2caf in the codex/security-manag... branch remains at 81%, unchanged from commit 45d7e1a in the main branch.

Show a code coverage summary of the most impacted files.
File main 45d7e1a codex/security-manag... 4eb2caf +/-
src/lib/onboard/docker-cdi.ts 80% 70% -10%
src/lib/actions...-add-restart.ts 19% 10% -9%
src/lib/actions...lution-probe.ts 95% 88% -7%
src/lib/actions...x/mcp-bridge.ts 41% 35% -6%
src/lib/onboard...shboard-port.ts 96% 90% -6%
src/lib/actions...e-validation.ts 84% 81% -3%
src/lib/onboard/preflight.ts 80% 80% 0%
src/lib/actions...confirmation.ts 69% 79% +10%
src/lib/actions...ocker-health.ts 65% 82% +17%
src/lib/onboard...box-prebuild.ts 74% 92% +18%

Updated July 30, 2026 14:38 UTC

@github-actions

Copy link
Copy Markdown
Contributor

@senthilr-nv senthilr-nv added bug-fix PR fixes a bug or regression integration: hermes Hermes integration behavior integration: dcode LangChain Deep Code integration behavior v0.0.99 labels Jul 30, 2026
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

  • GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Model comparison: normalized findings match; normalized E2E selections differ; severity counts match.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: cloud-inference, cloud-onboard, full-e2e, hermes-e2e, security-posture, state-backup-restore, upgrade-stale-sandbox, ubuntu-repo-cloud-langchain-deepagents-code

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@apurvvkumaria apurvvkumaria left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on exact head 4eb2caf. I found no critical blocking issue in the dependency, image-build, lockfile, or runtime-security changes. The checksum-pinned Node archives match the official release manifest, the new PyPI package hashes match official release metadata, and the fail-closed version assertions cover the installed image state. Exact-head CI, CodeQL, amd64/arm64 image builds, and E2E are green; independent targeted validation passed 39/39 tests.

Non-blocking fast follow-ups:

  • Migrate deepagents-code from 0.1.34 to 0.1.45 or newer after validating the changed hooks boundary, then remove the temporary direct mcp and pyasn1 constraints.
  • Remove the manual Node overlay when the pinned node:24-trixie-slim digest carries Node 24.18.1 or newer.
  • Refresh the branch from current main before merge only if the repository requires it; the sole intervening main change is docs-only and does not overlap this PR.

@senthilr-nv
senthilr-nv merged commit f7a4f8c into main Jul 30, 2026
77 of 78 checks passed
@senthilr-nv
senthilr-nv deleted the codex/security-managed-image-cve-closure branch July 30, 2026 16:44
@sandl99 sandl99 mentioned this pull request Jul 31, 2026
23 tasks
sandl99 added a commit that referenced this pull request Jul 31, 2026
<!-- markdownlint-disable MD041 -->
## Summary

Adds the canonical July 30 release entry for `v0.0.99` before the
release tag is captured.
The entry covers all 37 merged PRs since `v0.0.98` and bounds
experimental or dormant work without presenting it as supported
behavior.

## Changes

- Adds `docs/changelog/2026-07-30.mdx` with the exact `## v0.0.99`
heading, parser-safe MDX SPDX comment, summary, detailed release
bullets, and published documentation routes.
- Records user-visible recovery, snapshot, shared-route, Hermes,
readiness, inference, image, documentation, and release E2E changes.
- States that the managed-image selection and startup-profile contracts
remain dormant and do not activate buildless onboarding.

Source summary:

- [#7972](#7972) ->
`docs/changelog/2026-07-30.mdx`: Records restored managed OpenClaw
configuration modes during recovery.
- [#7834](#7834) ->
`docs/changelog/2026-07-30.mdx`: Records clone-bound pairing
verification after snapshot restore.
- [#7975](#7975) ->
`docs/changelog/2026-07-30.mdx`: Records managed startup recovery
coverage.
- [#7960](#7960) ->
`docs/changelog/2026-07-30.mdx`: Records dormant startup-profile
coordination without activating a supported surface.
- [#7856](#7856) ->
`docs/changelog/2026-07-30.mdx`: Records persistence of the
credential-free OpenClaw startup command.
- [#7959](#7959) ->
`docs/changelog/2026-07-30.mdx`: Records dormant startup-profile
construction without changing onboarding.
- [#7946](#7946) ->
`docs/changelog/2026-07-30.mdx`: Records the internal startup-profile
schema and transport contract.
- [#7951](#7951) ->
`docs/changelog/2026-07-30.mdx`: Records platform-pull cleanup before
managed-image validation.
- [#7949](#7949) ->
`docs/changelog/2026-07-30.mdx`: Records rejection of retained Hermes
`uv` build cache metadata.
- [#7597](#7597) ->
`docs/changelog/2026-07-30.mdx`: Records separate command and agent
first-turn latency evidence.
- [#7931](#7931) ->
`docs/changelog/2026-07-30.mdx`: Records focused E2E replacement
evidence for retired selectors.
- [#7950](#7950) ->
`docs/changelog/2026-07-30.mdx`: Records exclusion of build-only
BuildKit telemetry from the Deep Agents Code probe.
- [#7665](#7665) ->
`docs/changelog/2026-07-30.mdx`: Records consolidated priority 2 E2E
coverage.
- [#7911](#7911) ->
`docs/changelog/2026-07-30.mdx`: Records the corrected NVIDIA DORI
installation pin.
- [#7934](#7934) ->
`docs/changelog/2026-07-30.mdx`: Records the staging image-family wait
before Brev Launchable deployment.
- [#7772](#7772) ->
`docs/changelog/2026-07-30.mdx`: Records dormant managed-image selection
contracts without activating buildless onboarding.
- [#7941](#7941) ->
`docs/changelog/2026-07-30.mdx`: Records corrected agent-specific
provider and policy guidance.
- [#7819](#7819) ->
`docs/changelog/2026-07-30.mdx`: Records removal of empty Deep Agents
Code provider-switch sections.
- [#7932](#7932) ->
`docs/changelog/2026-07-30.mdx`: Records independent
credential-generation E2E execution.
- [#7840](#7840) ->
`docs/changelog/2026-07-30.mdx`: Records shared-route preservation and
pre-delete peer validation during upgrades.
- [#7874](#7874) ->
`docs/changelog/2026-07-30.mdx`: Records the split between pre-tag
release entries and post-tag Announcements.
- [#7876](#7876) ->
`docs/changelog/2026-07-30.mdx`: Records the writable Hermes runtime
root within lockdown.
- [#7756](#7756) ->
`docs/changelog/2026-07-30.mdx`: Records validated multi-platform
managed-image publication.
- [#7914](#7914) ->
`docs/changelog/2026-07-30.mdx`: Records accepted `uv` version metadata
in Hermes image validation.
- [#7686](#7686) ->
`docs/changelog/2026-07-30.mdx`: Records the explicitly experimental
Microsoft Entra runtime identity reference.
- [#7869](#7869) ->
`docs/changelog/2026-07-30.mdx`: Records classified gateway relaunch
quarantine and rebuild guidance.
- [#7814](#7814) ->
`docs/changelog/2026-07-30.mdx`: Records state restore into replacement
sandboxes and SQLite write verification.
- [#7839](#7839) ->
`docs/changelog/2026-07-30.mdx`: Records quieter onboarding test
execution without a user-facing behavior claim.
- [#7854](#7854) ->
`docs/changelog/2026-07-30.mdx`: Records generalized agent-selection
guidance.
- [#7845](#7845) ->
`docs/changelog/2026-07-30.mdx`: Records isolated CDI test evidence
without a user-facing behavior claim.
- [#7843](#7843) ->
`docs/changelog/2026-07-30.mdx`: Records the corrected Omni sub-agent
model ID.
- [#7908](#7908) ->
`docs/changelog/2026-07-30.mdx`: Records reviewed Hermes and Deep Agents
Code dependency pins.
- [#7887](#7887) ->
`docs/changelog/2026-07-30.mdx`: Records rejection of a symlinked DGX
Station release marker.
- [#7747](#7747) ->
`docs/changelog/2026-07-30.mdx`: Records the internal compute-driver
separation without a user-facing behavior claim.
- [#7660](#7660) ->
`docs/changelog/2026-07-30.mdx`: Records atomic publication of rebuild
recovery manifests.
- [#7661](#7661) ->
`docs/changelog/2026-07-30.mdx`: Records bounded local inference
health-response retention.
- [#7654](#7654) ->
`docs/changelog/2026-07-30.mdx`: Records state preservation across
supervisor relaunch recovery.

## Type of Change

- [ ] Code change (feature, bug fix, or refactor)
- [ ] Code change with doc updates
- [x] Doc only (prose changes, no code sample modifications)
- [ ] Doc only (includes code sample changes)

## Quality Gates

- [ ] Tests added or updated for changed behavior
- [x] Existing tests cover changed behavior — justification:
`test/changelog-docs.test.ts` validates the dated changelog contract,
SPDX comment, version heading, and published routes.
- [ ] Tests not applicable — justification:
- [x] Docs updated for user-facing behavior changes
- [ ] Docs not applicable — justification:
- [ ] Sensitive paths changed (security, policy, credentials, preflight,
onboarding, inference, runner, sandbox, or messaging)
- [ ] Sensitive-path review completed or maintainer-approved waiver
recorded — reviewer/approval link/justification:
- [ ] Non-success, skipped, or missing CI check accepted by maintainer —
check name, approval link, and follow-up issue:

## Documentation Writer Review

- [x] Documentation writer subagent reviewed the completed changes
- Result: `docs-updated`
- Evidence: `docs/changelog/2026-07-30.mdx`; the documentation-only diff
passed review against `WRITING.md`, the controlled word list, and
`docs/CONTRIBUTING.md`. The review covered terminology, structure,
active voice, release meaning, product-scope boundaries, and link and
code presentation. Changelog tests passed 6/6, and the docs build
reported 0 errors with 2 pre-existing warnings.
- Agent: Codex CLI
<!-- docs-review-head-sha: 200940f -->
<!-- docs-review-agents-blob-sha: c052d60 -->

## DGX Station Hardware Evidence

- [ ] Tested on DGX Station
- Tested commit:
- Station profile/scenario:
- Result:
- Supporting evidence:

## Verification

- [x] PR description includes a `Signed-off-by:` line and every commit
appears as `Verified` in GitHub
- [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or
`npm run validate:pr` passed after refreshing `origin/main` when hooks
were skipped or unavailable
- [x] Targeted behavior tests pass for the current change set, or tests
are marked not applicable above — command/result or justification: `npx
vitest run test/changelog-docs.test.ts` passed 6/6 tests.
- [ ] Applicable broad gate passed — `npm test` for broad
runtime/test-harness changes; `npm run check` for repo-wide
validation/coverage changes — command/result: Not applicable to this
documentation-only release entry.
- [x] Quality Gates section completed with required justifications or
waivers
- [x] No secrets, API keys, or credentials committed
- [ ] `npm run docs` builds without warnings (doc changes only) —
result: Build passed with 0 errors and 2 pre-existing warnings.
- [x] Doc pages follow the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md)
(doc changes only)
- [ ] New doc pages include SPDX header and frontmatter (new pages only)

---
Signed-off-by: San Dang <sdang@nvidia.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Added release notes for v0.0.99 covering snapshot restoration, sandbox
recovery, gateway route upgrades, and Hermes security updates.
* Documented experimental Microsoft Entra runtime identity support and
enhanced readiness checks.
* Added details on managed image validation, trusted CI image promotion,
and end-to-end release evidence.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Documentation, examples, guides, or docs build area: packaging Packages, images, registries, installers, or distribution area: security Security controls, permissions, secrets, or hardening bug-fix PR fixes a bug or regression integration: dcode LangChain Deep Code integration behavior integration: hermes Hermes integration behavior security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants