docs(overview): gate 'Messaging channels' to openclaw/hermes variants - #6573
Conversation
Deep Agents is a terminal coding harness with no messaging channel
support ('channels add slack' is hard-rejected), but the Overview
Key Features table lists 'Messaging channels' for all three variants.
- Move the 'Messaging channels' row into an <AgentOnly> block that
renders only for the openclaw and hermes variants.
- Adjust the intro sentence: 'always-on AI agents' for openclaw/hermes,
'AI coding agents' for deepagents.
Both changes use the existing <AgentOnly> component already imported
and used in the same file's Next Steps section.
Fixes NVIDIA#6561
📝 WalkthroughWalkthroughThe overview.mdx page now renders variant-specific intro text with ChangesOverview page variant scoping
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/about/overview.mdx`:
- Line 16: The intro sentence in the overview content currently uses inline
AgentOnly tags, which will not be removed by the variant sync and will leak raw
tags into generated docs. Update the overview text to use block-form AgentOnly
sections, matching the existing variant-specific patterns in the same document,
so scripts/sync-agent-variant-docs.ts can strip them correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: aab3a25e-5943-4dea-bdab-3acd536e447a
📒 Files selected for processing (1)
docs/about/overview.mdx
Address CodeRabbit review: the variant sync script (sync-agent-variant-docs.ts) only strips block-form AgentOnly tags (with newlines around content). Inline tags would leak raw JSX into the generated variant docs. Convert to block-form to match the existing pattern used in the file's Next Steps section.
cjagwani
left a comment
There was a problem hiding this comment.
The docs change is content-correct on cfe14b7f, both commits are GitHub Verified, and the earlier CodeRabbit concern is resolved. Before this can be approved, please add a valid Signed-off-by: Name <email> declaration to the PR description; NemoClaw contributor policy requires both the PR-body DCO declaration and Verified commits. I have released the held fork workflows so CI and the Fern preview can run while you update the description.
|
Trusted manual advisor evidence for exact head |
|
Done — added the DCO |
cjagwani
left a comment
There was a problem hiding this comment.
Approved exact head cfe14b7f468de0abcc850f1e2179409777034a09: the contributor added the required PR-body Signed-off-by: declaration and the fresh DCO/commit-lint runs pass; both commits are Verified; docs checks and Fern preview pass; CodeRabbit is clear; and trusted manual run 29027942518 fetched this exact head with both advisors returning high-confidence merge_as_is, zero findings, all #6561 acceptance clauses met, and all security categories passing. Superseded failed/cancelled fork attempts are historical workflow artifacts, not current failures.
apurvvkumaria
left a comment
There was a problem hiding this comment.
Contributor-compliance changes are required before workflows or merge review can proceed. Both commits are GitHub Verified, but neither commit contains a Signed-off-by trailer, and the PR body lacks the required DCO declaration/current template quality-gate sections. Please rewrite the commits with your own Signed-off-by declaration, keep every rewritten commit GitHub Verified, and update the PR body with the same contributor DCO declaration. The docs diff itself aligns with #6561; this request is specifically for the mandatory contributor-attestation gate.
<!-- markdownlint-disable MD041 --> ## Summary Adds the pre-tag v0.0.79 release notes entry to `docs/about/release-notes.mdx` so the release plan can be generated after docs merge. The entry summarizes the merged v0.0.79 release train across inference, diagnostics, runtime hardening, policies, onboarding recovery, and release validation. ## Changes - Added the v0.0.79 release notes section with linked follow-up documentation for OpenRouter onboarding, managed vLLM changes, completion and logging, Deep Agents runtime limits, policy updates, onboarding recovery, and release validation. - Source summary: - #6461 -> `docs/about/release-notes.mdx`: Documents OpenRouter onboarding support and links to inference/provider references. - #6271 and #6272 -> `docs/about/release-notes.mdx`: Documents shell completion and structured logging highlights. - #6465, #6539, #6570, and #6528 -> `docs/about/release-notes.mdx`: Documents status route-drift, orphaned sandbox, gateway cleanup, and DGX Spark express-install diagnostics. - #6523, #6551, #6484, #6488, #6324, and #6542 -> `docs/about/release-notes.mdx`: Documents managed vLLM, Qwen3.6 tool parser, compaction, and timeout/readiness improvements. - #6559, #6538, #6560, #6568, #6552, #6567, and #6587 -> `docs/about/release-notes.mdx`: Documents runtime, credential, proxy, PID namespace, TOML, and provider-state hardening. - #6541, #5415, #6246, #6496, and #6573 -> `docs/about/release-notes.mdx`: Documents GitHub policy, Gmail policy, MCP allowlist, WhatsApp, and messaging-variant updates. - #6253, #6572, #6444, #6536, and #5860 -> `docs/about/release-notes.mdx`: Documents onboarding resume and create-step recovery improvements. - #6508, #6527, #5506, #6588, #6446, #6447, #6582, #6296, #6367, #6397, and #6505 -> `docs/about/release-notes.mdx`: Documents docs, release-risk, and E2E validation updates. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [x] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates <!-- Check exactly one tests line and one docs line. Check other lines when applicable. Add every requested justification or approval reference. --> - [ ] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [x] Tests not applicable — justification: Release-note prose only. - [x] Docs updated for user-facing behavior changes - [ ] Docs not applicable — justification: - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Verification <!-- Check each applicable item only when supported by the requested evidence. Run targeted tests once per relevant change set and rerun after later edits or hook autofixes that can affect the tested behavior. Do not rerun hook-covered checks. --> - [x] PR description includes the DCO sign-off declaration and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run check:diff` passed when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: Tests not applicable, release-note prose only. - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) Docs validation note: `npm run docs:check-agent-variants && npm run docs:check-routes && git diff --check` passed. Full `npm run docs` is currently blocked before Fern validation because the pinned `fern-api@5.65.2` package is unavailable from npm (`ETARGET No matching version found`). --- <!-- DCO sign-off is required in this PR description, and every commit must appear as Verified in GitHub. Run: git config user.name && git config user.email --> Signed-off-by: Julie Yaunches <jyaunches@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added release notes for v0.0.79 with a new summary of recent improvements, including onboarding and inference options, operator/CLI diagnostics, sandbox recovery hardening, runtime limits, network policy behavior, and release validation updates. * Added updated references and links for the latest release. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…NVIDIA#6573) ## Summary The Overview page's Key Features table lists **Messaging channels** for all three NemoClaw variants, but Deep Agents is a terminal coding harness with no messaging channel support (`channels add slack` is hard-rejected). ## Changes **File:** `docs/about/overview.mdx` 1. **Intro text** — Use inline `<AgentOnly>` to show "always-on AI agents" for openclaw/hermes and "AI coding agents" for deepagents, since Deep Agents is a terminal coding harness rather than an always-on assistant. 2. **Key Features table** — Move the "Messaging channels" row out of the shared table into an `<AgentOnly variant="openclaw,hermes">` block so it only renders for variants that actually support messaging channels. Both changes use the existing `<AgentOnly>` component already imported and used in the same file's Next Steps section. ## Note The messaging channels row renders as a separate single-row table for openclaw/hermes users because MDX doesn't support wrapping individual table rows in JSX components. This is the same approach used in the Next Steps section and is the standard pattern for variant-gated content. Closes NVIDIA#6561 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated the overview page’s main description to vary by product variant (e.g., “always-on AI agents” vs “AI coding agents”). * Adjusted the “Key Features” table ordering so “Routed inference” and “Layered protection” appear earlier. * Made the “Messaging channels” capability row render only for the applicable variants. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- Signed-off-by: Kagura <kagura.agent.ai@gmail.com>
<!-- markdownlint-disable MD041 --> ## Summary Adds the pre-tag v0.0.79 release notes entry to `docs/about/release-notes.mdx` so the release plan can be generated after docs merge. The entry summarizes the merged v0.0.79 release train across inference, diagnostics, runtime hardening, policies, onboarding recovery, and release validation. ## Changes - Added the v0.0.79 release notes section with linked follow-up documentation for OpenRouter onboarding, managed vLLM changes, completion and logging, Deep Agents runtime limits, policy updates, onboarding recovery, and release validation. - Source summary: - NVIDIA#6461 -> `docs/about/release-notes.mdx`: Documents OpenRouter onboarding support and links to inference/provider references. - NVIDIA#6271 and NVIDIA#6272 -> `docs/about/release-notes.mdx`: Documents shell completion and structured logging highlights. - NVIDIA#6465, NVIDIA#6539, NVIDIA#6570, and NVIDIA#6528 -> `docs/about/release-notes.mdx`: Documents status route-drift, orphaned sandbox, gateway cleanup, and DGX Spark express-install diagnostics. - NVIDIA#6523, NVIDIA#6551, NVIDIA#6484, NVIDIA#6488, NVIDIA#6324, and NVIDIA#6542 -> `docs/about/release-notes.mdx`: Documents managed vLLM, Qwen3.6 tool parser, compaction, and timeout/readiness improvements. - NVIDIA#6559, NVIDIA#6538, NVIDIA#6560, NVIDIA#6568, NVIDIA#6552, NVIDIA#6567, and NVIDIA#6587 -> `docs/about/release-notes.mdx`: Documents runtime, credential, proxy, PID namespace, TOML, and provider-state hardening. - NVIDIA#6541, NVIDIA#5415, NVIDIA#6246, NVIDIA#6496, and NVIDIA#6573 -> `docs/about/release-notes.mdx`: Documents GitHub policy, Gmail policy, MCP allowlist, WhatsApp, and messaging-variant updates. - NVIDIA#6253, NVIDIA#6572, NVIDIA#6444, NVIDIA#6536, and NVIDIA#5860 -> `docs/about/release-notes.mdx`: Documents onboarding resume and create-step recovery improvements. - NVIDIA#6508, NVIDIA#6527, NVIDIA#5506, NVIDIA#6588, NVIDIA#6446, NVIDIA#6447, NVIDIA#6582, NVIDIA#6296, NVIDIA#6367, NVIDIA#6397, and NVIDIA#6505 -> `docs/about/release-notes.mdx`: Documents docs, release-risk, and E2E validation updates. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [x] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates <!-- Check exactly one tests line and one docs line. Check other lines when applicable. Add every requested justification or approval reference. --> - [ ] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [x] Tests not applicable — justification: Release-note prose only. - [x] Docs updated for user-facing behavior changes - [ ] Docs not applicable — justification: - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Verification <!-- Check each applicable item only when supported by the requested evidence. Run targeted tests once per relevant change set and rerun after later edits or hook autofixes that can affect the tested behavior. Do not rerun hook-covered checks. --> - [x] PR description includes the DCO sign-off declaration and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run check:diff` passed when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: Tests not applicable, release-note prose only. - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) Docs validation note: `npm run docs:check-agent-variants && npm run docs:check-routes && git diff --check` passed. Full `npm run docs` is currently blocked before Fern validation because the pinned `fern-api@5.65.2` package is unavailable from npm (`ETARGET No matching version found`). --- <!-- DCO sign-off is required in this PR description, and every commit must appear as Verified in GitHub. Run: git config user.name && git config user.email --> Signed-off-by: Julie Yaunches <jyaunches@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added release notes for v0.0.79 with a new summary of recent improvements, including onboarding and inference options, operator/CLI diagnostics, sandbox recovery hardening, runtime limits, network policy behavior, and release validation updates. * Added updated references and links for the latest release. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
The Overview page's Key Features table lists Messaging channels for all three NemoClaw variants, but Deep Agents is a terminal coding harness with no messaging channel support (
channels add slackis hard-rejected).Changes
File:
docs/about/overview.mdxIntro text — Use inline
<AgentOnly>to show "always-on AI agents" for openclaw/hermes and "AI coding agents" for deepagents, since Deep Agents is a terminal coding harness rather than an always-on assistant.Key Features table — Move the "Messaging channels" row out of the shared table into an
<AgentOnly variant="openclaw,hermes">block so it only renders for variants that actually support messaging channels.Both changes use the existing
<AgentOnly>component already imported and used in the same file's Next Steps section.Note
The messaging channels row renders as a separate single-row table for openclaw/hermes users because MDX doesn't support wrapping individual table rows in JSX components. This is the same approach used in the Next Steps section and is the standard pattern for variant-gated content.
Closes #6561
Summary by CodeRabbit
Signed-off-by: Kagura kagura.agent.ai@gmail.com