Skip to content

feat(installer): use managed vLLM as default for DGX Spark express install - #5644

Merged
cv merged 8 commits into
mainfrom
feat/spark-express-default-vllm
Jun 24, 2026
Merged

feat(installer): use managed vLLM as default for DGX Spark express install#5644
cv merged 8 commits into
mainfrom
feat/spark-express-default-vllm

Conversation

@zyang-dev

@zyang-dev zyang-dev commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Switches DGX Spark express install to use managed local vLLM by default instead of Ollama.

Changes

  • Updated DGX Spark express install to configure managed vLLM by default.
  • Updated installer express prompt test expectations for the new Spark vLLM provider/model selection.
  • Updated quickstart, prerequisites/platform matrix, and troubleshooting docs to describe Spark local inference generically.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • PR description includes the DCO sign-off declaration and every commit appears as Verified in GitHub
  • Git hooks passed during commit and push, or npx prek run --from-ref main --to-ref HEAD passes
  • Targeted tests pass for changed behavior
  • Full npm test passes (broad runtime changes only)
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: zyang-dev 267119621+zyang-dev@users.noreply.github.com

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated DGX Spark and DGX Station express install to configure managed local vLLM, adding an explicit local inference disclosure and adjusting unattended exports (including DGX Spark model behavior).
  • Documentation

    • Refreshed DGX Spark prerequisites/quickstart/platform support/troubleshooting and the CI/platform notes to describe an end-to-end walkthrough with local inference (removing the prior “Ollama” phrasing).
  • Tests

    • Added new express-prompt tests covering TTY/no-TTY behavior, model preservation, and platform mapping; updated Vitest/E2E selection and test-size budgeting.

…stall

Signed-off-by: zyang-dev <267119621+zyang-dev@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e7a3fa46-962f-4c9e-accc-7214c6c15efc

📥 Commits

Reviewing files that changed from the base of the PR and between 3ebfcd4 and 3c1dac7.

📒 Files selected for processing (5)
  • ci/platform-matrix.json
  • docs/get-started/prerequisites.mdx
  • docs/get-started/quickstart.mdx
  • docs/reference/platform-support.mdx
  • scripts/install.sh
✅ Files skipped from review due to trivial changes (3)
  • docs/get-started/prerequisites.mdx
  • docs/get-started/quickstart.mdx
  • ci/platform-matrix.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • scripts/install.sh

📝 Walkthrough

Walkthrough

Switches DGX Spark express install to managed vLLM, extracts express-prompt coverage into a dedicated test file, and updates DGX Spark docs and notes to use local inference wording.

Changes

DGX Spark Express Install: Ollama to vLLM

Layer / File(s) Summary
Express install provider switched to vLLM
scripts/install.sh
describe_express_install now uses managed local vLLM for DGX Spark and DGX Station, prints an added disclosure line, and changes DGX Spark acceptance to export NEMOCLAW_PROVIDER=install-vllm with conditional NEMOCLAW_VLLM_MODEL handling.
Express prompt tests moved to a dedicated file
test/install-preflight.test.ts, test/install-express-prompt.test.ts, vitest.config.ts, test/e2e-scenario/support-tests/e2e-live-project-config.test.ts, test/pr-workflow-contract.test.ts, ci/test-file-size-budget.json
Removes the sourced express-install prompt block from install-preflight.test.ts. Adds install-express-prompt.test.ts with PTY-based scenarios for DGX Spark, custom model preservation, WSL detection, Windows WSL mapping, and no-TTY skipping. Updates Vitest wiring, integration gating, contract coverage, and the file-size budget.
DGX Spark notes and walkthrough text updated
ci/platform-matrix.json, docs/get-started/prerequisites.mdx, docs/reference/troubleshooting.mdx, docs/reference/platform-support.mdx, docs/get-started/quickstart.mdx
Rewords DGX Spark notes and walkthrough text from explicit Ollama wording to local inference wording, and adds quickstart text for managed vLLM selection and the DGX Spark default model.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested reviewers

  • cv
  • jyaunches

Poem

🐇 I hopped through Spark with vLLM cheer,
The prompt grew wise, the path stayed clear.
New tests now dance in their tidy nest,
And docs say “local” for the rest.
A twitch of whiskers, a TTY glow,
Off goes Ollama, on with the show!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: DGX Spark express install now defaults to managed vLLM.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/spark-express-default-vllm

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in the feat/spark-express-d... branch is 96%. Coverage data for the main branch is not yet available.

Show a code coverage summary of the most covered files.
File main feat/spark-express-d... 520e852 +/-
nemoclaw/src/se...cret-scanner.ts 100%
nemoclaw/src/commands/slash.ts 100%
nemoclaw/src/li...bprocess-env.ts 100%
nemoclaw/src/bl...eprint/state.ts 98%
nemoclaw/src/onboard/config.ts 98%
nemoclaw/src/bl...int/snapshot.ts 97%
nemoclaw/src/bl...print/runner.ts 95%
nemoclaw/src/co...ration-state.ts 94%
nemoclaw/src/bl...ate-networks.ts 94%
nemoclaw/src/index.ts 94%

TypeScript / code-coverage/cli

The overall coverage in the feat/spark-express-d... branch is 47%. Coverage data for the main branch is not yet available.

Show a code coverage summary of the most covered files.
File main feat/spark-express-d... 520e852 +/-
src/lib/state/o...oard-session.ts 91%
src/lib/inference/local.ts 76%
src/lib/sandbox/config.ts 72%
src/lib/actions...dbox/rebuild.ts 70%
src/lib/onboard/preflight.ts 64%
src/lib/actions...licy-channel.ts 60%
src/lib/state/sandbox.ts 55%
src/lib/onboard...er-gpu-patch.ts 50%
src/lib/policy/index.ts 49%
src/lib/onboard.ts 19%

Updated June 24, 2026 23:30 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings

Merge posture: No blocking advisor findings
Primary next action: Add or justify PRA-T1 and any related test follow-ups.
Open items: 0 required · 0 warnings · 0 suggestions · 2 test follow-ups
Since last review: 0 prior items resolved · 2 still apply · 0 new items found

Action checklist

  • PRA-T1 Add or justify test follow-up: Runtime validation
  • PRA-T2 Add or justify test follow-up: Runtime validation
Test follow-ups to resolve or justify

If these cover changed behavior, prefer adding them in this PR; otherwise state why existing coverage is enough or link the follow-up.

  • PRA-T1 Runtime validation — Add or identify a DGX Station sourced-installer assertion that `describe_express_install "DGX Station"` prints the managed-vLLM image/model pull disclosure while accepting the prompt exports `NEMOCLAW_PROVIDER=install-vllm`.. Static and sourced-installer coverage is strong for the changed shell contract, and existing vLLM tests cover profile-default model resolution. Because the user-visible default can pull an NGC image/model and run a local inference container, targeted runtime validation would still improve confidence in the full installer-to-vLLM path.
  • PRA-T2 Runtime validation — On hardware or CI capable of managed vLLM, validate the full DGX Spark express flow from accepted installer prompt through `installVllm` model resolution, confirming the served model comes from the Spark profile default when `NEMOCLAW_VLLM_MODEL` is unset.. Static and sourced-installer coverage is strong for the changed shell contract, and existing vLLM tests cover profile-default model resolution. Because the user-visible default can pull an NGC image/model and run a local inference container, targeted runtime validation would still improve confidence in the full installer-to-vLLM path.

Workflow run details

This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: spark-install-vitest, cloud-onboard-e2e
Optional E2E: gpu-e2e

Dispatch hint: spark-install-vitest; cloud-onboard-e2e

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

  • spark-install-vitest (medium): This PR changes the installer path and DGX Spark install-facing behavior. The Spark install live scenario is the closest existing E2E for the install.sh/public install boundary and post-install CLI/OpenShell usability.
  • cloud-onboard-e2e (high): The installer now exports a different provider for express non-interactive onboarding and still feeds into the full onboard flow. Run the hosted full onboarding E2E to verify installer/onboard integration, sandbox creation, provider registration, and policy application still work end-to-end.

Optional E2E

  • gpu-e2e (high): Optional confidence for adjacent GPU/local-inference onboarding. It still covers the existing Ollama GPU path rather than the new DGX Spark vLLM express path, so it is useful but not a direct blocker for this PR.

New E2E recommendations

  • DGX Spark express managed vLLM onboarding (high): No existing E2E appears to exercise interactive DGX Spark express acceptance through install.sh into a managed vLLM onboard. Existing spark-install-vitest forces NEMOCLAW_NON_INTERACTIVE/provider=cloud, and gpu-e2e covers Ollama rather than vLLM.
    • Suggested test: Add a live DGX Spark express-vLLM scenario that simulates DGX Spark detection, accepts the express prompt, verifies NEMOCLAW_PROVIDER=install-vllm reaches onboarding, starts or validates the managed vLLM route, and proves inference.local from the sandbox.

Dispatch hint

  • Workflow: .github/workflows/e2e-vitest-scenarios.yaml and .github/workflows/nightly-e2e.yaml
  • jobs input: spark-install-vitest; cloud-onboard-e2e

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Vitest E2E Scenario Recommendation

Required Vitest E2E scenarios: spark-install-vitest
Optional Vitest E2E scenarios: gpu-e2e-vitest

Dispatch required Vitest E2E scenarios:

  • gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref> --field jobs=spark-install-vitest

Workflow run

Full Vitest E2E advisor summary

Vitest E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: medium

Required Vitest E2E scenarios

  • spark-install-vitest: The PR changes the installer Spark/DGX express-install behavior and the Vitest project gating around installer integration. The wired free-standing Spark install Vitest job is the closest live Vitest scenario dispatch for the installer/Spark install boundary.
    • Dispatch: gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref> --field jobs=spark-install-vitest

Optional Vitest E2E scenarios

  • gpu-e2e-vitest: Optional adjacent GPU/local-inference coverage for the DGX Spark managed-local-inference change. This is a special-runner GPU job and does not directly exercise the new Spark vLLM express prompt, so it is not required.
    • Dispatch: gh workflow run e2e-vitest-scenarios.yaml --ref <pr-head-ref> --field jobs=gpu-e2e-vitest

Relevant changed files

  • scripts/install.sh
  • test/e2e-scenario/support-tests/e2e-live-project-config.test.ts
  • vitest.config.ts

@wscurran wscurran added area: docs Documentation, examples, guides, or docs build area: install Install, setup, prerequisites, or uninstall flow feature PR adds or expands user-visible functionality platform: dgx-spark Affects DGX Spark hardware or workflows provider: vllm vLLM local or hosted provider behavior labels Jun 23, 2026
Signed-off-by: zyang-dev <267119621+zyang-dev@users.noreply.github.com>
Signed-off-by: zyang-dev <267119621+zyang-dev@users.noreply.github.com>
…ainer

Signed-off-by: zyang-dev <267119621+zyang-dev@users.noreply.github.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
test/install-express-prompt.test.ts (1)

192-194: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Document the platform-specific skip.

The test skips on macOS without explanation. Add a brief comment explaining why (likely because setsid behavior differs or is unavailable on macOS).

📝 Suggested documentation
  it("skips express install without a controlling TTY", () => {
+   // setsid is Linux-specific; macOS lacks equivalent TTY detachment
    if (process.platform === "darwin") {
      return;
    }

Additionally, the CI "Codebase Growth Guardrails" pipeline flagged this conditional. Please confirm this platform-specific skip is acceptable or adjust the guardrail threshold.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/install-express-prompt.test.ts` around lines 192 - 194, The
platform-specific skip condition in the test that checks for `process.platform
=== "darwin"` lacks documentation explaining the reason for the skip. Add a
comment above this conditional block explaining why the test is skipped on
macOS, specifically noting that setsid behavior differs or is unavailable on
that platform. This will clarify the intent and help address the CI guardrail
concern about the conditional.

Source: Pipeline failures

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@test/install-express-prompt.test.ts`:
- Around line 192-194: The platform-specific skip condition in the test that
checks for `process.platform === "darwin"` lacks documentation explaining the
reason for the skip. Add a comment above this conditional block explaining why
the test is skipped on macOS, specifically noting that setsid behavior differs
or is unavailable on that platform. This will clarify the intent and help
address the CI guardrail concern about the conditional.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 91347b82-2ed0-47ae-a8af-fcac087cdbd4

📥 Commits

Reviewing files that changed from the base of the PR and between 75a49cb and a9b17b3.

📒 Files selected for processing (7)
  • ci/test-file-size-budget.json
  • scripts/install.sh
  • test/e2e-scenario/support-tests/e2e-live-project-config.test.ts
  • test/install-express-prompt.test.ts
  • test/install-preflight.test.ts
  • test/pr-workflow-contract.test.ts
  • vitest.config.ts
💤 Files with no reviewable changes (1)
  • test/install-preflight.test.ts
✅ Files skipped from review due to trivial changes (2)
  • ci/test-file-size-budget.json
  • test/pr-workflow-contract.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • scripts/install.sh

Signed-off-by: zyang-dev <267119621+zyang-dev@users.noreply.github.com>
Signed-off-by: zyang-dev <267119621+zyang-dev@users.noreply.github.com>
@zyang-dev

Copy link
Copy Markdown
Contributor Author

Responses to PR review advisor:

  • PRA-1: justified/deferred. docs/ is the source of truth for user-facing docs, and this PR updates the source docs plus platform matrix. Per docs/CONTRIBUTING.md, normal contributor PRs should not commit regenerated nemoclaw-user-* skill artifacts; maintainers refresh generated skills during release prep. I’m accepting the generated-skill drift in this PR under that documented workflow.

  • PRA-2: justified/deferred for the same reason as PRA-1. The stale generated skills/ and .agents/skills/ references are generated artifacts. I’m leaving them untouched here and relying on the documented release-prep regeneration path.

  • PRA-T1: justified/deferred. A generated-skill freshness/content gate for DGX Spark docs would be a broader docs tooling change. This PR updates the source docs and platform matrix; generated skill freshness is handled by the existing docs-to-skills workflow during release prep.

  • PRA-T2: addressed. test/install-express-prompt.test.ts covers Spark express with no preset NEMOCLAW_VLLM_MODEL, asserting PROVIDER=install-vllm and VLLM_MODEL= remains empty so the TypeScript Spark vLLM profile default is used. The same file also covers explicit model preservation with preset NEMOCLAW_VLLM_MODEL.

  • PRA-T3: justified/deferred. The source docs and platform matrix were updated in this PR; generated assistant-facing skills are intentionally not regenerated here per docs/CONTRIBUTING.md. Maintainers refresh generated user skills during release prep.

  • PRA-T4: justified/deferred. A stricter docs-to-skills freshness/content validation for DGX Spark source-doc changes would be useful, but it is outside this installer behavior PR. This PR follows the current documented workflow: update docs/ as source of truth and defer generated skills to release prep.

…fault-vllm

# Conflicts:
#	docs/get-started/prerequisites.mdx

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/reference/platform-support.mdx`:
- Line 175: The shared docs example in the platform support content uses a
concrete command alias instead of the shared CLI placeholder. Update the
`nemoclaw <name> connect` reference in this section to use `$$nemoclaw` so
generated variants render the correct command name consistently across shared
pages.
- Line 12: The source text in the platform support reference has multiple
sentences on a single line, which violates the one-sentence-per-line docs rule.
Update the canonical copy in the referenced MDX content so each sentence is
placed on its own line, preserving the same wording and meaning while splitting
the combined sentence in the introductory description into separate lines.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e7a3fa46-962f-4c9e-accc-7214c6c15efc

📥 Commits

Reviewing files that changed from the base of the PR and between 3ebfcd4 and 3c1dac7.

📒 Files selected for processing (5)
  • ci/platform-matrix.json
  • docs/get-started/prerequisites.mdx
  • docs/get-started/quickstart.mdx
  • docs/reference/platform-support.mdx
  • scripts/install.sh
✅ Files skipped from review due to trivial changes (3)
  • docs/get-started/prerequisites.mdx
  • docs/get-started/quickstart.mdx
  • ci/platform-matrix.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • scripts/install.sh

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/reference/platform-support.mdx`:
- Line 175: The shared docs example in the platform support content uses a
concrete command alias instead of the shared CLI placeholder. Update the
`nemoclaw <name> connect` reference in this section to use `$$nemoclaw` so
generated variants render the correct command name consistently across shared
pages.
- Line 12: The source text in the platform support reference has multiple
sentences on a single line, which violates the one-sentence-per-line docs rule.
Update the canonical copy in the referenced MDX content so each sentence is
placed on its own line, preserving the same wording and meaning while splitting
the combined sentence in the introductory description into separate lines.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e7a3fa46-962f-4c9e-accc-7214c6c15efc

📥 Commits

Reviewing files that changed from the base of the PR and between 3ebfcd4 and 3c1dac7.

📒 Files selected for processing (5)
  • ci/platform-matrix.json
  • docs/get-started/prerequisites.mdx
  • docs/get-started/quickstart.mdx
  • docs/reference/platform-support.mdx
  • scripts/install.sh
✅ Files skipped from review due to trivial changes (3)
  • docs/get-started/prerequisites.mdx
  • docs/get-started/quickstart.mdx
  • ci/platform-matrix.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • scripts/install.sh
🛑 Comments failed to post (2)
docs/reference/platform-support.mdx (2)

12-12: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Split this into one sentence per source line.

Line 12 contains two sentences on one line, which violates the docs source formatting rule.

As per coding guidelines, “Keep one sentence per line in Markdown and MDX source files,” and as per path instructions, “One sentence per line in source.”

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/reference/platform-support.mdx` at line 12, The source text in the
platform support reference has multiple sentences on a single line, which
violates the one-sentence-per-line docs rule. Update the canonical copy in the
referenced MDX content so each sentence is placed on its own line, preserving
the same wording and meaning while splitting the combined sentence in the
introductory description into separate lines.

Sources: Coding guidelines, Path instructions


175-175: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Use the shared CLI placeholder instead of a concrete alias.

Line 175 uses nemoclaw <name> connect; for shared docs command examples, use $$nemoclaw so generated variants render the correct command name.

As per path instructions, command examples on shared pages should use $$nemoclaw rather than concrete aliases.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/reference/platform-support.mdx` at line 175, The shared docs example in
the platform support content uses a concrete command alias instead of the shared
CLI placeholder. Update the `nemoclaw <name> connect` reference in this section
to use `$$nemoclaw` so generated variants render the correct command name
consistently across shared pages.

Source: Path instructions

@cv
cv enabled auto-merge (squash) June 24, 2026 23:25
@cv
cv merged commit 8823ed4 into main Jun 24, 2026
42 checks passed
@cv
cv deleted the feat/spark-express-default-vllm branch June 24, 2026 23:30
@miyoungc miyoungc mentioned this pull request Jun 25, 2026
21 tasks
cv pushed a commit that referenced this pull request Jun 25, 2026
<!-- markdownlint-disable MD041 -->
## Summary
Refreshes the v0.0.68 docs with release notes, Microsoft Teams messaging
guidance, and generated support-matrix coverage.
Also corrects the Hermes generated command reference so `sessions
export` examples match Hermes-only behavior while keeping the shared
command heading compatible with CLI parity checks.

## Changes
- #5585 -> `docs/manage-sandboxes/messaging-channels.mdx`,
`docs/reference/platform-support.mdx`: Documents experimental Microsoft
Teams channel setup, Bot Framework credentials, webhook forwarding,
local `MSTEAMS_PORT` conflicts, and the generated integration support
row.
- #5526 -> `docs/reference/commands.mdx`,
`docs/reference/commands-nemohermes.mdx`: Keeps Hermes `sessions export`
examples on the supported single-JSONL export path while preserving the
canonical shared CLI heading.
- #5044 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for installer onboarding failure propagation.
- #5641 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for fresh recovery after pre-sandbox installer interruption.
- #5673 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for explicit deny-all messaging manifests.
- #5743 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for unsupported-agent channel-add rejection.
- #5252 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for Hermes `gateway-token` dashboard guidance.
- #5659 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for local OpenClaw `agent` wrapper help.
- #5661 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for default extra-agent paths.
- #5669 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for Deep Agents Code branding.
- #5672 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for hosted-compatible default model ID preservation.
- #5725 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for Deep Agents Code sandbox liveness.
- #5644 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for DGX Spark managed-vLLM express install defaults.
- #5712 -> `docs/about/release-notes.mdx`,
`docs/reference/platform-support.mdx`: Adds v0.0.68 release-note
coverage for the canonical support matrix and updates the matrix source
with Teams.

## Type of Change

- [ ] Code change (feature, bug fix, or refactor)
- [ ] Code change with doc updates
- [ ] Doc only (prose changes, no code sample modifications)
- [x] Doc only (includes code sample changes)

## Quality Gates
<!-- Check all that apply. For any "covered by existing tests", "not
applicable", or waiver entry, add a brief justification on the same line
or in the Changes section. -->
- [ ] Tests added or updated for changed behavior
- [ ] Existing tests cover changed behavior — justification:
- [x] Tests not applicable — justification: docs-only release refresh;
no runtime code changed.
- [x] Docs updated for user-facing behavior changes
- [ ] Docs not applicable — justification:
- [ ] Sensitive paths changed (security, policy, credentials, preflight,
onboarding, inference, runner, sandbox, or messaging)
- [ ] Sensitive-path review completed or maintainer-approved waiver
recorded — reviewer/approval link/justification:
- [ ] Non-success, skipped, or missing CI check accepted by maintainer —
check name, approval link, and follow-up issue:

## Verification
<!-- Check each item you ran and confirmed. Leave unchecked items you
skipped. Doc-only changes do not require npm test unless you ran it. -->
- [x] PR description includes the DCO sign-off declaration and every
commit appears as `Verified` in GitHub
- [x] Git hooks passed during commit and push, or `npx prek run
--from-ref main --to-ref HEAD` passes
- [ ] Targeted tests pass for changed behavior
- [ ] Full `npm test` passes (broad runtime changes only)
- [x] Quality Gates section completed with required justifications or
waivers
- [x] No secrets, API keys, or credentials committed
- [ ] `npm run docs` builds without warnings (doc changes only) — `npm
run docs` passed with 0 errors; Fern reported the existing light-mode
accent contrast warning.
- [x] Doc pages follow the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md)
(doc changes only)
- [ ] New doc pages include SPDX header and frontmatter (new pages only)

Additional verification:
- `python3 scripts/generate-platform-docs.py --check` passed.
- `npm run docs:sync-agent-variants` passed.
- `bash test/e2e/e2e-cloud-experimental/check-docs.sh --only-cli`
passed.
- `npm run docs` passed with 0 errors and one Fern theme warning:
light-mode accent contrast ratio is 2.41:1 and should be at least 3:1.
- `npm run build:cli` refreshed local untracked `dist/` artifacts after
rebase; no tracked files changed.
- `npm run typecheck:cli` passed.
- Normal commit and push hooks passed after the local CLI rebuild.

---
<!-- DCO sign-off is required in this PR description, and every commit
must appear as Verified in GitHub. Run: git config user.name && git
config user.email -->
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Added **Microsoft Teams** as an experimental messaging channel,
including manifest-first onboarding, local port routing/conflict
handling, sandbox delivery controls, and policy preset support.

* **Documentation**
* Expanded messaging-channel setup for Teams (prerequisites,
credential/webhook setup, wizard flow, and add/remove commands).
* Updated reference docs for **agent-specific** session export examples
(OpenClaw vs Hermes).
* Refreshed platform support guidance and added the latest release-notes
entry.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Hadar301 pushed a commit to Hadar301/NemoClaw-OpenShift that referenced this pull request Jul 12, 2026
…stall (NVIDIA#5644)

<!-- markdownlint-disable MD041 -->
## Summary
<!-- 1-3 sentences: what this PR does and why. -->
Switches DGX Spark express install to use managed local vLLM by default
instead of Ollama.

## Changes
<!-- Bullet list of key changes. -->
- Updated DGX Spark express install to configure managed vLLM by
default.
- Updated installer express prompt test expectations for the new Spark
vLLM provider/model selection.
- Updated quickstart, prerequisites/platform matrix, and troubleshooting
docs to describe Spark local inference generically.

## Type of Change

- [x] Code change (feature, bug fix, or refactor)
- [x] Code change with doc updates
- [ ] Doc only (prose changes, no code sample modifications)
- [ ] Doc only (includes code sample changes)

## Verification
<!-- Check each item you ran and confirmed. Leave unchecked items you
skipped. Doc-only changes do not require npm test unless you ran it. -->
- [x] PR description includes the DCO sign-off declaration and every
commit appears as `Verified` in GitHub
- [x] Git hooks passed during commit and push, or `npx prek run
--from-ref main --to-ref HEAD` passes
- [x] Targeted tests pass for changed behavior
- [ ] Full `npm test` passes (broad runtime changes only)
- [x] Tests added or updated for new or changed behavior
- [x] No secrets, API keys, or credentials committed
- [x] Docs updated for user-facing behavior changes
- [ ] `npm run docs` builds without warnings (doc changes only)
- [x] Doc pages follow the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md)
(doc changes only)
- [ ] New doc pages include SPDX header and frontmatter (new pages only)

---
<!-- DCO sign-off is required in this PR description, and every commit
must appear as Verified in GitHub. Run: git config user.name && git
config user.email -->
Signed-off-by: zyang-dev <267119621+zyang-dev@users.noreply.github.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

* **Chores**
* Updated **DGX Spark** and **DGX Station** express install to configure
**managed local vLLM**, adding an explicit local inference disclosure
and adjusting unattended exports (including DGX Spark model behavior).

* **Documentation**
* Refreshed **DGX Spark** prerequisites/quickstart/platform
support/troubleshooting and the CI/platform notes to describe an
end-to-end walkthrough **with local inference** (removing the prior
“Ollama” phrasing).

* **Tests**
* Added new express-prompt tests covering TTY/no-TTY behavior, model
preservation, and platform mapping; updated Vitest/E2E selection and
test-size budgeting.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: zyang-dev <267119621+zyang-dev@users.noreply.github.com>
Co-authored-by: Carlos Villela <cvillela@nvidia.com>
Hadar301 pushed a commit to Hadar301/NemoClaw-OpenShift that referenced this pull request Jul 12, 2026
<!-- markdownlint-disable MD041 -->
## Summary
Refreshes the v0.0.68 docs with release notes, Microsoft Teams messaging
guidance, and generated support-matrix coverage.
Also corrects the Hermes generated command reference so `sessions
export` examples match Hermes-only behavior while keeping the shared
command heading compatible with CLI parity checks.

## Changes
- NVIDIA#5585 -> `docs/manage-sandboxes/messaging-channels.mdx`,
`docs/reference/platform-support.mdx`: Documents experimental Microsoft
Teams channel setup, Bot Framework credentials, webhook forwarding,
local `MSTEAMS_PORT` conflicts, and the generated integration support
row.
- NVIDIA#5526 -> `docs/reference/commands.mdx`,
`docs/reference/commands-nemohermes.mdx`: Keeps Hermes `sessions export`
examples on the supported single-JSONL export path while preserving the
canonical shared CLI heading.
- NVIDIA#5044 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for installer onboarding failure propagation.
- NVIDIA#5641 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for fresh recovery after pre-sandbox installer interruption.
- NVIDIA#5673 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for explicit deny-all messaging manifests.
- NVIDIA#5743 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for unsupported-agent channel-add rejection.
- NVIDIA#5252 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for Hermes `gateway-token` dashboard guidance.
- NVIDIA#5659 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for local OpenClaw `agent` wrapper help.
- NVIDIA#5661 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for default extra-agent paths.
- NVIDIA#5669 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for Deep Agents Code branding.
- NVIDIA#5672 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for hosted-compatible default model ID preservation.
- NVIDIA#5725 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for Deep Agents Code sandbox liveness.
- NVIDIA#5644 -> `docs/about/release-notes.mdx`: Adds v0.0.68 release-note
coverage for DGX Spark managed-vLLM express install defaults.
- NVIDIA#5712 -> `docs/about/release-notes.mdx`,
`docs/reference/platform-support.mdx`: Adds v0.0.68 release-note
coverage for the canonical support matrix and updates the matrix source
with Teams.

## Type of Change

- [ ] Code change (feature, bug fix, or refactor)
- [ ] Code change with doc updates
- [ ] Doc only (prose changes, no code sample modifications)
- [x] Doc only (includes code sample changes)

## Quality Gates
<!-- Check all that apply. For any "covered by existing tests", "not
applicable", or waiver entry, add a brief justification on the same line
or in the Changes section. -->
- [ ] Tests added or updated for changed behavior
- [ ] Existing tests cover changed behavior — justification:
- [x] Tests not applicable — justification: docs-only release refresh;
no runtime code changed.
- [x] Docs updated for user-facing behavior changes
- [ ] Docs not applicable — justification:
- [ ] Sensitive paths changed (security, policy, credentials, preflight,
onboarding, inference, runner, sandbox, or messaging)
- [ ] Sensitive-path review completed or maintainer-approved waiver
recorded — reviewer/approval link/justification:
- [ ] Non-success, skipped, or missing CI check accepted by maintainer —
check name, approval link, and follow-up issue:

## Verification
<!-- Check each item you ran and confirmed. Leave unchecked items you
skipped. Doc-only changes do not require npm test unless you ran it. -->
- [x] PR description includes the DCO sign-off declaration and every
commit appears as `Verified` in GitHub
- [x] Git hooks passed during commit and push, or `npx prek run
--from-ref main --to-ref HEAD` passes
- [ ] Targeted tests pass for changed behavior
- [ ] Full `npm test` passes (broad runtime changes only)
- [x] Quality Gates section completed with required justifications or
waivers
- [x] No secrets, API keys, or credentials committed
- [ ] `npm run docs` builds without warnings (doc changes only) — `npm
run docs` passed with 0 errors; Fern reported the existing light-mode
accent contrast warning.
- [x] Doc pages follow the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md)
(doc changes only)
- [ ] New doc pages include SPDX header and frontmatter (new pages only)

Additional verification:
- `python3 scripts/generate-platform-docs.py --check` passed.
- `npm run docs:sync-agent-variants` passed.
- `bash test/e2e/e2e-cloud-experimental/check-docs.sh --only-cli`
passed.
- `npm run docs` passed with 0 errors and one Fern theme warning:
light-mode accent contrast ratio is 2.41:1 and should be at least 3:1.
- `npm run build:cli` refreshed local untracked `dist/` artifacts after
rebase; no tracked files changed.
- `npm run typecheck:cli` passed.
- Normal commit and push hooks passed after the local CLI rebuild.

---
<!-- DCO sign-off is required in this PR description, and every commit
must appear as Verified in GitHub. Run: git config user.name && git
config user.email -->
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Added **Microsoft Teams** as an experimental messaging channel,
including manifest-first onboarding, local port routing/conflict
handling, sandbox delivery controls, and policy preset support.

* **Documentation**
* Expanded messaging-channel setup for Teams (prerequisites,
credential/webhook setup, wizard flow, and add/remove commands).
* Updated reference docs for **agent-specific** session export examples
(OpenClaw vs Hermes).
* Refreshed platform support guidance and added the latest release-notes
entry.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Documentation, examples, guides, or docs build area: install Install, setup, prerequisites, or uninstall flow feature PR adds or expands user-visible functionality platform: dgx-spark Affects DGX Spark hardware or workflows provider: vllm vLLM local or hosted provider behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants