-
Notifications
You must be signed in to change notification settings - Fork 3.1k
chore(release): document tag-based workflow #5545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ebcaed3
chore(release): document tag-based workflow
cv 05c5b3d
Merge remote-tracking branch 'origin/main' into chore/tag-based-relea…
cv 8f92a0a
fix(release): address review feedback
cv 8e439bc
test(e2e): extend workflow selector timeout
cv da30ffe
fix(release): keep bump-version tag-only
cv 9daf6e8
test(e2e): use timeout helper for selector test
cv 33e571c
fix(release): fail fast on housekeeping errors
cv 547a46e
test(release): cover bump-version push contract
cv 0901a6d
test(release): cover straggler failure paths
cv 31c3c81
test(release): cover straggler edge cases
cv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| <!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> | ||
| <!-- SPDX-License-Identifier: Apache-2.0 --> | ||
|
|
||
| # Git and GitHub Access Hard Stop | ||
|
|
||
| Use this guardrail from any workflow that runs `git`, `ssh`, or `gh` commands. | ||
|
|
||
| If a Git/GitHub command fails because of authentication, authorization, missing credentials, SSO, token scope, SSH key setup, remote access, or push permissions, stop and ask the user to resolve access. | ||
|
|
||
| Do **not** work around access failures by: | ||
|
|
||
| - switching remote protocols or remotes; | ||
| - editing credentials, tokens, or SSH config; | ||
| - generating new tokens or SSH keys; | ||
| - rewriting remotes to bypass permissions; | ||
| - force-pushing or bypassing branch protections/required checks. | ||
|
|
||
| Report the exact command, the relevant error output, and the next action needed from the user, then wait. | ||
|
|
||
| This hard stop is for access/authentication/authorization problems only. Normal Git workflow problems such as merge conflicts, stale branches, dirty worktrees, or mechanical rebase conflicts should be handled by the relevant workflow. Stop for user guidance only when conflict resolution would change behavior, alter contributor intent, or require a design decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| <!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> | ||
| <!-- SPDX-License-Identifier: Apache-2.0 --> | ||
|
|
||
| # PR CI and Automated Review Follow-Up | ||
|
|
||
| Use this workflow after creating a PR and after every push to an open PR. | ||
|
|
||
| ## Watch checks | ||
|
|
||
| ```bash | ||
| PR_NUMBER=${PR_NUMBER:-$(gh pr view --json number -q .number)} | ||
| gh pr checks "$PR_NUMBER" --watch | ||
| ``` | ||
|
|
||
| Then inspect the settled check state: | ||
|
|
||
| ```bash | ||
| gh pr view "$PR_NUMBER" --json url,statusCheckRollup,comments,reviews,reviewDecision | ||
| ``` | ||
|
|
||
| ## Inspect automated feedback | ||
|
|
||
| Check sticky PR comments and inline review comments from CodeRabbit and the PR Review Advisor: | ||
|
|
||
| ```bash | ||
| gh api "repos/NVIDIA/NemoClaw/issues/${PR_NUMBER}/comments" --paginate \ | ||
| --jq '.[] | select((.body // "") | test("CodeRabbit|coderabbit|PR Review Advisor|nemoclaw-pr-review-advisor"; "i")) | {author: .user.login, updated_at, body}' | ||
|
|
||
| gh api "repos/NVIDIA/NemoClaw/pulls/${PR_NUMBER}/comments" --paginate \ | ||
| --jq '.[] | select((.body // "") | test("CodeRabbit|coderabbit|PR Review Advisor|nemoclaw-pr-review-advisor"; "i")) | {author: .user.login, path, line, updated_at, body}' | ||
| ``` | ||
|
|
||
| ## Triage | ||
|
|
||
| - **CI failure:** inspect the failing job logs, fix the root cause, rerun relevant local checks, commit, push, and monitor again. | ||
| - **CodeRabbit or PR Review Advisor correctness/security/test-coverage finding:** address it when valid, rerun relevant checks, commit, push, and monitor again. | ||
| - **Style nits or false positives:** avoid unnecessary churn. Note the rationale in your final report or comment on the PR when reviewer-visible context is useful. | ||
| - **Ambiguous, risky, broad, or design-changing feedback:** stop and consult the user before changing code. | ||
|
|
||
| Repeat until required CI is green and there are no unresolved actionable CodeRabbit or PR Review Advisor findings, or until the user tells you to stop. | ||
|
|
||
| If any follow-up push or `gh`/GitHub query hits SSH, authentication, remote access, authorization, or permission problems, follow [Git and GitHub Access Hard Stop](git-github-hard-stop.md). Do not stop for ordinary merge conflicts or dirty-worktree state; resolve mechanical conflicts in the relevant workflow and ask the user only when resolution would change behavior or contributor intent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add SPDX license header to the file.
All Markdown files must include an SPDX license header as the first content. For Markdown, use HTML comments.
📝 Proposed fix
🤖 Prompt for AI Agents
Source: Coding guidelines