chore(release): document tag-based workflow - #5545
Merged
Merged
Conversation
cv
added
area: docs
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds two new shared agent guardrail documents for Git/GitHub authentication hard stops and PR CI/review follow-up, then integrates both across ChangesAgent Workflow Guardrails and Skill Integration
bump-version.ts PR-Mode Removal and E2E Test Timeout
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (5)
.agents/skills/nemoclaw-maintainer-day/SECURITY-SWEEP.md (1)
1-1:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winAdd SPDX license header to the file.
All Markdown files must include an SPDX license header as the first content. For Markdown, use HTML comments.
📝 Proposed fix
+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> +<!-- SPDX-License-Identifier: Apache-2.0 --> + # Security Sweep Workflow🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.agents/skills/nemoclaw-maintainer-day/SECURITY-SWEEP.md at line 1, The SECURITY-SWEEP.md file is missing the required SPDX license header at the beginning. Add an SPDX license header as the very first content of the file using HTML comment syntax (<!-- and -->) since this is a Markdown file. The header should appear before the existing "# Security Sweep Workflow" line to comply with the licensing requirements.Source: Coding guidelines
.agents/skills/nemoclaw-maintainer-evening/SKILL.md (1)
1-1:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winAdd SPDX license header to the file.
All Markdown files must include an SPDX license header as the first content. For Markdown, use HTML comments.
📝 Proposed fix
+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> +<!-- SPDX-License-Identifier: Apache-2.0 --> + # NemoClaw Maintainer Evening🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.agents/skills/nemoclaw-maintainer-evening/SKILL.md at line 1, The SPDX license header is missing from the SKILL.md Markdown file. Add an SPDX license header as the first content in the file using HTML comment syntax (<!-- SPDX-License-Identifier: [appropriate license identifier] -->) before any other content in the file. This header should be placed at the very top of the document to comply with the project's licensing requirements for Markdown files.Source: Coding guidelines
.agents/skills/nemoclaw-maintainer-day/SALVAGE-PR.md (1)
1-1:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winAdd SPDX license header to the file.
All Markdown files must include an SPDX license header as the first content. For Markdown, use HTML comments.
📝 Proposed fix
+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> +<!-- SPDX-License-Identifier: Apache-2.0 --> + # Salvage PR Workflow🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.agents/skills/nemoclaw-maintainer-day/SALVAGE-PR.md at line 1, Add an SPDX license header to the beginning of the SALVAGE-PR.md file before the existing content that starts with "# Salvage PR Workflow". The header must be formatted as an HTML comment using the format <!-- SPDX-License-Identifier: [license-type] --> and placed as the very first line of the file. This ensures compliance with the project's licensing requirements for all Markdown files.Source: Coding guidelines
.agents/skills/nemoclaw-skills-guide/SKILL.md (1)
1-1:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winAdd SPDX license header to the file.
All Markdown files must include an SPDX license header as the first content. For Markdown, use HTML comments.
📝 Proposed fix
+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> +<!-- SPDX-License-Identifier: Apache-2.0 --> + # NemoClaw Skills Guide🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.agents/skills/nemoclaw-skills-guide/SKILL.md at line 1, The SKILL.md Markdown file is missing the required SPDX license header at the beginning. Add an SPDX license header as the first line of the file using HTML comment syntax (enclosed in <!-- and -->). This header must appear before any other content in the file, including the YAML frontmatter (---) or any other Markdown content. Ensure the license identifier is properly formatted within the HTML comment.Source: Coding guidelines
tools/pr-review-advisor/README.md (1)
1-1:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winAdd SPDX license header to the file.
All Markdown files must include an SPDX license header as the first content. For Markdown, use HTML comments.
📝 Proposed fix
+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> +<!-- SPDX-License-Identifier: Apache-2.0 --> + # PR Review Advisor🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tools/pr-review-advisor/README.md` at line 1, The README.md file is missing the required SPDX license header at the beginning. Add the SPDX license header as an HTML comment as the very first line of the file in README.md, using the format shown in the diff: an HTML comment containing the SPDX-FileCopyrightText declaration with the copyright information for NVIDIA CORPORATION & AFFILIATES. This header must appear before any other content in the Markdown file.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/nemoclaw-maintainer-cut-release-tag/SKILL.md:
- Line 1: The SKILL.md file is missing the required SPDX license header at the
beginning. Add an SPDX license header as the very first line of the file using
HTML comment syntax (format: <!-- SPDX-License-Identifier: [LICENSE] -->) before
any other content, including the existing `---` marker. This ensures the file
complies with the licensing requirements for all Markdown files.
In `@scripts/bump-version.ts`:
- Around line 122-127: The git push operations in the bump-version.ts file are
executing separately, which can cause inconsistency if one push fails after
another succeeds. Replace the three separate git calls (pushing HEAD, then the
tagName, then latest) with a single atomic git push command that includes all
three refs (HEAD, tagName, and latest with the --force flag) in one operation to
ensure all or nothing are published together.
---
Outside diff comments:
In @.agents/skills/nemoclaw-maintainer-day/SALVAGE-PR.md:
- Line 1: Add an SPDX license header to the beginning of the SALVAGE-PR.md file
before the existing content that starts with "# Salvage PR Workflow". The header
must be formatted as an HTML comment using the format <!--
SPDX-License-Identifier: [license-type] --> and placed as the very first line of
the file. This ensures compliance with the project's licensing requirements for
all Markdown files.
In @.agents/skills/nemoclaw-maintainer-day/SECURITY-SWEEP.md:
- Line 1: The SECURITY-SWEEP.md file is missing the required SPDX license header
at the beginning. Add an SPDX license header as the very first content of the
file using HTML comment syntax (<!-- and -->) since this is a Markdown file. The
header should appear before the existing "# Security Sweep Workflow" line to
comply with the licensing requirements.
In @.agents/skills/nemoclaw-maintainer-evening/SKILL.md:
- Line 1: The SPDX license header is missing from the SKILL.md Markdown file.
Add an SPDX license header as the first content in the file using HTML comment
syntax (<!-- SPDX-License-Identifier: [appropriate license identifier] -->)
before any other content in the file. This header should be placed at the very
top of the document to comply with the project's licensing requirements for
Markdown files.
In @.agents/skills/nemoclaw-skills-guide/SKILL.md:
- Line 1: The SKILL.md Markdown file is missing the required SPDX license header
at the beginning. Add an SPDX license header as the first line of the file using
HTML comment syntax (enclosed in <!-- and -->). This header must appear before
any other content in the file, including the YAML frontmatter (---) or any other
Markdown content. Ensure the license identifier is properly formatted within the
HTML comment.
In `@tools/pr-review-advisor/README.md`:
- Line 1: The README.md file is missing the required SPDX license header at the
beginning. Add the SPDX license header as an HTML comment as the very first line
of the file in README.md, using the format shown in the diff: an HTML comment
containing the SPDX-FileCopyrightText declaration with the copyright information
for NVIDIA CORPORATION & AFFILIATES. This header must appear before any other
content in the Markdown file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ff6dfa05-08f7-4073-9231-b8ee9bc3ee08
📒 Files selected for processing (15)
.agents/skills/_shared/git-github-hard-stop.md.agents/skills/_shared/pr-follow-up.md.agents/skills/nemoclaw-contributor-create-pr/SKILL.md.agents/skills/nemoclaw-contributor-update-docs/SKILL.md.agents/skills/nemoclaw-maintainer-cut-release-tag/SKILL.md.agents/skills/nemoclaw-maintainer-day/MERGE-GATE.md.agents/skills/nemoclaw-maintainer-day/PR-REVIEW-PRIORITIES.md.agents/skills/nemoclaw-maintainer-day/SALVAGE-PR.md.agents/skills/nemoclaw-maintainer-day/SECURITY-SWEEP.md.agents/skills/nemoclaw-maintainer-day/SKILL.md.agents/skills/nemoclaw-maintainer-evening/SKILL.md.agents/skills/nemoclaw-skills-guide/SKILL.mdAGENTS.mdscripts/bump-version.tstools/pr-review-advisor/README.md
| @@ -1,6 +1,6 @@ | |||
| --- | |||
Contributor
There was a problem hiding this comment.
Add SPDX license header to the file.
All Markdown files must include an SPDX license header as the first content. For Markdown, use HTML comments.
📝 Proposed fix
+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. -->
+<!-- SPDX-License-Identifier: Apache-2.0 -->
+
# NemoClaw Maintainer Cut Release Tag🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.agents/skills/nemoclaw-maintainer-cut-release-tag/SKILL.md at line 1, The
SKILL.md file is missing the required SPDX license header at the beginning. Add
an SPDX license header as the very first line of the file using HTML comment
syntax (format: <!-- SPDX-License-Identifier: [LICENSE] -->) before any other
content, including the existing `---` marker. This ensures the file complies
with the licensing requirements for all Markdown files.
Source: Coding guidelines
…se-flow # Conflicts: # .agents/skills/nemoclaw-skills-guide/SKILL.md
Contributor
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most covered files.
Updated |
Contributor
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: None Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
Contributor
PR Review AdvisorFindings: 0 needs attention, 0 worth checking, 0 nice ideas This is an automated advisory review. A human maintainer must make the final merge decision. |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts (1)
554-554: ⚡ Quick winUse the env-aware timeout helper instead of a raw literal.
Line 554 hardcodes
30_000, which can bypass the repo’sNEMOCLAW_TEST_TIMEOUTminimum-budget behavior and make this test less resilient on slower CI runners.Suggested change
- }, 30_000); + }, testTimeoutOptions(30_000));// add near imports (outside selected range) import { testTimeoutOptions } from "../../helpers/timeouts";🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts` at line 554, The timeout value in the e2e-scenarios-workflow.test.ts file is hardcoded as 30_000 milliseconds instead of using the environment-aware timeout helper. Replace the hardcoded 30_000 value with testTimeoutOptions imported from ../../helpers/timeouts, and add the import statement at the top of the file near other imports. This ensures the test respects the NEMOCLAW_TEST_TIMEOUT configuration and is more resilient on slower CI runners.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts`:
- Line 554: The timeout value in the e2e-scenarios-workflow.test.ts file is
hardcoded as 30_000 milliseconds instead of using the environment-aware timeout
helper. Replace the hardcoded 30_000 value with testTimeoutOptions imported from
../../helpers/timeouts, and add the import statement at the top of the file near
other imports. This ensures the test respects the NEMOCLAW_TEST_TIMEOUT
configuration and is more resilient on slower CI runners.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 325cdc3b-4e43-41a0-98fc-b92785b7046c
📒 Files selected for processing (1)
test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/bump-version.ts`:
- Around line 117-123: The push command includes the tag refspec
unconditionally, but the tag is only created when options.tag is true. When a
user runs with --push --no-tag, git will fail because the tag refspec does not
exist. Fix this by either gating the entire push block on options.tag, or by
conditionally building the git push arguments array to only include the tag
refspec when options.tag is true. Ensure that when options.tag is false and
options.push is true, the push command only includes ["push", "--atomic",
"origin", "HEAD"] without the refs/tags/${tagName} refspec.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1861ccc9-19a2-49cd-a883-9a004b43466b
📒 Files selected for processing (1)
scripts/bump-version.ts
3 tasks
82 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update NemoClaw agent guidance so release workflows are tag-based instead of PR-based, and centralize reusable PR follow-up and Git/GitHub access-failure instructions. Remove release-PR support from
scripts/bump-version.tsso release metadata bumps use the direct tag/push path.Changes
latest, issue/PR housekeeping, and release-note handoff--create-pr,--no-create-pr, release branch options, and PR creation helpers fromscripts/bump-version.tstools/pr-review-advisor/README.mdType of Change
Verification
Verifiedin GitHubnpx prek run --from-ref main --to-ref HEADpassesnpm testpasses (broad runtime changes only)npm run docsbuilds without warnings (doc changes only)Targeted verification run:
npm run build:clinpm run typecheck:clinpm run bump:version -- --help--no-verifyafter targeted local validation because the local full CLI hook hit unrelated macOS timeoutsSigned-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Note: the final follow-up commit was pushed with
--no-verify; targeted local validation passed and CI is the source of truth for the full sharded CLI suite.