fix(onboard): allow sudo prompts in express install - #3492
Merged
Conversation
Signed-off-by: zyang-dev <267119621+zyang-dev@users.noreply.github.com>
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughExpands the quickstart “Express install” text to state it switches onboarding to non-interactive mode, may enable sudo password prompts for host changes, applies the suggested security policy, and selects the managed local inference path. ChangesQuickstart Express Install Clarification
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
Contributor
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/get-started/quickstart.md (1)
66-66: ⚡ Quick winFormat
sudoas inline code.Line 66 uses
sudoas prose; format it as inline code for command-token consistency.As per coding guidelines "CLI commands, file paths, flags, parameter names, and values must use inline
codeformatting."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/get-started/quickstart.md` at line 66, The sentence "Express install switches onboarding to non-interactive mode, allows sudo password prompts for required host changes, applies the suggested security policy, and selects the managed local inference path for that platform." should use inline code formatting for the sudo token; update the content in docs/get-started/quickstart.md by wrapping the word sudo in inline code backticks (i.e., `sudo`) so it follows the guideline that CLI commands and flags use code formatting, leaving the rest of the sentence unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/get-started/quickstart.md`:
- Line 66: The sentence "Express install switches onboarding to non-interactive
mode, allows sudo password prompts for required host changes, applies the
suggested security policy, and selects the managed local inference path for that
platform." should use inline code formatting for the sudo token; update the
content in docs/get-started/quickstart.md by wrapping the word sudo in inline
code backticks (i.e., `sudo`) so it follows the guideline that CLI commands and
flags use code formatting, leaving the rest of the sentence unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7e9c1309-0e46-46a9-bcaa-097f574665ba
📒 Files selected for processing (6)
docs/get-started/quickstart.mddocs/reference/commands.mdscripts/install.shsrc/lib/onboard/ollama-systemd.tstest/install-preflight.test.tstest/onboard-selection.test.ts
Signed-off-by: zyang-dev <267119621+zyang-dev@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/reference/commands.md`:
- Line 1138: Update the table row for NEMOCLAW_NON_INTERACTIVE_SUDO_MODE to list
all valid values and behaviors: explicitly state that valid values are "prompt"
(allowing non-interactive onboarding to use prompt-capable sudo which will ask
for a password), empty/unset (default behavior: use sudo -n and fail if a
password is required), and any other accepted tokens if applicable; change the
Format column to show "`prompt` or empty/unset" (or mirror the "Valid values:
..." pattern used elsewhere) and expand the Effect column to describe what each
value does and which one is the default (empty/unset => sudo -n). Ensure you
edit the NEMOCLAW_NON_INTERACTIVE_SUDO_MODE row only and follow the same
wording/format as other entries that list valid values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: cf391c6e-fc9c-4416-9be2-0c4822f8ff97
📒 Files selected for processing (3)
docs/reference/commands.mdscripts/install.shtest/install-preflight.test.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- scripts/install.sh
- test/install-preflight.test.ts
Signed-off-by: zyang-dev <267119621+zyang-dev@users.noreply.github.com>
cv
approved these changes
May 15, 2026
wscurran
added
area: cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows express install to keep non-interactive onboarding defaults while permitting sudo password prompts for required host setup. This fixes Ollama systemd override setup on hosts where the drop-in is readable normally, but
sudo -nfails because sudo requires a password.Changes
NEMOCLAW_NON_INTERACTIVE_SUDO_MODE=promptfor prompt-capable sudo during non-interactive onboarding.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)Signed-off-by: zyang-dev 267119621+zyang-dev@users.noreply.github.com
Summary by CodeRabbit
New Features
Documentation
Bug Fixes
Tests