Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 34 additions & 7 deletions .github/workflows/nightly-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ on:
sandbox-operations-e2e, inference-routing-e2e, network-policy-e2e,
deployment-services-e2e, diagnostics-e2e, snapshot-commands-e2e,
shields-config-e2e, rebuild-openclaw-e2e, upgrade-stale-sandbox-e2e,
rebuild-hermes-e2e, overlayfs-autofix-e2e, gpu-e2e
rebuild-hermes-e2e, double-onboard-e2e, onboard-repair-e2e,
onboard-resume-e2e, runtime-overrides-e2e,
credential-sanitization-e2e, telegram-injection-e2e,
overlayfs-autofix-e2e, gpu-e2e
Comment on lines +47 to +50

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add gpu-double-onboard-e2e to the manual dispatch jobs help text.

Line 50 still ends the “Valid:” list at gpu-e2e, but gpu-double-onboard-e2e is also selectable via inputs.jobs (Lines 917-923). Please include it to keep dispatch instructions accurate.

Suggested patch
-          overlayfs-autofix-e2e, gpu-e2e
+          overlayfs-autofix-e2e, gpu-e2e, gpu-double-onboard-e2e
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
rebuild-hermes-e2e, double-onboard-e2e, onboard-repair-e2e,
onboard-resume-e2e, runtime-overrides-e2e,
credential-sanitization-e2e, telegram-injection-e2e,
overlayfs-autofix-e2e, gpu-e2e
rebuild-hermes-e2e, double-onboard-e2e, onboard-repair-e2e,
onboard-resume-e2e, runtime-overrides-e2e,
credential-sanitization-e2e, telegram-injection-e2e,
overlayfs-autofix-e2e, gpu-e2e, gpu-double-onboard-e2e
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/nightly-e2e.yaml around lines 47 - 50, The manual workflow
dispatch help text's "Valid:" jobs list is missing the gpu-double-onboard-e2e
option; update the help string for the inputs.jobs description (the manual
dispatch block referenced by inputs.jobs) to include "gpu-double-onboard-e2e"
alongside the existing items (e.g., rebuild-hermes-e2e, gpu-e2e) so the
displayed Valid: list matches the actual selectable options.

required: false
type: string
default: ""
Expand Down Expand Up @@ -591,7 +594,11 @@ jobs:
# TEMPORARY: validates the auto-fix in src/lib/cluster-image-patch.ts.
# ── Double Onboard / Lifecycle Recovery E2E ──────────────────
double-onboard-e2e:
if: github.repository == 'NVIDIA/NemoClaw'
if: >-
github.repository == 'NVIDIA/NemoClaw' &&
(github.event_name != 'workflow_dispatch' ||
inputs.jobs == '' ||
contains(format(',{0},', inputs.jobs), ',double-onboard-e2e,'))
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
Expand Down Expand Up @@ -624,7 +631,11 @@ jobs:

# ── Onboard Repair E2E ─────────────────────────────────────
onboard-repair-e2e:
if: github.repository == 'NVIDIA/NemoClaw'
if: >-
github.repository == 'NVIDIA/NemoClaw' &&
(github.event_name != 'workflow_dispatch' ||
inputs.jobs == '' ||
contains(format(',{0},', inputs.jobs), ',onboard-repair-e2e,'))
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
Expand Down Expand Up @@ -657,7 +668,11 @@ jobs:

# ── Onboard Resume E2E ─────────────────────────────────────
onboard-resume-e2e:
if: github.repository == 'NVIDIA/NemoClaw'
if: >-
github.repository == 'NVIDIA/NemoClaw' &&
(github.event_name != 'workflow_dispatch' ||
inputs.jobs == '' ||
contains(format(',{0},', inputs.jobs), ',onboard-resume-e2e,'))
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
Expand Down Expand Up @@ -690,7 +705,11 @@ jobs:

# ── Runtime Overrides E2E ──────────────────────────────────
runtime-overrides-e2e:
if: github.repository == 'NVIDIA/NemoClaw'
if: >-
github.repository == 'NVIDIA/NemoClaw' &&
(github.event_name != 'workflow_dispatch' ||
inputs.jobs == '' ||
contains(format(',{0},', inputs.jobs), ',runtime-overrides-e2e,'))
runs-on: ubuntu-latest
timeout-minutes: 45
steps:
Expand Down Expand Up @@ -724,7 +743,11 @@ jobs:
# ── Credential Sanitization E2E ────────────────────────────
# Requires a running sandbox. Bootstraps via install.sh then runs tests.
credential-sanitization-e2e:
if: github.repository == 'NVIDIA/NemoClaw'
if: >-
github.repository == 'NVIDIA/NemoClaw' &&
(github.event_name != 'workflow_dispatch' ||
inputs.jobs == '' ||
contains(format(',{0},', inputs.jobs), ',credential-sanitization-e2e,'))
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
Expand Down Expand Up @@ -761,7 +784,11 @@ jobs:
# ── Telegram Injection E2E ─────────────────────────────────
# Requires a running sandbox. Bootstraps via install.sh then runs tests.
telegram-injection-e2e:
if: github.repository == 'NVIDIA/NemoClaw'
if: >-
github.repository == 'NVIDIA/NemoClaw' &&
(github.event_name != 'workflow_dispatch' ||
inputs.jobs == '' ||
contains(format(',{0},', inputs.jobs), ',telegram-injection-e2e,'))
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
Expand Down
Loading