Skip to content

fix(ci): add selective dispatch guards to 6 E2E jobs from #2607 - #2637

Merged
brandonpelfrey merged 1 commit into
NVIDIA:mainfrom
jyaunches:fix/add-selective-dispatch-guards-2607
Apr 28, 2026
Merged

fix(ci): add selective dispatch guards to 6 E2E jobs from #2607#2637
brandonpelfrey merged 1 commit into
NVIDIA:mainfrom
jyaunches:fix/add-selective-dispatch-guards-2607

Conversation

@jyaunches

@jyaunches jyaunches commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Summary

The 6 E2E jobs wired in #2607 (double-onboard-e2e, onboard-repair-e2e, onboard-resume-e2e, runtime-overrides-e2e, credential-sanitization-e2e, telegram-injection-e2e) were added without the selective dispatch guard, breaking validate-e2e-coverage.test.ts on main.

Changes

  • Adds the standard dispatch guard to all 6 jobs:
    if: >-
      github.repository == 'NVIDIA/NemoClaw' &&
      (github.event_name != 'workflow_dispatch' ||
       inputs.jobs == '' ||
       contains(format(',{0},', inputs.jobs), ',<job-name>,'))
  • Adds all 6 job names to the workflow_dispatch.inputs.jobs description

Why this matters

  • main is broken — the checks CI job fails on every PR due to this
  • Selective dispatch (-f jobs=cloud-e2e) currently runs these 6 jobs unconditionally

Type of Change

  • Code change (bug fix)

Verification

  • YAML validated locally
  • validate-e2e-coverage.test.ts should pass with these guards in place

Summary by CodeRabbit

  • Chores
    • Updated CI/CD testing automation to enhance selective E2E test execution. The workflow now supports independent execution of specific test scenarios—including double-onboard, onboard-repair, onboard-resume, runtime-overrides, credential-sanitization, and telegram-injection tests—alongside full test suite options, configurable based on workflow dispatch selections.

The 6 jobs wired in NVIDIA#2607 (double-onboard-e2e, onboard-repair-e2e,
onboard-resume-e2e, runtime-overrides-e2e, credential-sanitization-e2e,
telegram-injection-e2e) were added without the selective dispatch guard,
causing validate-e2e-coverage.test.ts to fail on main.

Adds the standard guard pattern so workflow_dispatch with -f jobs=<name>
correctly filters these jobs, and adds them to the inputs.jobs
description.

Signed-off-by: Jessica Yaunches <jyaunches@nvidia.com>
@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The nightly E2E workflow dispatch configuration is extended to include six newly-added E2E test jobs in the manual dispatch whitelist. Job execution guards are updated from repository checks alone to compound conditions that also verify workflow dispatch input filters.

Changes

Cohort / File(s) Summary
Workflow dispatch configuration
.github/workflows/nightly-e2e.yaml
Extended workflow_dispatch jobs input whitelist to include double-onboard-e2e, onboard-repair-e2e, onboard-resume-e2e, runtime-overrides-e2e, credential-sanitization-e2e, and telegram-injection-e2e. Updated job guard conditions from repository-only checks to compound conditions that additionally restrict execution based on manual dispatch job selection inputs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hop, hop! The workflow's paths align,
Six new E2E jobs now shine so fine,
Guards and filters, neat and tight,
Selective dispatch—all looks right!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding selective dispatch guards to 6 E2E jobs, referencing the related issue #2607.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/nightly-e2e.yaml:
- Around line 47-50: The manual workflow dispatch help text's "Valid:" jobs list
is missing the gpu-double-onboard-e2e option; update the help string for the
inputs.jobs description (the manual dispatch block referenced by inputs.jobs) to
include "gpu-double-onboard-e2e" alongside the existing items (e.g.,
rebuild-hermes-e2e, gpu-e2e) so the displayed Valid: list matches the actual
selectable options.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e1ea48e3-9207-4a62-9b28-cd59460025e2

📥 Commits

Reviewing files that changed from the base of the PR and between 5aa9e5d and 0c51636.

📒 Files selected for processing (1)
  • .github/workflows/nightly-e2e.yaml

Comment on lines +47 to +50
rebuild-hermes-e2e, double-onboard-e2e, onboard-repair-e2e,
onboard-resume-e2e, runtime-overrides-e2e,
credential-sanitization-e2e, telegram-injection-e2e,
overlayfs-autofix-e2e, gpu-e2e

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add gpu-double-onboard-e2e to the manual dispatch jobs help text.

Line 50 still ends the “Valid:” list at gpu-e2e, but gpu-double-onboard-e2e is also selectable via inputs.jobs (Lines 917-923). Please include it to keep dispatch instructions accurate.

Suggested patch
-          overlayfs-autofix-e2e, gpu-e2e
+          overlayfs-autofix-e2e, gpu-e2e, gpu-double-onboard-e2e
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
rebuild-hermes-e2e, double-onboard-e2e, onboard-repair-e2e,
onboard-resume-e2e, runtime-overrides-e2e,
credential-sanitization-e2e, telegram-injection-e2e,
overlayfs-autofix-e2e, gpu-e2e
rebuild-hermes-e2e, double-onboard-e2e, onboard-repair-e2e,
onboard-resume-e2e, runtime-overrides-e2e,
credential-sanitization-e2e, telegram-injection-e2e,
overlayfs-autofix-e2e, gpu-e2e, gpu-double-onboard-e2e
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/nightly-e2e.yaml around lines 47 - 50, The manual workflow
dispatch help text's "Valid:" jobs list is missing the gpu-double-onboard-e2e
option; update the help string for the inputs.jobs description (the manual
dispatch block referenced by inputs.jobs) to include "gpu-double-onboard-e2e"
alongside the existing items (e.g., rebuild-hermes-e2e, gpu-e2e) so the
displayed Valid: list matches the actual selectable options.

@brandonpelfrey
brandonpelfrey merged commit 8241874 into NVIDIA:main Apr 28, 2026
15 checks passed
jyaunches added a commit that referenced this pull request Apr 29, 2026
Resolve conflict with credential-migration-e2e comment block from main.
Add selective dispatch guard to launchable-smoke-e2e to match the pattern
from PR #2637. Add launchable-smoke-e2e to the valid jobs input list.
DemianHeyGen pushed a commit to DemianHeyGen/NemoClaw that referenced this pull request Apr 30, 2026
…NVIDIA#2637)

## Summary

The 6 E2E jobs wired in NVIDIA#2607 (`double-onboard-e2e`,
`onboard-repair-e2e`, `onboard-resume-e2e`, `runtime-overrides-e2e`,
`credential-sanitization-e2e`, `telegram-injection-e2e`) were added
without the selective dispatch guard, breaking
`validate-e2e-coverage.test.ts` on main.

## Changes

- Adds the standard dispatch guard to all 6 jobs:
  ```yaml
  if: >-
    github.repository == 'NVIDIA/NemoClaw' &&
    (github.event_name != 'workflow_dispatch' ||
     inputs.jobs == '' ||
     contains(format(',{0},', inputs.jobs), ',<job-name>,'))
  ```
- Adds all 6 job names to the `workflow_dispatch.inputs.jobs`
description

## Why this matters

- **main is broken** — the `checks` CI job fails on every PR due to this
- Selective dispatch (`-f jobs=cloud-e2e`) currently runs these 6 jobs
unconditionally

## Type of Change

- Code change (bug fix)

## Verification

- YAML validated locally
- `validate-e2e-coverage.test.ts` should pass with these guards in place

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Updated CI/CD testing automation to enhance selective E2E test
execution. The workflow now supports independent execution of specific
test scenarios—including double-onboard, onboard-repair, onboard-resume,
runtime-overrides, credential-sanitization, and telegram-injection
tests—alongside full test suite options, configurable based on workflow
dispatch selections.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Jessica Yaunches <jyaunches@nvidia.com>
@wscurran wscurran added the bug-fix PR fixes a bug or regression label Jun 8, 2026
@jyaunches
jyaunches deleted the fix/add-selective-dispatch-guards-2607 branch June 22, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix PR fixes a bug or regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants