fix(ci): add selective dispatch guards to 6 E2E jobs from #2607 - #2637
Conversation
The 6 jobs wired in NVIDIA#2607 (double-onboard-e2e, onboard-repair-e2e, onboard-resume-e2e, runtime-overrides-e2e, credential-sanitization-e2e, telegram-injection-e2e) were added without the selective dispatch guard, causing validate-e2e-coverage.test.ts to fail on main. Adds the standard guard pattern so workflow_dispatch with -f jobs=<name> correctly filters these jobs, and adds them to the inputs.jobs description. Signed-off-by: Jessica Yaunches <jyaunches@nvidia.com>
📝 WalkthroughWalkthroughThe nightly E2E workflow dispatch configuration is extended to include six newly-added E2E test jobs in the manual dispatch whitelist. Job execution guards are updated from repository checks alone to compound conditions that also verify workflow dispatch input filters. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/nightly-e2e.yaml:
- Around line 47-50: The manual workflow dispatch help text's "Valid:" jobs list
is missing the gpu-double-onboard-e2e option; update the help string for the
inputs.jobs description (the manual dispatch block referenced by inputs.jobs) to
include "gpu-double-onboard-e2e" alongside the existing items (e.g.,
rebuild-hermes-e2e, gpu-e2e) so the displayed Valid: list matches the actual
selectable options.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e1ea48e3-9207-4a62-9b28-cd59460025e2
📒 Files selected for processing (1)
.github/workflows/nightly-e2e.yaml
| rebuild-hermes-e2e, double-onboard-e2e, onboard-repair-e2e, | ||
| onboard-resume-e2e, runtime-overrides-e2e, | ||
| credential-sanitization-e2e, telegram-injection-e2e, | ||
| overlayfs-autofix-e2e, gpu-e2e |
There was a problem hiding this comment.
Add gpu-double-onboard-e2e to the manual dispatch jobs help text.
Line 50 still ends the “Valid:” list at gpu-e2e, but gpu-double-onboard-e2e is also selectable via inputs.jobs (Lines 917-923). Please include it to keep dispatch instructions accurate.
Suggested patch
- overlayfs-autofix-e2e, gpu-e2e
+ overlayfs-autofix-e2e, gpu-e2e, gpu-double-onboard-e2e📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| rebuild-hermes-e2e, double-onboard-e2e, onboard-repair-e2e, | |
| onboard-resume-e2e, runtime-overrides-e2e, | |
| credential-sanitization-e2e, telegram-injection-e2e, | |
| overlayfs-autofix-e2e, gpu-e2e | |
| rebuild-hermes-e2e, double-onboard-e2e, onboard-repair-e2e, | |
| onboard-resume-e2e, runtime-overrides-e2e, | |
| credential-sanitization-e2e, telegram-injection-e2e, | |
| overlayfs-autofix-e2e, gpu-e2e, gpu-double-onboard-e2e |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/nightly-e2e.yaml around lines 47 - 50, The manual workflow
dispatch help text's "Valid:" jobs list is missing the gpu-double-onboard-e2e
option; update the help string for the inputs.jobs description (the manual
dispatch block referenced by inputs.jobs) to include "gpu-double-onboard-e2e"
alongside the existing items (e.g., rebuild-hermes-e2e, gpu-e2e) so the
displayed Valid: list matches the actual selectable options.
Resolve conflict with credential-migration-e2e comment block from main. Add selective dispatch guard to launchable-smoke-e2e to match the pattern from PR #2637. Add launchable-smoke-e2e to the valid jobs input list.
…NVIDIA#2637) ## Summary The 6 E2E jobs wired in NVIDIA#2607 (`double-onboard-e2e`, `onboard-repair-e2e`, `onboard-resume-e2e`, `runtime-overrides-e2e`, `credential-sanitization-e2e`, `telegram-injection-e2e`) were added without the selective dispatch guard, breaking `validate-e2e-coverage.test.ts` on main. ## Changes - Adds the standard dispatch guard to all 6 jobs: ```yaml if: >- github.repository == 'NVIDIA/NemoClaw' && (github.event_name != 'workflow_dispatch' || inputs.jobs == '' || contains(format(',{0},', inputs.jobs), ',<job-name>,')) ``` - Adds all 6 job names to the `workflow_dispatch.inputs.jobs` description ## Why this matters - **main is broken** — the `checks` CI job fails on every PR due to this - Selective dispatch (`-f jobs=cloud-e2e`) currently runs these 6 jobs unconditionally ## Type of Change - Code change (bug fix) ## Verification - YAML validated locally - `validate-e2e-coverage.test.ts` should pass with these guards in place <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated CI/CD testing automation to enhance selective E2E test execution. The workflow now supports independent execution of specific test scenarios—including double-onboard, onboard-repair, onboard-resume, runtime-overrides, credential-sanitization, and telegram-injection tests—alongside full test suite options, configurable based on workflow dispatch selections. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jessica Yaunches <jyaunches@nvidia.com>
Summary
The 6 E2E jobs wired in #2607 (
double-onboard-e2e,onboard-repair-e2e,onboard-resume-e2e,runtime-overrides-e2e,credential-sanitization-e2e,telegram-injection-e2e) were added without the selective dispatch guard, breakingvalidate-e2e-coverage.test.tson main.Changes
workflow_dispatch.inputs.jobsdescriptionWhy this matters
checksCI job fails on every PR due to this-f jobs=cloud-e2e) currently runs these 6 jobs unconditionallyType of Change
Verification
validate-e2e-coverage.test.tsshould pass with these guards in placeSummary by CodeRabbit