Skip to content

fix(eject): ensure sandbox is stopped before host state restoration #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dumko2001 wants to merge 1 commit into from
Closed

fix(eject): ensure sandbox is stopped before host state restoration #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions nemoclaw/src/commands/eject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import { existsSync } from "node:fs";
import { join } from "node:path";
import { execSync } from "node:child_process";
import type { PluginLogger, NemoClawConfig } from "../index.js";
import { execBlueprint } from "../blueprint/exec.js";
import { loadState, clearState } from "../blueprint/state.js";
Expand Down Expand Up @@ -55,6 +56,16 @@ export async function cliEject(opts: EjectOptions): Promise<void> {
return;
}

// Step 0: Ensure sandbox is stopped before restoration
if (state.sandboxName) {
logger.info(`Ensuring sandbox '${state.sandboxName}' is stopped...`);
try {
execSync(`openshell sandbox stop ${state.sandboxName}`, { stdio: "ignore" });
} catch {
// Best effort — sandbox might already be stopped
}
}

// Step 1: Rollback blueprint
if (state.lastRunId && state.blueprintVersion) {
const blueprintPath = join(HOME, ".nemoclaw", "blueprints", state.blueprintVersion);
Expand Down