Skip to content

fix(eject): ensure sandbox is stopped before host state restoration - #192

Closed
dumko2001 wants to merge 1 commit into
NVIDIA:mainfrom
dumko2001:fix/c4-eject-sandbox-stop-before-restore
Closed

fix(eject): ensure sandbox is stopped before host state restoration#192
dumko2001 wants to merge 1 commit into
NVIDIA:mainfrom
dumko2001:fix/c4-eject-sandbox-stop-before-restore

Conversation

@dumko2001

@dumko2001 dumko2001 commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Rationale

Modifying host state files while the sandbox is active can lead to race conditions or file corruption.

Changes

Added a mandatory sandbox stop check before proceeding with host-side .openclaw file restoration.

Verification Results

  • Automated Tests: Passed all 52 core tests via npm test.
  • Manual Audit: Verified sequential execution order in eject.ts commands.
  • Security Review: Verified no sensitive data leaks and correct permission enforcement.

@cv

cv commented Mar 21, 2026

Copy link
Copy Markdown
Collaborator

@dumko2001 stopping the sandbox before host state restoration during eject makes total sense. Rebase onto the latest main when you get a chance? We want to review this against the current eject flow.

@dumko2001

Copy link
Copy Markdown
Contributor Author

@cv the feature it was patching has been removed.fix: remove openclaw nemoclaw CLI commands, keep provider and slash command (#492)

This commit completely deleted nemoclaw/src/commands/eject.ts along with almost all the other local CLI commands. guess it was a good run :). you can close this since it's redundant :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature PR adds or expands user-visible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants