Skip to content

fix(e2e): fix messaging-providers and sandbox-survival nightly E2E regressions #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericksoa merged 3 commits into from
Apr 14, 2026
+17 −4
Merged

fix(e2e): fix messaging-providers and sandbox-survival nightly E2E regressions #1859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3efe7cb
fix(ci): set NEMOCLAW_POLICY_TIER=open for messaging-providers E2E
ericksoa Apr 14, 2026
10c0b63
fix(e2e): add SSH retry after gateway restart and preserve config on …
ericksoa Apr 14, 2026
3e0e578
Merge branch 'main' into fix/e2e-messaging-tier
ericksoa Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/nightly-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ jobs:
NVIDIA_API_KEY: ${{ secrets.NVIDIA_API_KEY }}
NEMOCLAW_NON_INTERACTIVE: "1"
NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE: "1"
NEMOCLAW_POLICY_TIER: "open"
NEMOCLAW_SANDBOX_NAME: "e2e-msg-provider"
NEMOCLAW_RECREATE_SANDBOX: "1"
GITHUB_TOKEN: ${{ github.token }}
Expand Down
20 changes: 16 additions & 4 deletions test/e2e/test-sandbox-survival.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,13 +552,25 @@ fi
pass "SSH config available after restart"

# 8a: Raw SSH connectivity — the #888/#1086 handshake test
if ssh "${SSH_OPTS[@]}" "$SSH_TARGET" "echo alive" >/dev/null 2>&1; then
pass "SSH into sandbox works after restart (no handshake failure — #888/#1086)"
# The sandbox SSH agent may take a few seconds to become reachable after
# the gateway reports healthy (especially with newer OpenClaw versions that
# do more startup work). Retry up to 30 seconds before declaring failure.
SSH_OK=0
for ssh_attempt in $(seq 1 6); do
if ssh "${SSH_OPTS[@]}" "$SSH_TARGET" "echo alive" >/dev/null 2>&1; then
SSH_OK=1
break
fi
[ "$ssh_attempt" -lt 6 ] && sleep 5
done

if [ "$SSH_OK" -eq 1 ]; then
pass "SSH into sandbox works after restart (attempt $ssh_attempt, no handshake failure — #888/#1086)"
else
fail "SSH into sandbox FAILED after restart — handshake verification likely failed (#888/#1086)"
info "This is the core bug: gateway regenerated secrets, sandbox has stale ones"
cleanup_ssh
# Still try to get logs for diagnosis
# Do NOT call cleanup_ssh here — subsequent phases need the config file
# to attempt marker reads and produce meaningful diagnostics.
nemoclaw "$SANDBOX_NAME" logs 2>&1 | grep -i "handshake" | head -5 || true
fi

Expand Down
Loading