fix(e2e): fix messaging-providers and sandbox-survival nightly E2E regressions - #1859
Conversation
The tier-based policy selector (#1753) defaults non-interactive onboard to the "balanced" tier, which excludes messaging presets (telegram, discord, slack). The messaging-providers E2E test needs the "open" tier to allow egress to api.telegram.org and discord.com. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded an environment variable Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…failure Two fixes for the sandbox-survival E2E: 1. Add retry loop (up to 30s) for SSH connectivity after gateway restart. The sandbox SSH agent may not be ready immediately after the gateway reports healthy, especially with OpenClaw 2026.4.2 which does more startup work. 2. Remove cleanup_ssh() from the Phase 8 failure path. Deleting the SSH config file caused all subsequent phases (9, 10) to fail with "Can't open user config file" — masking whether data actually persisted. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…gressions (NVIDIA#1859) ## Summary - **messaging-providers-e2e**: The tier-based policy selector (NVIDIA#1753) defaults non-interactive onboard to `balanced`, which excludes messaging presets. Adds `NEMOCLAW_POLICY_TIER: "open"` to the workflow env. - **sandbox-survival-e2e**: SSH after gateway restart can fail because the sandbox SSH agent isn't immediately reachable when the gateway reports healthy (more noticeable with OpenClaw 2026.4.2). Adds a 30s retry loop for SSH connectivity. Also removes `cleanup_ssh()` from the failure path — deleting the SSH config was causing all subsequent phases to fail with "Can't open user config file", masking whether data actually persisted. ## Test plan - [ ] Nightly E2E messaging-providers job passes - [ ] Nightly E2E sandbox-survival job passes (or produces real diagnostics if data is actually lost) 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Nightly end-to-end test environment configuration updated to set the test policy tier. * **Tests** * End-to-end test flow now retries SSH connectivity multiple times and preserves connection data on failure, improving test stability and enabling richer diagnostic logs. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: ColinM-sys <cmcdonough@50words.com>
Summary
balanced, which excludes messaging presets. AddsNEMOCLAW_POLICY_TIER: "open"to the workflow env.cleanup_ssh()from the failure path — deleting the SSH config was causing all subsequent phases to fail with "Can't open user config file", masking whether data actually persisted.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Tests