Skip to content

refactor(review): improve specialist causal analysis - #10888

Merged
cv merged 1 commit into
refactor/pr-advisor-lean-specialistsfrom
feat/advisor-causal-specialists-v2
Sep 2, 2026
Merged

refactor(review): improve specialist causal analysis#10888
cv merged 1 commit into
refactor/pr-advisor-lean-specialistsfrom
feat/advisor-causal-specialists-v2

Conversation

@cv

@cv cv commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Outcome

Improve PR Review Advisor specialist investigation quality using independently selected prompt variants from three model-backed historical-PR A/B rounds.

Reason

The clean benchmark showed that broad prompts could attribute inherited defects to a PR, miss incomplete immutable-pin migrations, and conflate producer or rejection tests with positive consumer proof.

Changes

  • Require changed-file, parent-state, consumer, and contract causality.
  • Narrow architecture ownership and add migration-completion and reduction-simplification specialists.
  • Adopt independently selected delivery, documentation, and verification prompts.
  • Preserve tracked internal symlinks in local snapshots while removing escaping links; direct patching could not preserve this security boundary and valid transitions together.
  • Protect snapshot behavior with internal-link and escaping-to-internal retarget regression coverage.

Verification

Review notes

This draft is stacked on #10813. Output length and finding count were not selection criteria; prompts were selected independently for factuality, recall, causality, calibration, and remedies.


Signed-off-by: Carlos Villela cvillela@nvidia.com

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv cv self-assigned this Sep 2, 2026
@copy-pr-bot

copy-pr-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4b7fb494-cb72-42ec-a5fe-e3fd6a40ff96

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit 6066995 in the feat/advisor-causal-... branch remains at 96%, unchanged from commit 19bb986 in the refactor/pr-advisor-... branch.

TypeScript / code-coverage/cli

The overall line coverage in commit 6066995 in the feat/advisor-causal-... branch remains at 83%, unchanged from commit 19bb986 in the refactor/pr-advisor-... branch.

Show a line coverage summary of the most impacted files.
File refactor/pr-advisor-... 19bb986 feat/advisor-causal-... 6066995 +/-
src/lib/onboard...aging-config.ts 90% 86% -4%
src/lib/onboard...host-forward.ts 84% 81% -3%
src/lib/policy/index.ts 74% 74% 0%
src/lib/onboard...dge-provider.ts 91% 91% 0%
src/lib/sandbox...rce-identity.ts 82% 82% 0%
src/lib/onboard...uild-context.ts 74% 75% +1%

Updated September 02, 2026 18:00 UTC

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor finished for commit 6066995. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

All previous runs

@cv
cv marked this pull request as ready for review September 2, 2026 18:54
@cv
cv merged commit 96f83c0 into refactor/pr-advisor-lean-specialists Sep 2, 2026
53 of 55 checks passed
@cv
cv deleted the feat/advisor-causal-specialists-v2 branch September 2, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant