test(e2e): select messaging and Shields runtime proofs - #10536
Conversation
Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit b8f6227 in the TypeScript / code-coverage/cliThe overall line coverage in commit b8f6227 in the Show a line coverage summary of the most impacted files.
Updated |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe risk plan now maps messaging, Hermes, OpenClaw, and Shields runtime changes to focused E2E jobs. Tests validate job selection, managed-policy expectations, runtime proofs, and the updated plan version. ChangesRuntime risk-plan selection
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This localized change updates E2E risk-plan selection and adds regression coverage; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant ChangedFiles
participant RiskPlanMatcher
participant RuntimeChecks
participant RequiredJobSelection
participant WorkflowPlanner
ChangedFiles->>RiskPlanMatcher: provide changed runtime files
RiskPlanMatcher->>RuntimeChecks: submit focused matches
RuntimeChecks->>RequiredJobSelection: return relevant categories
RequiredJobSelection->>WorkflowPlanner: provide selected E2E jobs and matched files
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
|
PR Review Advisor finished for commit |
Outcome
Messaging and Shields runtime changes now select their focused branch E2E proof lanes. Production changes that leave the live test files untouched can no longer fall through to only the generic risk plan.
Reason
PR #10480 protects fast-test parity when a live E2E test changes, but recent regressions in #10153 and #10155 came from production runtime changes. The live test files did not change, so that guard could not select the missing messaging and Shields proof.
Related issues
Relates to #10153
Relates to #10155
Changes
The existing trusted risk planner is the current PR workflow consumer. Extending that source ownership directly is necessary because a live-test parity rule cannot observe production-only changes.
Verification
npm run build:cli— passednpm run typecheck:cli— passed after rebasing onto currentmainnpx vitest run --project integration test/automation/pull-requests/pr-risk-plan.test.ts --testTimeout 60000— 154 passed after rebasing onto currentmainnpx vitest run --project e2e-support test/e2e/support/workflow-plan.test.ts --testTimeout 60000— 88 passed after rebasing onto currentmaingit diff --check— passedVerifiedwith a valid signatureReview notes
This changes the trusted E2E selection control plane, not production runtime behavior. Regression tests verify both the selected risk jobs and their resolved workflow lanes.
The default 5-second test timeout was too short for several subprocess-based workflow-plan cases under local machine load. Re-running the same full file with a 60-second timeout passed all 88 tests; required CI remains the merge gate.
Signed-off-by: Charan Jagwani cjagwani@nvidia.com
Summary by CodeRabbit
Tests
Chores