Skip to content

build(pkg): adopt npm workspaces for repository source packages - #10520

Closed
HOYALIM wants to merge 2 commits into
NVIDIA:mainfrom
HOYALIM:codex/rfc0002-step2-npm-workspaces
Closed

build(pkg): adopt npm workspaces for repository source packages#10520
HOYALIM wants to merge 2 commits into
NVIDIA:mainfrom
HOYALIM:codex/rfc0002-step2-npm-workspaces

Conversation

@HOYALIM

@HOYALIM HOYALIM commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

This pull request implements the second preparation step recommended in Discussion #9909 (RFC 0002) by organizing repository source packages under npm workspaces.

Key Changes

  • Add "workspaces": ["nemoclaw"]\ costumes to the root package.json`.
  • Establish repository-level package installation and local workspace symlinking for nemoclaw-plugin.
  • Synchronize root package-lock.json with the workspace configuration.
  • Maintains existing standalone sandbox-image lockfiles where independent dependency graphs are required.

Verification

  • npm run checks:repository passed with 0 errors.
  • npm run typecheck:cli passed with 0 errors.
  • npm run lint passed with 0 errors.
  • Verified workspace linking in node_modules.

Signed-off-by: Ho Lim subhoya@gmail.com

Summary by CodeRabbit

  • Chores
    • Added the Nemoclaw package to the npm workspace.
    • Renamed the package from nemoclaw to nemoclaw-plugin.

Copilot AI lite review requested due to automatic review settings August 27, 2026 22:39
@copy-pr-bot

copy-pr-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 341b1535-ca4f-4c87-8c43-b6a443bc3c9a

📥 Commits

Reviewing files that changed from the base of the PR and between fa08360 and 3df16e0.

⛔ Files ignored due to path filters (2)
  • nemoclaw/package-lock.json is excluded by !**/package-lock.json
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • nemoclaw/package.json
  • package.json
🚧 Files skipped from review as they are similar to previous changes (2)
  • package.json
  • nemoclaw/package.json

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

The root project adds nemoclaw as an npm workspace. The workspace package name changes from nemoclaw to nemoclaw-plugin.

Changes

npm workspace integration

Layer / File(s) Summary
Workspace registration and package identity
package.json, nemoclaw/package.json
The root npm configuration registers the nemoclaw workspace. The workspace package name changes to nemoclaw-plugin.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 3df16

The change enables workspace installation and updates package identity and lockfile state. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adopting npm workspaces for repository source packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@wscurran wscurran added area: packaging Packages, images, registries, installers, or distribution chore Build, CI, dependency, or tooling maintenance labels Aug 28, 2026
@wscurran

Copy link
Copy Markdown
Contributor

✨ Thanks for the packaging work. This PR adopts npm workspaces for the repository source packages and passes all checks. Ready for maintainer review.

@HOYALIM
HOYALIM force-pushed the codex/rfc0002-step2-npm-workspaces branch from af1a7f9 to 3df16e0 Compare September 5, 2026 02:26
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor finished for commit 3df16e0. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

All previous runs

@HOYALIM

HOYALIM commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Closing Step 2 temporarily to stay within contributor open-PR limits while Step 1 (#10518) is under review. The branch codex/rfc0002-step2-npm-workspaces is preserved and will be reopened once #10518 lands.

@HOYALIM HOYALIM closed this Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: packaging Packages, images, registries, installers, or distribution chore Build, CI, dependency, or tooling maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants