Skip to content

build(pkg): separate root CLI and OpenClaw plugin package identities - #10518

Merged
jyaunches merged 4 commits into
NVIDIA:mainfrom
HOYALIM:codex/rfc0002-step1-package-identities
Sep 9, 2026
Merged

build(pkg): separate root CLI and OpenClaw plugin package identities#10518
jyaunches merged 4 commits into
NVIDIA:mainfrom
HOYALIM:codex/rfc0002-step1-package-identities

Conversation

@HOYALIM

@HOYALIM HOYALIM commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

This pull request implements the first preparation step recommended in Discussion #9909 (RFC 0002) by giving distinct package identities to the root CLI and the OpenClaw plugin.

Key Changes

  • Update nemoclaw/package.json to use package name "nemoclaw-plugin", resolving the name collision with the root CLI package ("nemoclaw").
  • Synchronize nemoclaw/package-lock.json with the updated package identity.
  • Preserves all existing build targets, policy boundaries, and CLI contract tests.

Verification

  • npm run checks:repository passed with 0 errors.
  • npm run typecheck:cli passed.
  • npm run lint passed with 0 errors.
  • Tested plugin compilation (npm --prefix nemoclaw run build).

Signed-off-by: Ho Lim subhoya@gmail.com

Summary by CodeRabbit

  • Chores
    • Updated the package name to nemoclaw-plugin.

Copilot AI lite review requested due to automatic review settings August 27, 2026 22:24
@copy-pr-bot

copy-pr-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a7649d9c-f811-4f0e-8afe-c0c9f7b9b7fd

📥 Commits

Reviewing files that changed from the base of the PR and between 97c7f43 and 7f65307.

⛔ Files ignored due to path filters (1)
  • nemoclaw/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • nemoclaw/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • nemoclaw/package.json

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The package manifest name changes from nemoclaw to nemoclaw-plugin.

Changes

Package Rename

Layer / File(s) Summary
Update package manifest
nemoclaw/package.json
The package name changes from nemoclaw to nemoclaw-plugin.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7f653

The package identity rename and lockfile synchronization have no identified current merge-readiness risk.

Suggested reviewers: cv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: separating the root CLI and OpenClaw plugin package identities.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@wscurran wscurran added area: packaging Packages, images, registries, installers, or distribution chore Build, CI, dependency, or tooling maintenance integration: openclaw OpenClaw integration behavior labels Aug 28, 2026
@wscurran

Copy link
Copy Markdown
Contributor

✨ Thanks for the packaging work. This cleanly separates the OpenClaw plugin identity from the root CLI as outlined in RFC 0002.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor finished for commit 99a12a2. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

All previous runs

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@jyaunches
jyaunches merged commit 13fafc5 into NVIDIA:main Sep 9, 2026
4 checks passed
cv pushed a commit that referenced this pull request Sep 9, 2026
## Outcome

Restore the plugin lockfile's Linux libc constraints so the protected
glibc npm cache seed remains exact and PR merge-ref CI no longer fails
its integrity contract.

## Reason

PR #10518 correctly renamed the plugin package, but its lockfile rewrite
also removed 26 existing libc constraints. The checked-in
protected-cache manifest still described the prior 85-archive glibc
graph, while the rewritten lock selected four additional musl archives
and had a different hash. This currently breaks CLI shard 6 for PRs
tested against main, including #11173.

## Changes

- Restore the 26 glibc/musl constraints that existed before the package
rename while retaining the new nemoclaw-plugin identity.
- Refresh the protected npm cache seed's lock SHA-256; its 85-archive
content remains unchanged.
- Assert that the reviewed glibc cache graph excludes Linux x64 musl
archives.

## Verification

- Focused OpenClaw integrity contract — 8 tests passed.
- Regenerated protected cache seed comparison — exact match, 85
archives, lock hash
b068d818f3a685538009e0258c62074a55328b21563d74c172546464259d9cbe.
- npm run test:changed — 45 growth-guardrail tests passed; no affected
cli/plugin/e2e-support tests.
- npm run checks:repository — passed.
- npm run validate:pr — passed after building the fresh worktree's CLI
artifacts.
- Diff inspected for secrets, API keys, and credentials — none present.

## Review notes

This is an independent main-branch CI hotfix. It intentionally does not
add the four musl archives to a glibc protected image cache.

---
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Expanded integrity validation to confirm that the locked package cache
excludes the Linux x64 musl archive while preserving pinned versions,
integrity data, download URLs, and lock hashes.

- **Chores**
- Updated package cache verification metadata to reflect the current
lock checksum.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: packaging Packages, images, registries, installers, or distribution chore Build, CI, dependency, or tooling maintenance integration: openclaw OpenClaw integration behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants