build(pkg): separate root CLI and OpenClaw plugin package identities - #10518
Conversation
Signed-off-by: Ho Lim <subhoya@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe package manifest name changes from ChangesPackage Rename
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The package identity rename and lockfile synchronization have no identified current merge-readiness risk. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
✨ Thanks for the packaging work. This cleanly separates the OpenClaw plugin identity from the root CLI as outlined in RFC 0002. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
PR Review Advisor finished for commit |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
## Outcome Restore the plugin lockfile's Linux libc constraints so the protected glibc npm cache seed remains exact and PR merge-ref CI no longer fails its integrity contract. ## Reason PR #10518 correctly renamed the plugin package, but its lockfile rewrite also removed 26 existing libc constraints. The checked-in protected-cache manifest still described the prior 85-archive glibc graph, while the rewritten lock selected four additional musl archives and had a different hash. This currently breaks CLI shard 6 for PRs tested against main, including #11173. ## Changes - Restore the 26 glibc/musl constraints that existed before the package rename while retaining the new nemoclaw-plugin identity. - Refresh the protected npm cache seed's lock SHA-256; its 85-archive content remains unchanged. - Assert that the reviewed glibc cache graph excludes Linux x64 musl archives. ## Verification - Focused OpenClaw integrity contract — 8 tests passed. - Regenerated protected cache seed comparison — exact match, 85 archives, lock hash b068d818f3a685538009e0258c62074a55328b21563d74c172546464259d9cbe. - npm run test:changed — 45 growth-guardrail tests passed; no affected cli/plugin/e2e-support tests. - npm run checks:repository — passed. - npm run validate:pr — passed after building the fresh worktree's CLI artifacts. - Diff inspected for secrets, API keys, and credentials — none present. ## Review notes This is an independent main-branch CI hotfix. It intentionally does not add the four musl archives to a glibc protected image cache. --- Signed-off-by: Julie Yaunches <jyaunches@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Expanded integrity validation to confirm that the locked package cache excludes the Linux x64 musl archive while preserving pinned versions, integrity data, download URLs, and lock hashes. - **Chores** - Updated package cache verification metadata to reflect the current lock checksum. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
This pull request implements the first preparation step recommended in Discussion #9909 (RFC 0002) by giving distinct package identities to the root CLI and the OpenClaw plugin.
Key Changes
nemoclaw/package.jsonto use package name"nemoclaw-plugin", resolving the name collision with the root CLI package ("nemoclaw").nemoclaw/package-lock.jsonwith the updated package identity.Verification
npm run checks:repositorypassed with 0 errors.npm run typecheck:clipassed.npm run lintpassed with 0 errors.npm --prefix nemoclaw run build).Signed-off-by: Ho Lim subhoya@gmail.com
Summary by CodeRabbit
nemoclaw-plugin.