-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to peft & virtual pipeline parallel unsupported check #8216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setup Signed-off-by: Valerie Sarge <[email protected]>
5b3349d
to
32d7b82
Compare
@cuichenx / @ericharper can you review? Thanks! |
jenkins |
erhoo82
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yaoyu-33
pushed a commit
that referenced
this pull request
Jan 31, 2024
… setup (#8216) Signed-off-by: Valerie Sarge <[email protected]>
stevehuang52
pushed a commit
that referenced
this pull request
Jan 31, 2024
… setup (#8216) Signed-off-by: Valerie Sarge <[email protected]> Signed-off-by: stevehuang52 <[email protected]>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
… setup (NVIDIA#8216) Signed-off-by: Valerie Sarge <[email protected]> Signed-off-by: Sasha Meister <[email protected]>
pablo-garay
pushed a commit
that referenced
this pull request
Mar 19, 2024
… setup (#8216) Signed-off-by: Valerie Sarge <[email protected]> Signed-off-by: Pablo Garay <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
… setup (NVIDIA#8216) Signed-off-by: Valerie Sarge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Corrects the check added in PR-7964 to raise a ValueError when attempting to run virtual pipeline parallel with peft.
Collection: nlp/language_modeling
Changelog
MegatronGPTSFTModel.__init__
(where self.use_peft had not yet been set to true, so the check did not function) toNLPAdapterModelMixin.add_adapter
Usage
Running with the unsupported combination of peft and virtual pipeline parallel now yields a more useful error message:
gives
Jenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkins
on the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information