-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual pipeline parallel support for MegatronGPTSFTModel #7964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valerie Sarge <[email protected]>
9eddd98
to
c1ad1ca
Compare
ericharper
reviewed
Dec 5, 2023
nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py
Outdated
Show resolved
Hide resolved
ericharper
reviewed
Dec 5, 2023
nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py
Outdated
Show resolved
Hide resolved
…GPTSFTModel into one method Signed-off-by: Valerie Sarge <[email protected]>
…E and MCore, as in MegatronGPTModel Signed-off-by: Valerie Sarge <[email protected]>
Signed-off-by: Valerie Sarge <[email protected]>
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: Valerie Sarge <[email protected]>
for more information, see https://pre-commit.ci
jenkins |
ericharper
reviewed
Jan 14, 2024
nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py
Outdated
Show resolved
Hide resolved
jenkins |
ericharper
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
minitu
pushed a commit
to minitu/NeMo
that referenced
this pull request
Jan 19, 2024
* Virtual pipeline parallel support for MegatronGPTSFTModel Signed-off-by: Valerie Sarge <[email protected]> * Deduplicate word embedding init code in MegatronGPTModel and MegatronGPTSFTModel into one method Signed-off-by: Valerie Sarge <[email protected]> * Correct TP group init call in MegatronGPTSFTModel to check for both TE and MCore, as in MegatronGPTModel Signed-off-by: Valerie Sarge <[email protected]> * Correct accidental double pipeline parallel size check Signed-off-by: Valerie Sarge <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Correct get_gpt_module_list -> get_model_module_list from SFT model Signed-off-by: Valerie Sarge <[email protected]> --------- Signed-off-by: Valerie Sarge <[email protected]> Co-authored-by: Eric Harper <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
akoumpa
pushed a commit
to akoumpa/NeMo
that referenced
this pull request
Jan 20, 2024
* Virtual pipeline parallel support for MegatronGPTSFTModel Signed-off-by: Valerie Sarge <[email protected]> * Deduplicate word embedding init code in MegatronGPTModel and MegatronGPTSFTModel into one method Signed-off-by: Valerie Sarge <[email protected]> * Correct TP group init call in MegatronGPTSFTModel to check for both TE and MCore, as in MegatronGPTModel Signed-off-by: Valerie Sarge <[email protected]> * Correct accidental double pipeline parallel size check Signed-off-by: Valerie Sarge <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Correct get_gpt_module_list -> get_model_module_list from SFT model Signed-off-by: Valerie Sarge <[email protected]> --------- Signed-off-by: Valerie Sarge <[email protected]> Co-authored-by: Eric Harper <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
8 tasks
stevehuang52
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Virtual pipeline parallel support for MegatronGPTSFTModel Signed-off-by: Valerie Sarge <[email protected]> * Deduplicate word embedding init code in MegatronGPTModel and MegatronGPTSFTModel into one method Signed-off-by: Valerie Sarge <[email protected]> * Correct TP group init call in MegatronGPTSFTModel to check for both TE and MCore, as in MegatronGPTModel Signed-off-by: Valerie Sarge <[email protected]> * Correct accidental double pipeline parallel size check Signed-off-by: Valerie Sarge <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Correct get_gpt_module_list -> get_model_module_list from SFT model Signed-off-by: Valerie Sarge <[email protected]> --------- Signed-off-by: Valerie Sarge <[email protected]> Co-authored-by: Eric Harper <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: stevehuang52 <[email protected]>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
* Virtual pipeline parallel support for MegatronGPTSFTModel Signed-off-by: Valerie Sarge <[email protected]> * Deduplicate word embedding init code in MegatronGPTModel and MegatronGPTSFTModel into one method Signed-off-by: Valerie Sarge <[email protected]> * Correct TP group init call in MegatronGPTSFTModel to check for both TE and MCore, as in MegatronGPTModel Signed-off-by: Valerie Sarge <[email protected]> * Correct accidental double pipeline parallel size check Signed-off-by: Valerie Sarge <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Correct get_gpt_module_list -> get_model_module_list from SFT model Signed-off-by: Valerie Sarge <[email protected]> --------- Signed-off-by: Valerie Sarge <[email protected]> Co-authored-by: Eric Harper <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Sasha Meister <[email protected]>
pablo-garay
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Virtual pipeline parallel support for MegatronGPTSFTModel Signed-off-by: Valerie Sarge <[email protected]> * Deduplicate word embedding init code in MegatronGPTModel and MegatronGPTSFTModel into one method Signed-off-by: Valerie Sarge <[email protected]> * Correct TP group init call in MegatronGPTSFTModel to check for both TE and MCore, as in MegatronGPTModel Signed-off-by: Valerie Sarge <[email protected]> * Correct accidental double pipeline parallel size check Signed-off-by: Valerie Sarge <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Correct get_gpt_module_list -> get_model_module_list from SFT model Signed-off-by: Valerie Sarge <[email protected]> --------- Signed-off-by: Valerie Sarge <[email protected]> Co-authored-by: Eric Harper <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Pablo Garay <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Virtual pipeline parallel support for MegatronGPTSFTModel Signed-off-by: Valerie Sarge <[email protected]> * Deduplicate word embedding init code in MegatronGPTModel and MegatronGPTSFTModel into one method Signed-off-by: Valerie Sarge <[email protected]> * Correct TP group init call in MegatronGPTSFTModel to check for both TE and MCore, as in MegatronGPTModel Signed-off-by: Valerie Sarge <[email protected]> * Correct accidental double pipeline parallel size check Signed-off-by: Valerie Sarge <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Correct get_gpt_module_list -> get_model_module_list from SFT model Signed-off-by: Valerie Sarge <[email protected]> --------- Signed-off-by: Valerie Sarge <[email protected]> Co-authored-by: Eric Harper <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Enables running MegatronGPTSFTModel with virtual pipeline parallel when peft_scheme=null.
Collection: NLP (language_modeling)
Changelog
MegatronGPTSFTModel.__init__
to raise a ValueError if self.use_peft is trueUsage
Run a GPT model with SFT and set
virtual_pipeline_model_parallel_size
, such as:Jenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkins
on the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.