Make pipelined TP comm overlap available with mcore #8005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins |
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: Sangkug Lym <[email protected]>
erhoo82
force-pushed
the
slym/tp_overlap_mcore
branch
from
53ba3f4
to
f4721ca
Compare
|
jenkins |
athitten
reviewed
Jan 2, 2024
| @@ -792,12 +792,14 @@ def _validate_and_override_config(self): | |||
| ) % vp_size == 0, 'Make sure the number of model chunks is the same across all pipeline stages.' | |||
|
|
|||
| if self.cfg.get('ub_tp_comm_overlap', False): | |||
| if not self.cfg.get('transformer_engine', False) or not self.cfg.get('sequence_parallel', False): | |||
| if self.cfg.get('ub_tp_comm_overlap', False) and not self.cfg.get('sequence_parallel', False): | |||
There was a problem hiding this comment.
@erhoo82 if self.cfg.get('ub_tp_comm_overlap', False) seems to be redundant in L795 as it already exists in L794.
Signed-off-by: Sangkug Lym <[email protected]>
|
jenkins |
minitu
pushed a commit
to minitu/NeMo
that referenced
this pull request
Jan 19, 2024
* Make pipelined TP comm overlap available with mcore Signed-off-by: Sangkug Lym <[email protected]> * remove unnecessary condition Signed-off-by: Sangkug Lym <[email protected]> --------- Signed-off-by: Sangkug Lym <[email protected]>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
* Make pipelined TP comm overlap available with mcore Signed-off-by: Sangkug Lym <[email protected]> * remove unnecessary condition Signed-off-by: Sangkug Lym <[email protected]> --------- Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: Sasha Meister <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Make pipelined TP comm overlap available with mcore Signed-off-by: Sangkug Lym <[email protected]> * remove unnecessary condition Signed-off-by: Sangkug Lym <[email protected]> --------- Signed-off-by: Sangkug Lym <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Enable the use of pipelined tensor-parallel communication overlap with mcore path.
Removed the condition that enables the use of
ub_tp_comm_overlaponly withtransformer_engine=True.Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information