SFT patch: (1) enable sequence parallelism and (2) enable profile #7963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Sangkug Lym <[email protected]>
ericharper
reviewed
Dec 5, 2023
| self._reset_activation_checkpointing_args() | ||
| self._reset_sequence_parallelism_args() |
There was a problem hiding this comment.
This is good we need to remove from the constructor. But we probably need conditionals for the other calls.
@hsiehjackson could you please review?
|
jenkins |
8 tasks
|
@hsiehjackson |
|
@erhoo82 for inference do you mean generation mode instead of calculating validation loss? This assert needs config |
Signed-off-by: Selvaraj Anandaraj <[email protected]>
|
jenkins |
pzelasko
pushed a commit
to pzelasko/NeMo
that referenced
this pull request
Jan 3, 2024
…IDIA#7963) * SFT profile start and end step fix Signed-off-by: Sangkug Lym <[email protected]> * Removed sequence parallelism assertion check Signed-off-by: Selvaraj Anandaraj <[email protected]> --------- Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: Selvaraj Anandaraj <[email protected]> Co-authored-by: Selvaraj Anandaraj <[email protected]> Co-authored-by: Cheng-Ping Hsieh <[email protected]> Signed-off-by: Piotr Żelasko <[email protected]>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
…IDIA#7963) * SFT profile start and end step fix Signed-off-by: Sangkug Lym <[email protected]> * Removed sequence parallelism assertion check Signed-off-by: Selvaraj Anandaraj <[email protected]> --------- Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: Selvaraj Anandaraj <[email protected]> Co-authored-by: Selvaraj Anandaraj <[email protected]> Co-authored-by: Cheng-Ping Hsieh <[email protected]> Signed-off-by: Sasha Meister <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…IDIA#7963) * SFT profile start and end step fix Signed-off-by: Sangkug Lym <[email protected]> * Removed sequence parallelism assertion check Signed-off-by: Selvaraj Anandaraj <[email protected]> --------- Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: Selvaraj Anandaraj <[email protected]> Co-authored-by: Selvaraj Anandaraj <[email protected]> Co-authored-by: Cheng-Ping Hsieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
SFT patch: (1) enable sequence parallelism and (2) enable profile
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information