migration to PTL 2.0 for spellmapper model #7924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandra Antonova <[email protected]>
|
@athitten this change is similar to yours, could you review? |
|
@titu1994, can you review or assign somebody? |
|
@athitten can you review this? |
|
jenkins |
athitten
reviewed
Nov 30, 2023
| """ | ||
| Called at the end of validation to aggregate outputs. | ||
| :param outputs: list of individual outputs of each validation step. | ||
| """ | ||
| avg_loss = torch.stack([x['val_loss'] for x in outputs]).mean() | ||
| avg_loss = torch.stack([x['val_loss'] for x in self.validation_step_outputs]).mean() |
There was a problem hiding this comment.
@bene-ges shouldn't we be using self.test_step_outputs when called via on_test_epoch_end. Maybe we want to check if we are doing val or test and use the outputs accordingly.
There was a problem hiding this comment.
@athitten , I fixed it in new commit
There was a problem hiding this comment.
I checked /NeMo/examples/nlp/spellchecking_asr_customization/run_training.sh - it works ok.
|
@ericharper, why my jenkins hangs forever? I don't have rights to see on it |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nemo/collections/nlp/models/spellchecking_asr_customization/spellchecking_model.py
Fixed
Show resolved
Hide resolved
Signed-off-by: Alexandra Antonova <[email protected]>
…e-ges/NeMo into newptl_fix_validation_in_spellmapper
|
jenkins |
|
@titu1994, jenkins passed |
|
@athitten, @ericharper what about this pr? All checks passed |
pzelasko
pushed a commit
to pzelasko/NeMo
that referenced
this pull request
Jan 3, 2024
* migrate to PTL 2.0 Signed-off-by: Alexandra Antonova <[email protected]> * add difference between val and test Signed-off-by: Alexandra Antonova <[email protected]> * fix warning about potential uninitialized variable Signed-off-by: Alexandra Antonova <[email protected]> --------- Signed-off-by: Alexandra Antonova <[email protected]> Signed-off-by: Piotr Żelasko <[email protected]>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
* migrate to PTL 2.0 Signed-off-by: Alexandra Antonova <[email protected]> * add difference between val and test Signed-off-by: Alexandra Antonova <[email protected]> * fix warning about potential uninitialized variable Signed-off-by: Alexandra Antonova <[email protected]> --------- Signed-off-by: Alexandra Antonova <[email protected]> Signed-off-by: Sasha Meister <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* migrate to PTL 2.0 Signed-off-by: Alexandra Antonova <[email protected]> * add difference between val and test Signed-off-by: Alexandra Antonova <[email protected]> * fix warning about potential uninitialized variable Signed-off-by: Alexandra Antonova <[email protected]> --------- Signed-off-by: Alexandra Antonova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
migration to PTL 2.0 for spellmapper model, same as in #7597
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information