Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Training - NotImplementedError #15

Closed
thomaschhh opened this issue Nov 20, 2023 · 4 comments
Closed

Training - NotImplementedError #15

thomaschhh opened this issue Nov 20, 2023 · 4 comments

Comments

@thomaschhh
Copy link
Contributor

When running run_training.sh

I get the following error:

NotImplementedError: Support for validation_epoch_end has been removed in v2.0.0. SpellcheckingAsrCustomizationModel implements this method. You can use the on_validation_epoch_end hook instead. To access outputs, save them in-memory as instance attributes. You can find migration examples in Lightning-AI/pytorch-lightning#16520.

My pytorch-lightning version is 2.0.9. How did fix this on your side?
@bene-ges
Copy link
Owner

Thank you for this observation, I will try to fix it tomorrow

@bene-ges
Copy link
Owner

I created a PR in nemo, though it can take some time before they accept it.
You can look at the changes and test them yourself

@thomaschhh
Copy link
Contributor Author

This looks good, thank you.

Let's leave this open until they accept your PR.

@bene-ges
Copy link
Owner

@thomaschhh this PR was finally merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bene-ges @thomaschhh